[JSC] Fix Win crash in Temporal since/until methods

https://bugs.webkit.org/show_bug.cgi?id=254650

Reviewed by Mark Lam.

Without a JSC testbot for Windows, we hadn't noticed that Temporal.{PlainDate, PlainTime}#{since, until} can crash.

The crux of the issue seems to be in having a static constexpr std::initializer_list array,
but this can just be a static local anyway.

* Source/JavaScriptCore/runtime/TemporalObject.cpp:
(JSC::extractDifferenceOptions):

Canonical link: https://commits.webkit.org/262273@main

Author: rkirsling

Source/JavaScriptCore/runtime/TemporalObject.cpp

@@ -300,15 +300,15 @@ std::optional<TemporalUnit> temporalSmallestUnit(JSGlobalObject* globalObject, J
     return unitType;
 }
 
-static constexpr std::initializer_list<TemporalUnit> disallowedUnits[] = {
-    { },
-    { TemporalUnit::Hour, TemporalUnit::Minute, TemporalUnit::Second, TemporalUnit::Millisecond, TemporalUnit::Microsecond, TemporalUnit::Nanosecond },
-    { TemporalUnit::Year, TemporalUnit::Month, TemporalUnit::Week, TemporalUnit::Day }
-};
-
 // https://tc39.es/proposal-temporal/#sec-temporal-getdifferencesettings
 std::tuple<TemporalUnit, TemporalUnit, RoundingMode, double> extractDifferenceOptions(JSGlobalObject* globalObject, JSValue optionsValue, UnitGroup unitGroup, TemporalUnit defaultSmallestUnit, TemporalUnit defaultLargestUnit)
 {
+    static std::initializer_list<TemporalUnit> disallowedUnits[] = {
+        { },
+        { TemporalUnit::Hour, TemporalUnit::Minute, TemporalUnit::Second, TemporalUnit::Millisecond, TemporalUnit::Microsecond, TemporalUnit::Nanosecond },
+        { TemporalUnit::Year, TemporalUnit::Month, TemporalUnit::Week, TemporalUnit::Day }
+    };
+
     VM& vm = globalObject->vm();
     auto scope = DECLARE_THROW_SCOPE(vm);