Skip to content
Permalink
Browse files
[CSS Regions] Enabling regions on Windows lead to crash-on-launch for…
… WebKit.exe

https://bugs.webkit.org/show_bug.cgi?id=90435

Patch by Mihai Balan <mibalan@adobe.com> on 2012-07-03
Reviewed by Csaba Osztrogonác.

Initial patch for enabling regions led to WebKit crashing on launch. Moving the
IDL declarations for CSS regions getter/setter at the end of the file solves the
problem. As per http://trac.webkit.org/changeset/95650 seems it has to do with
binary compatibility.

* Interfaces/IWebPreferences.idl: Mover getter/setter for CSS regions at the end of file

Canonical link: https://commits.webkit.org/108315@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121755 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
mibalan authored and webkit-commit-queue committed Jul 3, 2012
1 parent 9473927 commit 14c873291005abeade5c45701853ab391cb7ff5e
Showing 2 changed files with 17 additions and 3 deletions.
@@ -1,3 +1,17 @@
2012-07-03 Mihai Balan <mibalan@adobe.com>

[CSS Regions] Enabling regions on Windows lead to crash-on-launch for WebKit.exe
https://bugs.webkit.org/show_bug.cgi?id=90435

Reviewed by Csaba Osztrogonác.

Initial patch for enabling regions led to WebKit crashing on launch. Moving the
IDL declarations for CSS regions getter/setter at the end of the file solves the
problem. As per http://trac.webkit.org/changeset/95650 seems it has to do with
binary compatibility.

* Interfaces/IWebPreferences.idl: Mover getter/setter for CSS regions at the end of file

2012-07-02 Benjamin Poulain <bpoulain@apple.com>

Do not do any logging initialization when logging is disabled
@@ -124,9 +124,6 @@ interface IWebPreferences : IUnknown
HRESULT arePlugInsEnabled([out, retval] BOOL* enabled);
HRESULT setPlugInsEnabled([in] BOOL enabled);

HRESULT isCSSRegionsEnabled([out, retval] BOOL* enabled);
HRESULT setCSSRegionsEnabled([in] BOOL enabled);

HRESULT allowsAnimatedImages([out, retval] BOOL* enabled);
HRESULT setAllowsAnimatedImages([in] BOOL enabled);
HRESULT allowAnimatedImageLooping([out, retval] BOOL* enabled);
@@ -210,4 +207,7 @@ interface IWebPreferences : IUnknown

HRESULT setShouldDisplayTextDescriptions(BOOL shouldDisplayTextDescriptions);
HRESULT shouldDisplayTextDescriptions(BOOL *shouldDisplayTextDescriptions);

HRESULT isCSSRegionsEnabled([out, retval] BOOL* enabled);
HRESULT setCSSRegionsEnabled([in] BOOL enabled);
}

0 comments on commit 14c8732

Please sign in to comment.