Skip to content
Permalink
Browse files
Web Inspector: Docked inspector repositioned incorrectly when draggin…
…g frame borders

https://bugs.webkit.org/show_bug.cgi?id=139415

Patch by Matt Baker <mattbaker@apple.com> on 2014-12-15
Reviewed by Joseph Pecoraro.

The _ignoreNextInspectedViewFrameDidChange flag wasn't set back to NO after
being tested by inspectedViewFrameDidChange.

* UIProcess/mac/WebInspectorProxyMac.mm:
(-[WKWebInspectorProxyObjCAdapter inspectedViewFrameDidChange:]):

Canonical link: https://commits.webkit.org/157542@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177309 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
LuckyKobold authored and webkit-commit-queue committed Dec 15, 2014
1 parent c36e2c8 commit 15296edfd2986493987808239aeb4fcdf5625b7d
Showing with 16 additions and 3 deletions.
  1. +13 −0 Source/WebKit2/ChangeLog
  2. +3 −3 Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm
@@ -1,3 +1,16 @@
2014-12-15 Matt Baker <mattbaker@apple.com>

Web Inspector: Docked inspector repositioned incorrectly when dragging frame borders
https://bugs.webkit.org/show_bug.cgi?id=139415

Reviewed by Joseph Pecoraro.

The _ignoreNextInspectedViewFrameDidChange flag wasn't set back to NO after
being tested by inspectedViewFrameDidChange.

* UIProcess/mac/WebInspectorProxyMac.mm:
(-[WKWebInspectorProxyObjCAdapter inspectedViewFrameDidChange:]):

2014-12-15 Gavin Barraclough <barraclough@apple.com>

Simplify tracking of process suppression disabled for PluginProcessManager
@@ -145,10 +145,10 @@ - (void)ignoreNextInspectedViewFrameDidChange

- (void)inspectedViewFrameDidChange:(NSNotification *)notification
{
if (_ignoreNextInspectedViewFrameDidChange)
if (_ignoreNextInspectedViewFrameDidChange) {
_ignoreNextInspectedViewFrameDidChange = NO;
return;

_ignoreNextInspectedViewFrameDidChange = NO;
}

// Resizing the views while inside this notification can lead to bad results when entering
// or exiting full screen. To avoid that we need to perform the work after a delay. We only

0 comments on commit 15296ed

Please sign in to comment.