Please sign in to comment.
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Caches::m_storage should be set to null in case of error at initializ…
…ation time https://bugs.webkit.org/show_bug.cgi?id=183068 Patch by Youenn Fablet <email@example.com> on 2018-02-26 Reviewed by Chris Dumez. In case of error, we need to set m_storage back to nullptr so that next tries to initialize it will restart from scratch. If we do not set it to nullptr, we end up storing the initialize callback in a queue and the callback will never be called. This is difficult to test as we need the following conditions: - we need to have an error case, like a disk writing error - we need the web app to open a cache in two different pages/frames at about the same time. * NetworkProcess/cache/CacheStorageEngineCaches.cpp: (WebKit::CacheStorage::Caches::initialize): Canonical link: https://commits.webkit.org/198860@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@229045 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- Loading branch information
Showing with 23 additions and 0 deletions.