Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Unreviewed, rolling out r180184.
https://bugs.webkit.org/show_bug.cgi?id=141733

Caused infinite recursion on js/function-apply-aliased.html
(Requested by ap_ on #webkit).

Reverted changeset:

"REGRESSION(r180060): C Loop crashes"
https://bugs.webkit.org/show_bug.cgi?id=141671
http://trac.webkit.org/changeset/180184

Canonical link: https://commits.webkit.org/159749@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@180248 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
webkit-commit-queue committed Feb 18, 2015
1 parent 9649903 commit 162ebfe
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 1 deletion.
14 changes: 14 additions & 0 deletions Source/JavaScriptCore/ChangeLog
@@ -1,3 +1,17 @@
2015-02-17 Commit Queue <commit-queue@webkit.org>

Unreviewed, rolling out r180184.
https://bugs.webkit.org/show_bug.cgi?id=141733

Caused infinite recursion on js/function-apply-aliased.html
(Requested by ap_ on #webkit).

Reverted changeset:

"REGRESSION(r180060): C Loop crashes"
https://bugs.webkit.org/show_bug.cgi?id=141671
http://trac.webkit.org/changeset/180184

2015-02-17 Michael Saboff <msaboff@apple.com>

CrashTracer: DFG_CRASH beneath JSC::FTL::LowerDFGToLLVM::compileNode
Expand Down
1 change: 1 addition & 0 deletions Source/JavaScriptCore/llint/LLIntSlowPaths.cpp
Expand Up @@ -490,6 +490,7 @@ LLINT_SLOW_PATH_DECL(stack_check)
LLINT_RETURN_TWO(pc, 0);
#endif

exec = exec->callerFrame(vm.topVMEntryFrame);
vm.topCallFrame = exec;
ErrorHandlingScope errorScope(vm);
CommonSlowPaths::interpreterThrowInCaller(exec, createStackOverflowError(exec));
Expand Down
2 changes: 1 addition & 1 deletion Source/JavaScriptCore/llint/LowLevelInterpreter.asm
Expand Up @@ -633,7 +633,7 @@ macro prologue(codeBlockGetter, codeBlockSetter, osrSlowPath, traceSlowPath)
.stackHeightOKGetCodeBlock:
# Stack check slow path returned that the stack was ok.
# Since they were clobbered, need to get CodeBlock and new sp
codeBlockGetter(t1)
codeBlockSetter(t1)
getFrameRegisterSizeForCodeBlock(t1, t0)
subp cfr, t0, t0

Expand Down

0 comments on commit 162ebfe

Please sign in to comment.