Permalink
Show file tree
Hide file tree
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
USE_SYSTEM_CONTENT_PATH and USE_STAGING_INSTALL_PATH should be able t…
…o coexist https://bugs.webkit.org/show_bug.cgi?id=240723 rdar://92000421 Reviewed by Michael Saboff. Make it possible to build with both USE_SYSTEM_CONTENT_PATH and USE_STAGING_INSTALL_PATH enabled. With USE_STAGING_INSTALL_PATH, all the frameworks and dylibs will be relocated to a common "StagedFrameworks" directory, but USE_SYSTEM_CONTENT_PATH directs the build to locate this directory at a different location, i.e. in a system content path. The presence of USE_STAGING_INSTALL_PATH also disables all targets' current behavior of creating symlinks into the system content path -- in this configuration, the frameworks only need to be referenceable from their location in the StagedFrameworks directory. Throughout this patch, there are multiple common changes to the same build settings: INSTALL_PATH_PREFIX: This variable adds the system content path as a prefix to products' install paths. Leave it empty when USE_STAGING_INSTALL_PATH is set, as the effective prefix will be baked into WK_OVERRIDE_FRAMEWORKS_DIR via WK_INSTALL_PATH_PREFIX instead. OUTPUT_ALTERNATE_ROOT_PATH: Define this as empty under USE_STAGING_INSTALL_PATH, since we don't need to create the symlinks pointing into the system content path. WK_INSTALL_PATH_PREFIX: This variable is used to define a prefix for the override install path when using staged frameworks. Use a different prefix under USE_SYSTEM_CONTENT_PATH. Also remove a now-unneeded comparison against WK_MACOS_1015. WebKit doesn't support building for versions of macOS prior to 10.15, so this *always* would evaluate to 'MACOS_SINCE_1015'. No new tests; no behavior should be changed. (Except for output of this particular build configuration.) * Source/JavaScriptCore/Configurations/Base.xcconfig: Update INSTALL_PATH_PREFIX and WK_INSTALL_PATH_PREFIX. * Source/JavaScriptCore/Configurations/JavaScriptCore.xcconfig: Update OUTPUT_ALTERNATE_ROOT_PATH. * Source/ThirdParty/ANGLE/Configurations/ANGLE-dynamic.xcconfig: Update INSTALL_PATH_PREFIX. * Source/ThirdParty/ANGLE/Configurations/Base.xcconfig: Update WK_INSTALL_PATH_PREFIX. * Source/ThirdParty/libwebrtc/Configurations/Base.xcconfig: Moved the common definition of INSTALL_PATH_PREFIX here, updated WK_INSTALL_PATH_PREFIX. * Source/ThirdParty/libwebrtc/Configurations/boringssl.xcconfig: * Source/ThirdParty/libwebrtc/Configurations/libabsl.xcconfig: * Source/ThirdParty/libwebrtc/Configurations/libsrtp.xcconfig: * Source/ThirdParty/libwebrtc/Configurations/libvpx.xcconfig: * Source/ThirdParty/libwebrtc/Configurations/libwebm.xcconfig: * Source/ThirdParty/libwebrtc/Configurations/libwebrtc.xcconfig: * Source/ThirdParty/libwebrtc/Configurations/libyuv.xcconfig: * Source/ThirdParty/libwebrtc/Configurations/opus.xcconfig: * Source/ThirdParty/libwebrtc/Configurations/usrsctp.xcconfig: Removed definition of INSTALL_PATH_PREFIX, which has been moved to Base.xcconfig. (x9) * Source/ThirdParty/libwebrtc/Scripts/create-symlink-to-altroot.sh: Avoid creating any symlinks when USE_STAGING_INSTALL_PATH is set. * Source/WebCore/Configurations/WebCore.xcconfig: Update INSTALL_PATH_PREFIX and WK_INSTALL_PATH_PREFIX. * Source/WebCore/PAL/Configurations/PAL.xcconfig: Update WK_INSTALL_PATH_PREFIX. * Source/WebGPU/Configurations/WebGPU.xcconfig: Update INSTALL_PATH_PREFIX, OUTPUT_ALTERNATE_ROOT_PATH, and WK_INSTALL_PATH_PREFIX. * Source/WebInspectorUI/Configurations/Base.xcconfig: Update WK_INSTALL_PATH_PREFIX. * Source/WebInspectorUI/Configurations/WebInspectorUIFramework.xcconfig: Modify the definition of INSTALL_PATH so that the "override-ness" of WK_USE_OVERRIDE_FRAMEWORKS_DIR takes precedence over USE_SYSTEM_CONTENT_PATH. With these two set, WebInspectorUI.framework should end up in the override path (e.g. the StagedFrameworks directory), rather than the standard system content path location. Also update OUTPUT_ALTERNATE_ROOT_PATH. * Source/WebKit/Configurations/Base.xcconfig: Update INSTALL_PATH_PREFIX. * Source/WebKit/Configurations/BaseTarget.xcconfig: Update WK_INSTALL_PATH_PREFIX. * Source/WebKit/Configurations/WebKit.xcconfig: Update OUTPUT_ALTERNATE_ROOT_PATH. * Source/WebKit/Configurations/adattributiond.xcconfig: Somewhat unrelated tweak -- remove WK_OVERRIDE_FRAMEWORKS_DIR from this file since it is redundant with the definition of this setting in BaseTarget.xcconfig. * Source/WebKitLegacy/mac/Configurations/Base.xcconfig: Update INSTALL_PATH_PREFIX. * Source/WebKitLegacy/mac/Configurations/WebKitLegacy.xcconfig: Update WK_INSTALL_PATH_PREFIX. Canonical link: https://commits.webkit.org/250989@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294855 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- Loading branch information
1 parent
ee32ad0
commit 1732fbdc660a88e664b8a17c56c5662284521292
Showing
26 changed files
with
67 additions
and
73 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@@ -2,7 +2,7 @@ | ||
|
||
set -e | ||
|
||
if [[ "${SKIP_INSTALL}" == "YES" ]]; then | ||
if [[ "${SKIP_INSTALL}" == "YES" || "${USE_STAGING_INSTALL_PATH}" == "YES" ]]; then | ||
exit 0 | ||
fi | ||
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.