Permalink
Show file tree
Hide file tree
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
[GPUP] Send GPU preferences in single IPC message
https://bugs.webkit.org/show_bug.cgi?id=241809 rdar://95636552 Patch by Youssef Soliman <youssefdevelops@gmail.com> on 2022-06-21 Reviewed by Eric Carlson. Currently the `GPUProcessProxy::updatePreferences` method sends preferences from the web process in multiple IPC messages to the GPU process. These messages should be consolidated into one package and sent across in a single message. * Source/WebKit/GPUProcess/GPUProcess.cpp: (WebKit::GPUProcess::updateGPUProcessPreferences): (WebKit::GPUProcess::updatePreference): (WebKit::GPUProcess::setWebMParserEnabled): Deleted. (WebKit::GPUProcess::setWebMFormatReaderEnabled): Deleted. (WebKit::GPUProcess::setOpusDecoderEnabled): Deleted. (WebKit::GPUProcess::setVorbisDecoderEnabled): Deleted. (WebKit::GPUProcess::setMediaSourceInlinePaintingEnabled): Deleted. (WebKit::GPUProcess::setSampleBufferContentKeySessionSupportEnabled): Deleted. * Source/WebKit/GPUProcess/GPUProcess.h: * Source/WebKit/GPUProcess/GPUProcess.messages.in: * Source/WebKit/GPUProcess/GPUProcessPreferences.cpp: Added. (WebKit::GPUProcessPreferences::encode const): (WebKit::GPUProcessPreferences::decode): * Source/WebKit/GPUProcess/GPUProcessPreferences.h: Added. * Source/WebKit/Sources.txt: * Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp: (WebKit::GPUProcessProxy::updatePreferences): * Source/WebKit/UIProcess/GPU/GPUProcessProxy.h: * Source/WebKit/WebKit.xcodeproj/project.pbxproj: Canonical link: https://commits.webkit.org/251713@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@295708 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- Loading branch information
1 parent
c7aa5b9
commit 187eb34
Showing
9 changed files
with
255 additions
and
177 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,104 @@ | ||
| /* | ||
| * Copyright (C) 2022 Apple Inc. All rights reserved. | ||
| * | ||
| * Redistribution and use in source and binary forms, with or without | ||
| * modification, are permitted provided that the following conditions | ||
| * are met: | ||
| * 1. Redistributions of source code must retain the above copyright | ||
| * notice, this list of conditions and the following disclaimer. | ||
| * 2. Redistributions in binary form must reproduce the above copyright | ||
| * notice, this list of conditions and the following disclaimer in the | ||
| * documentation and/or other materials provided with the distribution. | ||
| * | ||
| * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' | ||
| * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, | ||
| * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR | ||
| * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS | ||
| * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR | ||
| * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF | ||
| * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS | ||
| * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN | ||
| * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) | ||
| * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF | ||
| * THE POSSIBILITY OF SUCH DAMAGE. | ||
| */ | ||
|
|
||
| #include "config.h" | ||
| #include "GPUProcessPreferences.h" | ||
|
|
||
| #if ENABLE(GPU_PROCESS) | ||
|
|
||
| #include "ArgumentCoders.h" | ||
|
|
||
| #if PLATFORM(COCOA) | ||
| #include "ArgumentCodersCF.h" | ||
| #endif | ||
|
|
||
| namespace WebKit { | ||
|
|
||
| GPUProcessPreferences::GPUProcessPreferences() = default; | ||
|
|
||
| void GPUProcessPreferences::encode(IPC::Encoder& encoder) const | ||
| { | ||
| #if ENABLE(OPUS) | ||
| encoder << opusDecoderEnabled; | ||
| #endif | ||
|
|
||
| #if ENABLE(VORBIS) | ||
| encoder << vorbisDecoderEnabled; | ||
| #endif | ||
|
|
||
| #if ENABLE(WEBM_FORMAT_READER) | ||
| encoder << webMFormatReaderEnabled; | ||
| #endif | ||
|
|
||
| #if ENABLE(MEDIA_SOURCE) && ENABLE(VP9) | ||
| encoder << webMParserEnabled; | ||
| #endif | ||
|
|
||
| #if ENABLE(MEDIA_SOURCE) && HAVE(AVSAMPLEBUFFERVIDEOOUTPUT) | ||
| encoder << mediaSourceInlinePaintingEnabled; | ||
| #endif | ||
|
|
||
| #if HAVE(AVCONTENTKEYSPECIFIER) | ||
| encoder << sampleBufferContentKeySessionSupportEnabled; | ||
| #endif | ||
| } | ||
|
|
||
| bool GPUProcessPreferences::decode(IPC::Decoder& decoder, GPUProcessPreferences& result) | ||
| { | ||
| #if ENABLE(OPUS) | ||
| if (!decoder.decode(result.opusDecoderEnabled)) | ||
| return false; | ||
| #endif | ||
|
|
||
| #if ENABLE(VORBIS) | ||
| if (!decoder.decode(result.vorbisDecoderEnabled)) | ||
| return false; | ||
| #endif | ||
|
|
||
| #if ENABLE(WEBM_FORMAT_READER) | ||
| if (!decoder.decode(result.webMFormatReaderEnabled)) | ||
| return false; | ||
| #endif | ||
|
|
||
| #if ENABLE(MEDIA_SOURCE) && ENABLE(VP9) | ||
| if (!decoder.decode(result.webMParserEnabled)) | ||
| return false; | ||
| #endif | ||
|
|
||
| #if ENABLE(MEDIA_SOURCE) && HAVE(AVSAMPLEBUFFERVIDEOOUTPUT) | ||
| if (!decoder.decode(result.mediaSourceInlinePaintingEnabled)) | ||
| return false; | ||
| #endif | ||
|
|
||
| #if HAVE(AVCONTENTKEYSPECIFIER) | ||
| if (!decoder.decode(result.sampleBufferContentKeySessionSupportEnabled)) | ||
| return false; | ||
| #endif | ||
| return true; | ||
| } | ||
|
|
||
| } // namespace WebKit | ||
|
|
||
| #endif // ENABLE(GPU_PROCESS) |
Oops, something went wrong.