Skip to content
Permalink
Browse files
Unreviewed, rolling out r254807.
Breaks Apple internal builds.

Reverted changeset:

"Add support for scroll behavior relies on ScrollAnimation of
the Web process"
https://bugs.webkit.org/show_bug.cgi?id=204882
https://trac.webkit.org/changeset/254807

Canonical link: https://commits.webkit.org/219576@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254839 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
fujii committed Jan 21, 2020
1 parent ac98a83 commit 18d14fecf8e9512e839a3a8cc175df27ba8dd135
Show file tree
Hide file tree
Showing 47 changed files with 203 additions and 371 deletions.
@@ -1,3 +1,16 @@
2020-01-20 Fujii Hironori <Hironori.Fujii@sony.com>

Unreviewed, rolling out r254807.

Breaks Apple internal builds.

Reverted changeset:

"Add support for scroll behavior relies on ScrollAnimation of
the Web process"
https://bugs.webkit.org/show_bug.cgi?id=204882
https://trac.webkit.org/changeset/254807

2020-01-20 Devin Rousso <drousso@apple.com>

inspector/heap/getRemoteObject.html is a flaky failure
@@ -1,3 +1,16 @@
2020-01-20 Fujii Hironori <Hironori.Fujii@sony.com>

Unreviewed, rolling out r254807.

Breaks Apple internal builds.

Reverted changeset:

"Add support for scroll behavior relies on ScrollAnimation of
the Web process"
https://bugs.webkit.org/show_bug.cgi?id=204882
https://trac.webkit.org/changeset/254807

2020-01-20 Rob Buis <rbuis@igalia.com>

Implement "create a potential-CORS request"
@@ -1,4 +1,4 @@

PASS Instant scrolling of an element with default scroll-behavior
PASS Smooth scrolling of an element with default scroll-behavior
FAIL Smooth scrolling of an element with default scroll-behavior assert_less_than: Should not set scrollLeft immediately expected a number less than 500 but got 500

@@ -1,4 +1,4 @@
<!DOCTYPE html><!-- webkit-test-runner [ experimental:CSSOMViewSmoothScrollingEnabled=true ] -->
<!DOCTYPE html>
<title>Testing default value of scroll-behavior</title>
<meta name="timeout" content="long"/>
<link rel="author" title="Frédéric Wang" href="mailto:fwang@igalia.com">
@@ -2,39 +2,39 @@
PASS Element with auto scroll-behavior ; scroll() with default behavior
PASS Element with auto scroll-behavior ; scroll() with auto behavior
PASS Element with auto scroll-behavior ; scroll() with instant behavior
PASS Element with auto scroll-behavior ; scroll() with smooth behavior
PASS Element with smooth scroll-behavior ; scroll() with default behavior
PASS Element with smooth scroll-behavior ; scroll() with auto behavior
FAIL Element with auto scroll-behavior ; scroll() with smooth behavior assert_less_than: Should not set scrollLeft immediately expected a number less than 500 but got 500
FAIL Element with smooth scroll-behavior ; scroll() with default behavior assert_less_than: Should not set scrollLeft immediately expected a number less than 500 but got 500
FAIL Element with smooth scroll-behavior ; scroll() with auto behavior assert_less_than: Should not set scrollLeft immediately expected a number less than 500 but got 500
PASS Element with smooth scroll-behavior ; scroll() with instant behavior
PASS Element with smooth scroll-behavior ; scroll() with smooth behavior
FAIL Element with smooth scroll-behavior ; scroll() with smooth behavior assert_less_than: Should not set scrollLeft immediately expected a number less than 500 but got 500
PASS Element with auto scroll-behavior ; scrollTo() with default behavior
PASS Element with auto scroll-behavior ; scrollTo() with auto behavior
PASS Element with auto scroll-behavior ; scrollTo() with instant behavior
PASS Element with auto scroll-behavior ; scrollTo() with smooth behavior
PASS Element with smooth scroll-behavior ; scrollTo() with default behavior
PASS Element with smooth scroll-behavior ; scrollTo() with auto behavior
FAIL Element with auto scroll-behavior ; scrollTo() with smooth behavior assert_less_than: Should not set scrollLeft immediately expected a number less than 500 but got 500
FAIL Element with smooth scroll-behavior ; scrollTo() with default behavior assert_less_than: Should not set scrollLeft immediately expected a number less than 500 but got 500
FAIL Element with smooth scroll-behavior ; scrollTo() with auto behavior assert_less_than: Should not set scrollLeft immediately expected a number less than 500 but got 500
PASS Element with smooth scroll-behavior ; scrollTo() with instant behavior
PASS Element with smooth scroll-behavior ; scrollTo() with smooth behavior
FAIL Element with smooth scroll-behavior ; scrollTo() with smooth behavior assert_less_than: Should not set scrollLeft immediately expected a number less than 500 but got 500
PASS Element with auto scroll-behavior ; scrollBy() with default behavior
PASS Element with auto scroll-behavior ; scrollBy() with auto behavior
PASS Element with auto scroll-behavior ; scrollBy() with instant behavior
PASS Element with auto scroll-behavior ; scrollBy() with smooth behavior
PASS Element with smooth scroll-behavior ; scrollBy() with default behavior
PASS Element with smooth scroll-behavior ; scrollBy() with auto behavior
FAIL Element with auto scroll-behavior ; scrollBy() with smooth behavior assert_less_than: Should not set scrollLeft immediately expected a number less than 500 but got 500
FAIL Element with smooth scroll-behavior ; scrollBy() with default behavior assert_less_than: Should not set scrollLeft immediately expected a number less than 500 but got 500
FAIL Element with smooth scroll-behavior ; scrollBy() with auto behavior assert_less_than: Should not set scrollLeft immediately expected a number less than 500 but got 500
PASS Element with smooth scroll-behavior ; scrollBy() with instant behavior
PASS Element with smooth scroll-behavior ; scrollBy() with smooth behavior
FAIL Element with smooth scroll-behavior ; scrollBy() with smooth behavior assert_less_than: Should not set scrollLeft immediately expected a number less than 500 but got 500
PASS Element with auto scroll-behavior ; scrollIntoView() with default behavior
PASS Element with auto scroll-behavior ; scrollIntoView() with auto behavior
PASS Element with auto scroll-behavior ; scrollIntoView() with instant behavior
PASS Element with auto scroll-behavior ; scrollIntoView() with smooth behavior
PASS Element with smooth scroll-behavior ; scrollIntoView() with default behavior
PASS Element with smooth scroll-behavior ; scrollIntoView() with auto behavior
FAIL Element with auto scroll-behavior ; scrollIntoView() with smooth behavior assert_less_than: Should not set scrollLeft immediately expected a number less than 500 but got 500
FAIL Element with smooth scroll-behavior ; scrollIntoView() with default behavior assert_less_than: Should not set scrollLeft immediately expected a number less than 500 but got 500
FAIL Element with smooth scroll-behavior ; scrollIntoView() with auto behavior assert_less_than: Should not set scrollLeft immediately expected a number less than 500 but got 500
PASS Element with smooth scroll-behavior ; scrollIntoView() with instant behavior
PASS Element with smooth scroll-behavior ; scrollIntoView() with smooth behavior
FAIL Element with smooth scroll-behavior ; scrollIntoView() with smooth behavior assert_less_than: Should not set scrollLeft immediately expected a number less than 500 but got 500
PASS Set scrollLeft to element with auto scroll-behavior
PASS Set scrollLeft to element with smooth scroll-behavior
FAIL Set scrollLeft to element with smooth scroll-behavior assert_less_than: Shouldn't set scroll attribute immediately expected a number less than 500 but got 500
PASS Set scrollTop to element with auto scroll-behavior
PASS Set scrollTop to element with smooth scroll-behavior
FAIL Set scrollTop to element with smooth scroll-behavior assert_less_than: Shouldn't set scroll attribute immediately expected a number less than 250 but got 250
PASS Aborting an ongoing smooth scrolling on an element with another smooth scrolling
PASS Aborting an ongoing smooth scrolling on an element with an instant scrolling

@@ -1,4 +1,4 @@
<!DOCTYPE html><!-- webkit-test-runner [ experimental:CSSOMViewSmoothScrollingEnabled=true ] -->
<!DOCTYPE html>
<title>Testing scrollOptions' behavior for Element.scroll* and scroll-behavior on an element</title>
<meta name="timeout" content="long"/>
<link rel="author" title="Frédéric Wang" href="mailto:fwang@igalia.com">
@@ -3,39 +3,39 @@ PASS Page loaded
PASS Main frame with auto scroll-behavior ; scroll() with default behavior
PASS Main frame with auto scroll-behavior ; scroll() with auto behavior
PASS Main frame with auto scroll-behavior ; scroll() with instant behavior
PASS Main frame with auto scroll-behavior ; scroll() with smooth behavior
PASS Main frame with smooth scroll-behavior ; scroll() with default behavior
PASS Main frame with smooth scroll-behavior ; scroll() with auto behavior
FAIL Main frame with auto scroll-behavior ; scroll() with smooth behavior assert_less_than: Should not set scrollLeft immediately expected a number less than 2430 but got 2430
FAIL Main frame with smooth scroll-behavior ; scroll() with default behavior assert_less_than: Should not set scrollLeft immediately expected a number less than 2430 but got 2430
FAIL Main frame with smooth scroll-behavior ; scroll() with auto behavior assert_less_than: Should not set scrollLeft immediately expected a number less than 2430 but got 2430
PASS Main frame with smooth scroll-behavior ; scroll() with instant behavior
PASS Main frame with smooth scroll-behavior ; scroll() with smooth behavior
FAIL Main frame with smooth scroll-behavior ; scroll() with smooth behavior assert_less_than: Should not set scrollLeft immediately expected a number less than 2430 but got 2430
PASS Main frame with auto scroll-behavior ; scrollTo() with default behavior
PASS Main frame with auto scroll-behavior ; scrollTo() with auto behavior
PASS Main frame with auto scroll-behavior ; scrollTo() with instant behavior
PASS Main frame with auto scroll-behavior ; scrollTo() with smooth behavior
PASS Main frame with smooth scroll-behavior ; scrollTo() with default behavior
PASS Main frame with smooth scroll-behavior ; scrollTo() with auto behavior
FAIL Main frame with auto scroll-behavior ; scrollTo() with smooth behavior assert_less_than: Should not set scrollLeft immediately expected a number less than 2430 but got 2430
FAIL Main frame with smooth scroll-behavior ; scrollTo() with default behavior assert_less_than: Should not set scrollLeft immediately expected a number less than 2430 but got 2430
FAIL Main frame with smooth scroll-behavior ; scrollTo() with auto behavior assert_less_than: Should not set scrollLeft immediately expected a number less than 2430 but got 2430
PASS Main frame with smooth scroll-behavior ; scrollTo() with instant behavior
PASS Main frame with smooth scroll-behavior ; scrollTo() with smooth behavior
FAIL Main frame with smooth scroll-behavior ; scrollTo() with smooth behavior assert_less_than: Should not set scrollLeft immediately expected a number less than 2430 but got 2430
PASS Main frame with auto scroll-behavior ; scrollBy() with default behavior
PASS Main frame with auto scroll-behavior ; scrollBy() with auto behavior
PASS Main frame with auto scroll-behavior ; scrollBy() with instant behavior
PASS Main frame with auto scroll-behavior ; scrollBy() with smooth behavior
PASS Main frame with smooth scroll-behavior ; scrollBy() with default behavior
PASS Main frame with smooth scroll-behavior ; scrollBy() with auto behavior
FAIL Main frame with auto scroll-behavior ; scrollBy() with smooth behavior assert_less_than: Should not set scrollLeft immediately expected a number less than 2430 but got 2430
FAIL Main frame with smooth scroll-behavior ; scrollBy() with default behavior assert_less_than: Should not set scrollLeft immediately expected a number less than 2430 but got 2430
FAIL Main frame with smooth scroll-behavior ; scrollBy() with auto behavior assert_less_than: Should not set scrollLeft immediately expected a number less than 2430 but got 2430
PASS Main frame with smooth scroll-behavior ; scrollBy() with instant behavior
PASS Main frame with smooth scroll-behavior ; scrollBy() with smooth behavior
FAIL Main frame with smooth scroll-behavior ; scrollBy() with smooth behavior assert_less_than: Should not set scrollLeft immediately expected a number less than 2430 but got 2430
PASS Main frame with auto scroll-behavior ; scrollIntoView() with default behavior
PASS Main frame with auto scroll-behavior ; scrollIntoView() with auto behavior
PASS Main frame with auto scroll-behavior ; scrollIntoView() with instant behavior
PASS Main frame with auto scroll-behavior ; scrollIntoView() with smooth behavior
PASS Main frame with smooth scroll-behavior ; scrollIntoView() with default behavior
PASS Main frame with smooth scroll-behavior ; scrollIntoView() with auto behavior
FAIL Main frame with auto scroll-behavior ; scrollIntoView() with smooth behavior assert_less_than: Should not set scrollLeft immediately expected a number less than 2430 but got 2430
FAIL Main frame with smooth scroll-behavior ; scrollIntoView() with default behavior assert_less_than: Should not set scrollLeft immediately expected a number less than 2430 but got 2430
FAIL Main frame with smooth scroll-behavior ; scrollIntoView() with auto behavior assert_less_than: Should not set scrollLeft immediately expected a number less than 2430 but got 2430
PASS Main frame with smooth scroll-behavior ; scrollIntoView() with instant behavior
PASS Main frame with smooth scroll-behavior ; scrollIntoView() with smooth behavior
FAIL Main frame with smooth scroll-behavior ; scrollIntoView() with smooth behavior assert_less_than: Should not set scrollLeft immediately expected a number less than 2430 but got 2430
PASS Set scrollLeft to frame with auto scroll-behavior
PASS Set scrollLeft to frame with smooth scroll-behavior
FAIL Set scrollLeft to frame with smooth scroll-behavior assert_less_than: Shouldn't set scroll attribute immediately expected a number less than 2430 but got 2430
PASS Set scrollTop to frame with auto scroll-behavior
PASS Set scrollTop to frame with smooth scroll-behavior
FAIL Set scrollTop to frame with smooth scroll-behavior assert_less_than: Shouldn't set scroll attribute immediately expected a number less than 2480 but got 2480
PASS Aborting an ongoing smooth scrolling on the main frame with another smooth scrolling
PASS Aborting an ongoing smooth scrolling on the main frame with an instant scrolling

@@ -1,4 +1,4 @@
<!DOCTYPE html><!-- webkit-test-runner [ experimental:CSSOMViewSmoothScrollingEnabled=true ] -->
<!DOCTYPE html>
<title>Testing scrollOptions' behavior for Element.scroll* and scroll-behavior on the root of the main frame</title>
<meta name="timeout" content="long"/>
<link rel="author" title="Frédéric Wang" href="mailto:fwang@igalia.com">
@@ -3,27 +3,27 @@ PASS Page loaded
PASS Main frame with auto scroll-behavior ; scroll() with default behavior
PASS Main frame with auto scroll-behavior ; scroll() with auto behavior
PASS Main frame with auto scroll-behavior ; scroll() with instant behavior
PASS Main frame with auto scroll-behavior ; scroll() with smooth behavior
PASS Main frame with smooth scroll-behavior ; scroll() with default behavior
PASS Main frame with smooth scroll-behavior ; scroll() with auto behavior
FAIL Main frame with auto scroll-behavior ; scroll() with smooth behavior assert_less_than: Should not set scrollLeft immediately expected a number less than 2430 but got 2430
FAIL Main frame with smooth scroll-behavior ; scroll() with default behavior assert_less_than: Should not set scrollLeft immediately expected a number less than 2430 but got 2430
FAIL Main frame with smooth scroll-behavior ; scroll() with auto behavior assert_less_than: Should not set scrollLeft immediately expected a number less than 2430 but got 2430
PASS Main frame with smooth scroll-behavior ; scroll() with instant behavior
PASS Main frame with smooth scroll-behavior ; scroll() with smooth behavior
FAIL Main frame with smooth scroll-behavior ; scroll() with smooth behavior assert_less_than: Should not set scrollLeft immediately expected a number less than 2430 but got 2430
PASS Main frame with auto scroll-behavior ; scrollTo() with default behavior
PASS Main frame with auto scroll-behavior ; scrollTo() with auto behavior
PASS Main frame with auto scroll-behavior ; scrollTo() with instant behavior
PASS Main frame with auto scroll-behavior ; scrollTo() with smooth behavior
PASS Main frame with smooth scroll-behavior ; scrollTo() with default behavior
PASS Main frame with smooth scroll-behavior ; scrollTo() with auto behavior
FAIL Main frame with auto scroll-behavior ; scrollTo() with smooth behavior assert_less_than: Should not set scrollLeft immediately expected a number less than 2430 but got 2430
FAIL Main frame with smooth scroll-behavior ; scrollTo() with default behavior assert_less_than: Should not set scrollLeft immediately expected a number less than 2430 but got 2430
FAIL Main frame with smooth scroll-behavior ; scrollTo() with auto behavior assert_less_than: Should not set scrollLeft immediately expected a number less than 2430 but got 2430
PASS Main frame with smooth scroll-behavior ; scrollTo() with instant behavior
PASS Main frame with smooth scroll-behavior ; scrollTo() with smooth behavior
FAIL Main frame with smooth scroll-behavior ; scrollTo() with smooth behavior assert_less_than: Should not set scrollLeft immediately expected a number less than 2430 but got 2430
PASS Main frame with auto scroll-behavior ; scrollBy() with default behavior
PASS Main frame with auto scroll-behavior ; scrollBy() with auto behavior
PASS Main frame with auto scroll-behavior ; scrollBy() with instant behavior
PASS Main frame with auto scroll-behavior ; scrollBy() with smooth behavior
PASS Main frame with smooth scroll-behavior ; scrollBy() with default behavior
PASS Main frame with smooth scroll-behavior ; scrollBy() with auto behavior
FAIL Main frame with auto scroll-behavior ; scrollBy() with smooth behavior assert_less_than: Should not set scrollLeft immediately expected a number less than 2430 but got 2430
FAIL Main frame with smooth scroll-behavior ; scrollBy() with default behavior assert_less_than: Should not set scrollLeft immediately expected a number less than 2430 but got 2430
FAIL Main frame with smooth scroll-behavior ; scrollBy() with auto behavior assert_less_than: Should not set scrollLeft immediately expected a number less than 2430 but got 2430
PASS Main frame with smooth scroll-behavior ; scrollBy() with instant behavior
PASS Main frame with smooth scroll-behavior ; scrollBy() with smooth behavior
FAIL Main frame with smooth scroll-behavior ; scrollBy() with smooth behavior assert_less_than: Should not set scrollLeft immediately expected a number less than 2430 but got 2430
PASS Aborting an ongoing smooth scrolling on the main frame with another smooth scrolling
PASS Aborting an ongoing smooth scrolling on the main frame with an instant scrolling

@@ -1,4 +1,4 @@
<!DOCTYPE html><!-- webkit-test-runner [ experimental:CSSOMViewSmoothScrollingEnabled=true ] -->
<!DOCTYPE html>
<title>Testing scrollOptions' behavior for Element.scroll* on the window of the main frame</title>
<meta name="timeout" content="long"/>
<meta name="viewport" content="width=device-width,minimum-scale=1,initial-scale=1">
@@ -1,3 +1,3 @@

PASS scrollIntoView with nested elements with different scroll-behavior
FAIL scrollIntoView with nested elements with different scroll-behavior assert_less_than: Element with smooth behavior should not scroll immediately expected a number less than 500 but got 500

@@ -1,4 +1,4 @@
<!DOCTYPE html><!-- webkit-test-runner [ experimental:CSSOMViewSmoothScrollingEnabled=true ] -->
<!DOCTYPE html>
<title>Testing scrollOptions' behavior with scrollIntoView for nested scrolling nodes</title>
<meta name="timeout" content="long"/>
<link rel="author" title="Frédéric Wang" href="mailto:fwang@igalia.com">
@@ -1,4 +1,4 @@
<!DOCTYPE html><!-- webkit-test-runner [ experimental:CSSOMViewSmoothScrollingEnabled=true ] -->
<!DOCTYPE html>
<title>Testing scroll positions when scrolling an element with smooth behavior</title>
<meta name="timeout" content="long"/>
<link rel="author" title="Frédéric Wang" href="mailto:fwang@igalia.com">

0 comments on commit 18d14fe

Please sign in to comment.