Skip to content
Permalink
Browse files
kCTFontTableOptionExcludeSynthetic is unneeded
https://bugs.webkit.org/show_bug.cgi?id=79744

Patch by Ned Holbrook <nholbrook@apple.com> on 2012-02-27
Reviewed by Dan Bernstein.

The aforementioned option is a no-op, so no new tests.

* platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::fontHasVerticalGlyphs): Specify no options.

Canonical link: https://commits.webkit.org/96841@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109080 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
Ned Holbrook authored and webkit-commit-queue committed Feb 28, 2012
1 parent 595a992 commit 1a5c11c52febcb92c08094b8f60d7aaaf2f03c6a
Showing with 13 additions and 2 deletions.
  1. +12 −0 Source/WebCore/ChangeLog
  2. +1 −2 Source/WebCore/platform/graphics/mac/SimpleFontDataMac.mm
@@ -1,3 +1,15 @@
2012-02-27 Ned Holbrook <nholbrook@apple.com>

kCTFontTableOptionExcludeSynthetic is unneeded
https://bugs.webkit.org/show_bug.cgi?id=79744

Reviewed by Dan Bernstein.

The aforementioned option is a no-op, so no new tests.

* platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::fontHasVerticalGlyphs): Specify no options.

2012-02-27 Wei James <james.wei@intel.com>

Multi-Channel support in AudioBufferSourceNode
@@ -57,7 +57,7 @@ - (BOOL)_isFakeFixedPitch;
static bool fontHasVerticalGlyphs(CTFontRef ctFont)
{
// The check doesn't look neat but this is what AppKit does for vertical writing...
RetainPtr<CFArrayRef> tableTags(AdoptCF, CTFontCopyAvailableTables(ctFont, kCTFontTableOptionExcludeSynthetic));
RetainPtr<CFArrayRef> tableTags(AdoptCF, CTFontCopyAvailableTables(ctFont, kCTFontTableOptionNoOptions));
CFIndex numTables = CFArrayGetCount(tableTags.get());
for (CFIndex index = 0; index < numTables; ++index) {
CTFontTableTag tag = (CTFontTableTag)(uintptr_t)CFArrayGetValueAtIndex(tableTags.get(), index);
@@ -72,7 +72,6 @@ static bool initFontData(SimpleFontData* fontData)
if (!fontData->platformData().cgFont())
return false;


return true;
}

0 comments on commit 1a5c11c

Please sign in to comment.