Skip to content
Permalink
Browse files
Don't trigger a Windows build when the top-level ChangeLog changes
r79320 is an example of a change that shouldn't have built on Windows, but did, because of
this bug.

Fixes <http://webkit.org/b/54957> Windows bots build when top-level ChangeLog changes, but
shouldn't

Reviewed by Anders Carlsson.

* Scripts/webkitpy/common/config/build.py:
(_should_file_trigger_build): Modified the ChangeLog pattern to match the top-level
ChangeLog, and re-sorted it in the list.

* Scripts/webkitpy/common/config/build_unittest.py:
(ShouldBuildTest): Added a test that ChangeLogs don't trigger builds.

Canonical link: https://commits.webkit.org/69250@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79327 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
aroben committed Feb 22, 2011
1 parent 8d4b97b commit 1a8add64856e57e78e26f9ce543d72cf6d131bb7
Showing with 21 additions and 1 deletion.
  1. +19 −0 Tools/ChangeLog
  2. +1 −1 Tools/Scripts/webkitpy/common/config/build.py
  3. +1 −0 Tools/Scripts/webkitpy/common/config/build_unittest.py
@@ -1,3 +1,22 @@
2011-02-22 Adam Roben <aroben@apple.com>

Don't trigger a Windows build when the top-level ChangeLog changes

r79320 is an example of a change that shouldn't have built on Windows, but did, because of
this bug.

Fixes <http://webkit.org/b/54957> Windows bots build when top-level ChangeLog changes, but
shouldn't

Reviewed by Anders Carlsson.

* Scripts/webkitpy/common/config/build.py:
(_should_file_trigger_build): Modified the ChangeLog pattern to match the top-level
ChangeLog, and re-sorted it in the list.

* Scripts/webkitpy/common/config/build_unittest.py:
(ShouldBuildTest): Added a test that ChangeLogs don't trigger builds.

2011-02-22 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r78691.
@@ -83,10 +83,10 @@ def _should_file_trigger_build(target_platform, file):
]
patterns = [
# Patterns that shouldn't trigger builds on any bots.
(r"(?:^|/)ChangeLog.*$", []),
(r"(?:^|/)Makefile$", []),
(r"/ARM", []),
(r"/CMake.*", []),
(r"/ChangeLog.*$", []),
(r"/LICENSE[^/]+$", []),
(r"ARM(?:v7)?\.(?:cpp|h)$", []),
(r"MIPS\.(?:cpp|h)$", []),
@@ -27,6 +27,7 @@

class ShouldBuildTest(unittest.TestCase):
_should_build_tests = [
(["ChangeLog", "Source/WebCore/ChangeLog", "Source/WebKit2/ChangeLog-2011-02-11"], []),
(["Websites/bugs.webkit.org/foo", "Source/WebCore/bar"], ["*"]),
(["Websites/bugs.webkit.org/foo"], []),
(["Source/JavaScriptCore/JavaScriptCore.xcodeproj/foo"], ["mac-leopard", "mac-snowleopard"]),

0 comments on commit 1a8add6

Please sign in to comment.