Skip to content
Permalink
Browse files
REGRESSION(r238039) WebCore::JSDOMGlobalObject::createStructure is us…
…ing JSC::Structure::create without including StructureInlines.h

https://bugs.webkit.org/show_bug.cgi?id=191626
<rdar://problem/46161064>

Unreviewed adding comment for my change r238366.

* runtime/Structure.h: Added a comment for Structure::create.

Canonical link: https://commits.webkit.org/206568@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238392 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
fujii committed Nov 20, 2018
1 parent 49de687 commit 1acbe9af994c04b57913d17bde12f40f271d8758
Showing with 13 additions and 0 deletions.
  1. +10 −0 Source/JavaScriptCore/ChangeLog
  2. +3 −0 Source/JavaScriptCore/runtime/Structure.h
@@ -1,3 +1,13 @@
2018-11-20 Fujii Hironori <Hironori.Fujii@sony.com>

REGRESSION(r238039) WebCore::JSDOMGlobalObject::createStructure is using JSC::Structure::create without including StructureInlines.h
https://bugs.webkit.org/show_bug.cgi?id=191626
<rdar://problem/46161064>

Unreviewed adding comment for my change r238366.

* runtime/Structure.h: Added a comment for Structure::create.

2018-11-19 Mark Lam <mark.lam@apple.com>

globalFuncImportModule() should return a promise when it clears exceptions.
@@ -828,6 +828,9 @@ class Structure final : public JSCell {
uint32_t m_propertyHash;
};

// We deliberately put Structure::create here in Structure.h instead of StructureInlines.h, because
// it is used everywhere. This is so we don't have to hunt down all the places where we would need
// to #include StructureInlines.h otherwise.
inline Structure* Structure::create(VM& vm, JSGlobalObject* globalObject, JSValue prototype, const TypeInfo& typeInfo, const ClassInfo* classInfo, IndexingType indexingType, unsigned inlineCapacity)
{
ASSERT(vm.structureStructure);

0 comments on commit 1acbe9a

Please sign in to comment.