Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Reviewed by Darin & Eric.
Fixes: http://bugs.webkit.org/show_bug.cgi?id=17258 (SVG uses erroneous cursor implementation) SVG cursors are not well-integrated within the CSS(3) cursor support in WebCore. SVGCursorElement duplicates CSSCursorImageValue functionality and inherits from CachedResourceClient itself, handling remote-image acquisation on its own. RenderStyle's CursorData class holds "IntPoint hotSpot", "CachedImage* image" and just for SVG a 'String cursorFragmentId' (a reference to a SVG <cursor> element, by id). SVG stores a reference to a SVGCursorElement, which holds a CachedImage pointer itself - instead of storing the CachedImage in the CursorData class, as it's supposed to be. Because of that several places in WebCore contain special SVG cursor handling - which is unneeded. Fix all issues by integrating within CSSCursorImageValue, remove 'String cursorFragmentId' from RenderStyle, kill any special SVG cursor handling in WebCore and fix dynamic attribute changes through DOM / SVG DOM (scripting of 'x' / 'y' / 'xlink:href' attribute). Canonical link: https://commits.webkit.org/24016@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30208 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- Loading branch information
Showing
with
243 additions
and 82 deletions.
- +55 −0 WebCore/ChangeLog
- +87 −1 WebCore/css/CSSCursorImageValue.cpp
- +12 −2 WebCore/css/CSSCursorImageValue.h
- +7 −2 WebCore/css/CSSImageValue.cpp
- +5 −2 WebCore/css/CSSImageValue.h
- +0 −5 WebCore/css/CSSParser.cpp
- +4 −9 WebCore/css/CSSStyleSelector.cpp
- +29 −0 WebCore/manual-tests/svg-cursor-changes.svg
- +0 −12 WebCore/page/EventHandler.cpp
- +0 −9 WebCore/rendering/RenderStyle.cpp
- +1 −3 WebCore/rendering/RenderStyle.h
- +30 −17 WebCore/svg/SVGCursorElement.cpp
- +13 −20 WebCore/svg/SVGCursorElement.h
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.