Skip to content
Permalink
Browse files
2011-05-22 Dominic Cooney <dominicc@chromium.org>
        Reviewed by Dimitri Glazkov.

        When removing a shadow root, also remove it from the render tree.
        https://bugs.webkit.org/show_bug.cgi?id=61245

        * platform/mac/Skipped: Unskip shadow tests.
2011-05-22  Dominic Cooney  <dominicc@chromium.org>

        Reviewed by Dimitri Glazkov.

        When removing a shadow root, also remove it from the render tree.
        https://bugs.webkit.org/show_bug.cgi?id=61245

        Test: existing fast/dom/shadow/layout-tests-can-access-shadow.html

        * dom/Element.cpp:
        (WebCore::Element::removeShadowRoot): Call detach if attached.

Canonical link: https://commits.webkit.org/76628@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87029 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
dominiccooney committed May 22, 2011
1 parent a689735 commit 1b9ef368fae02500c16a690b33ae11dc6cbaa5d2
Showing with 27 additions and 3 deletions.
  1. +9 −0 LayoutTests/ChangeLog
  2. +0 −3 LayoutTests/platform/mac/Skipped
  3. +12 −0 Source/WebCore/ChangeLog
  4. +6 −0 Source/WebCore/dom/Element.cpp
@@ -1,3 +1,12 @@
2011-05-22 Dominic Cooney <dominicc@chromium.org>

Reviewed by Dimitri Glazkov.

When removing a shadow root, also remove it from the render tree.
https://bugs.webkit.org/show_bug.cgi?id=61245

* platform/mac/Skipped: Unskip shadow tests.

2011-05-21 Dirk Schulze <krit@webkit.org>

Reviewed by Darin Adler.
@@ -344,9 +344,6 @@ fast/dom/title-directionality.html
# https://bugs.webkit.org/show_bug.cgi?id=58924
plugins/mouse-click-iframe-to-plugin.html

# Unskip when https://bugs.webkit.org/show_bug.cgi?id=59571 is fixed
fast/dom/shadow

# Animation API is disabled by default
animations/animation-api-1.html

@@ -1,3 +1,15 @@
2011-05-22 Dominic Cooney <dominicc@chromium.org>

Reviewed by Dimitri Glazkov.

When removing a shadow root, also remove it from the render tree.
https://bugs.webkit.org/show_bug.cgi?id=61245

Test: existing fast/dom/shadow/layout-tests-can-access-shadow.html

* dom/Element.cpp:
(WebCore::Element::removeShadowRoot): Call detach if attached.

2011-05-22 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.
@@ -1202,7 +1202,13 @@ void Element::removeShadowRoot()
InspectorInstrumentation::willRemoveDOMNode(document(), this);
data->m_shadowRoot = 0;
document()->removeFocusedNodeOfSubtree(oldRoot.get());

// Remove from rendering tree
if (oldRoot->attached())
oldRoot->detach();

oldRoot->setShadowHost(0);

if (oldRoot->inDocument())
oldRoot->removedFromDocument();
else

0 comments on commit 1b9ef36

Please sign in to comment.