Skip to content
Permalink
Browse files
REGRESSION: WebGL doesn't show up in CSS reflections
https://bugs.webkit.org/show_bug.cgi?id=76489

Patch by Antoine Quint <graouts@apple.com> on 2016-06-03
Reviewed by Dean Jackson.

Source/WebCore:

The WebGLLayer needs to notify its owning GraphicsLayer that it was displayed
such that its clones, in GraphicsLayerCA::layerDidDisplay, may have their contents
updated to match that layer's contents. The test at compositing/webgl/webgl-reflection.html
already covers this test and its expectation on Mac has been updated.

* platform/graphics/mac/WebGLLayer.mm:
(-[WebGLLayer display]):

LayoutTests:

Update the expected rendering to contain the reflected WebGL <canvas>.

* platform/mac/compositing/webgl/webgl-reflection-expected.png:

Canonical link: https://commits.webkit.org/176425@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@201639 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
graouts authored and webkit-commit-queue committed Jun 3, 2016
1 parent 27836ad commit 1c823aad565281c2c5e1c6804a10ca8c11c18c81
Showing 4 changed files with 31 additions and 0 deletions.
@@ -1,3 +1,14 @@
2016-06-03 Antoine Quint <graouts@apple.com>

REGRESSION: WebGL doesn't show up in CSS reflections
https://bugs.webkit.org/show_bug.cgi?id=76489

Reviewed by Dean Jackson.

Update the expected rendering to contain the reflected WebGL <canvas>.

* platform/mac/compositing/webgl/webgl-reflection-expected.png:

2016-06-02 Zalan Bujtas <zalan@apple.com>

Repaint issue with vertical text in an out of flow container.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
@@ -1,3 +1,18 @@
2016-06-03 Antoine Quint <graouts@apple.com>

REGRESSION: WebGL doesn't show up in CSS reflections
https://bugs.webkit.org/show_bug.cgi?id=76489

Reviewed by Dean Jackson.

The WebGLLayer needs to notify its owning GraphicsLayer that it was displayed
such that its clones, in GraphicsLayerCA::layerDidDisplay, may have their contents
updated to match that layer's contents. The test at compositing/webgl/webgl-reflection.html
already covers this test and its expectation on Mac has been updated.

* platform/graphics/mac/WebGLLayer.mm:
(-[WebGLLayer display]):

2016-06-02 Gavin Barraclough <barraclough@apple.com>

Refactor showModalDialog handling in JSDOMWindowCustom
@@ -32,6 +32,8 @@
#import "GraphicsContext3D.h"
#import "GraphicsContextCG.h"
#import "GraphicsLayer.h"
#import "GraphicsLayerCA.h"
#import "PlatformCALayer.h"
#import <wtf/FastMalloc.h>
#import <wtf/RetainPtr.h>

@@ -179,6 +181,9 @@ - (void)display
[super display];
#endif
_context->markLayerComposited();
PlatformCALayer* layer = PlatformCALayer::platformCALayer(self);
if (layer && layer->owner())
layer->owner()->platformCALayerLayerDidDisplay(layer);
}

@end

0 comments on commit 1c823aa

Please sign in to comment.