Skip to content
Permalink
Browse files
REGRESSION: 26 InAppBrowserPrivacy API failures on iOS
https://bugs.webkit.org/show_bug.cgi?id=233016
<rdar://problem/85315536>

Reviewed by Brent Fulgham.

In r285594, I have the browser entitlement to TestWebKit API to make my new API test work
on iOS. However, it turns out that 26 InAppBrowserPrivacy API tests rely on the browser
entitlement not being present. I am therefore reverting this part of my change.

* TestWebKitAPI/Configurations/TestWebKitAPI-iOS.entitlements:
* TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:


Canonical link: https://commits.webkit.org/244159@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@285672 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
cdumez committed Nov 11, 2021
1 parent 3ef1874 commit 1d4b65c9d55ab27c4b1fe9cdf00b029b5dc7e650
Showing 3 changed files with 21 additions and 2 deletions.
@@ -1,3 +1,18 @@
2021-11-11 Chris Dumez <cdumez@apple.com>

REGRESSION: 26 InAppBrowserPrivacy API failures on iOS
https://bugs.webkit.org/show_bug.cgi?id=233016
<rdar://problem/85315536>

Reviewed by Brent Fulgham.

In r285594, I have the browser entitlement to TestWebKit API to make my new API test work
on iOS. However, it turns out that 26 InAppBrowserPrivacy API tests rely on the browser
entitlement not being present. I am therefore reverting this part of my change.

* TestWebKitAPI/Configurations/TestWebKitAPI-iOS.entitlements:
* TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:

2021-11-11 Andres Gonzalez <andresg_22@apple.com>

Fix for thread deadlocks during layout tests in isolated tree mode.
@@ -10,7 +10,5 @@
<true/>
<key>com.apple.Pasteboard.paste-unchecked</key>
<true/>
<key>com.apple.developer.web-browser</key>
<true/>
</dict>
</plist>
@@ -7625,6 +7625,10 @@ static void runCOOPProcessSwapTest(const char* sourceCOOP, const char* sourceCOE
runCOOPProcessSwapTest("same-origin-allow-popup", "unsafe-none", "unsafe-none", "unsafe-none", IsSameOrigin::No, DoServerSideRedirect::No, ExpectSwap::No);
}

// On iOS, toggling the captive portal mode requires the browser entitlement, which TestWebKit API doesn't have.
// Also, some API tests rely on the browser entitlement not being present.
#if !PLATFORM(IOS)

static bool isJITEnabled(WKWebView *webView)
{
__block bool gotResponse = false;
@@ -7781,3 +7785,5 @@ static void checkSettingsControlledByCaptivePortalMode(WKWebView *webView, Shoul
checkSettingsControlledByCaptivePortalMode(webView2.get(), ShouldBeEnabled::Yes);
EXPECT_EQ(pid2, [webView2 _webProcessIdentifier]);
}

#endif

0 comments on commit 1d4b65c

Please sign in to comment.