Permalink
Show file tree
Hide file tree
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Rename initial value of color-scheme from
auto
to normal
https://bugs.webkit.org/show_bug.cgi?id=205799 <rdar://58388530> Reviewed by Darin Adler and Timothy Hatcher. * LayoutTests/css-dark-mode/color-scheme-css-parse.html: * LayoutTests/css-dark-mode/color-scheme-css-expected.txt: * LayoutTests/css-dark-mode/color-scheme-css.html: * LayoutTests/css-dark-mode/older-syntax/supported-color-schemes-css-expected.txt: * LayoutTests/css-dark-mode/older-syntax/supported-color-schemes-css.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-color-adjust/inheritance-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-color-adjust/meta/meta-color-scheme-attribute-changes-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-color-adjust/meta/meta-color-scheme-empty-content-value-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-color-adjust/meta/meta-color-scheme-first-valid-applies-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-color-adjust/meta/meta-color-scheme-insert-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-color-adjust/meta/meta-color-scheme-no-content-value-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-color-adjust/meta/meta-color-scheme-remove-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-color-adjust/meta/meta-color-scheme-remove-head-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-color-adjust/meta/meta-color-scheme-single-value-in-body-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-color-adjust/meta/meta-color-scheme-single-value-in-head-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-color-adjust/meta/meta-color-scheme-single-value-in-shadow-tree-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-color-adjust/parsing/color-scheme-computed-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-color-adjust/parsing/color-scheme-invalid-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-color-adjust/parsing/color-scheme-valid-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-meta-element/color-scheme/meta-color-scheme-attribute-changes-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-meta-element/color-scheme/meta-color-scheme-empty-content-value-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-meta-element/color-scheme/meta-color-scheme-insert-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-meta-element/color-scheme/meta-color-scheme-no-content-value-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-meta-element/color-scheme/meta-color-scheme-remove-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-meta-element/color-scheme/meta-color-scheme-remove-head-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-meta-element/color-scheme/meta-color-scheme-single-value-in-body-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-meta-element/color-scheme/meta-color-scheme-single-value-in-head-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-meta-element/color-scheme/meta-color-scheme-single-value-in-shadow-tree-expected.txt: * Source/WebCore/css/CSSComputedStyleDeclaration.cpp: (WebCore::ComputedStyleExtractor::valueForPropertyInStyle): * Source/WebCore/css/CSSProperties.json: * Source/WebCore/css/CSSValueKeywords.in: * Source/WebCore/css/parser/CSSPropertyParser.cpp: (WebCore::consumeColorScheme): * Source/WebCore/rendering/style/StyleColorScheme.h: (WebCore::StyleColorScheme::isNormal const): (WebCore::StyleColorScheme::isAuto const): Deleted. Canonical link: https://commits.webkit.org/253659@main
- Loading branch information
Showing
33 changed files
with
82 additions
and
81 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,9 @@ | ||
|
||
FAIL Meta color-scheme initially 'dark'. assert_equals: expected "dark" but got "auto" | ||
FAIL Removed name attribute from meta color-scheme. assert_equals: expected "normal" but got "auto" | ||
FAIL Set meta name to color-scheme. assert_equals: expected "dark" but got "auto" | ||
FAIL Set content attribute of meta color-scheme to empty string. assert_equals: expected "normal" but got "auto" | ||
FAIL Set content attribute of meta color-scheme to an invalid value. assert_equals: expected "normal" but got "auto" | ||
FAIL Set content attribute of meta color-scheme to 'light'. assert_equals: expected "light" but got "auto" | ||
FAIL Removed the content attribute of meta color-scheme. assert_equals: expected "normal" but got "auto" | ||
FAIL Meta color-scheme initially 'dark'. assert_equals: expected "dark" but got "normal" | ||
PASS Removed name attribute from meta color-scheme. | ||
FAIL Set meta name to color-scheme. assert_equals: expected "dark" but got "normal" | ||
PASS Set content attribute of meta color-scheme to empty string. | ||
PASS Set content attribute of meta color-scheme to an invalid value. | ||
FAIL Set content attribute of meta color-scheme to 'light'. assert_equals: expected "light" but got "normal" | ||
PASS Removed the content attribute of meta color-scheme. | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
|
||
FAIL Meta color-scheme with empty content attribute has no effect. assert_equals: expected "normal" but got "auto" | ||
PASS Meta color-scheme with empty content attribute has no effect. | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
|
||
FAIL Tree order decides which meta color-scheme applies. assert_equals: expected "dark" but got "auto" | ||
FAIL Tree order decides which meta color-scheme applies. assert_equals: expected "dark" but got "normal" | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
|
||
FAIL Initial color-scheme assert_equals: expected "normal" but got "auto" | ||
FAIL Inserted meta color-scheme applies assert_equals: expected "light" but got "auto" | ||
FAIL Inserted meta color-scheme before existing in head applies assert_equals: expected "dark" but got "auto" | ||
PASS Initial color-scheme | ||
FAIL Inserted meta color-scheme applies assert_equals: expected "light" but got "normal" | ||
FAIL Inserted meta color-scheme before existing in head applies assert_equals: expected "dark" but got "normal" | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
|
||
FAIL Meta color-scheme without content attribute has no effect. assert_equals: expected "normal" but got "auto" | ||
PASS Meta color-scheme without content attribute has no effect. | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
|
||
FAIL First meta applies. assert_equals: expected "dark" but got "auto" | ||
FAIL Second meta applies after first one is removed. assert_equals: expected "light" but got "auto" | ||
FAIL Initial color-scheme with both meta elements removed. assert_equals: expected "normal" but got "auto" | ||
FAIL First meta applies. assert_equals: expected "dark" but got "normal" | ||
FAIL Second meta applies after first one is removed. assert_equals: expected "light" but got "normal" | ||
PASS Initial color-scheme with both meta elements removed. | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
|
||
FAIL Meta color-scheme applies. assert_equals: expected "dark" but got "auto" | ||
FAIL Initial value after removing head including meta color-scheme. assert_equals: expected "normal" but got "auto" | ||
FAIL Meta color-scheme applies. assert_equals: expected "dark" but got "normal" | ||
PASS Initial value after removing head including meta color-scheme. | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
|
||
FAIL Meta color-scheme in body does not apply. assert_equals: expected "normal" but got "auto" | ||
PASS Meta color-scheme in body does not apply. | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
|
||
FAIL Meta color-scheme in head applies. assert_equals: expected "dark" but got "auto" | ||
FAIL Meta color-scheme in head applies. assert_equals: expected "dark" but got "normal" | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
|
||
FAIL Meta color-scheme in shadow tree does not apply. assert_equals: expected "normal" but got "auto" | ||
PASS Meta color-scheme in shadow tree does not apply. | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,15 +1,15 @@ | ||
|
||
FAIL Property color-scheme value 'normal' assert_equals: expected "normal" but got "auto" | ||
PASS Property color-scheme value 'normal' | ||
PASS Property color-scheme value 'light dark' | ||
FAIL Property color-scheme value 'dark light' assert_equals: expected "dark light" but got "light dark" | ||
FAIL Property color-scheme value 'light unknown' assert_equals: expected "light unknown" but got "light" | ||
PASS Property color-scheme value 'only light' | ||
PASS Property color-scheme value 'only light dark' | ||
FAIL Property color-scheme value 'light light' assert_true: 'light light' is a supported value for color-scheme. expected true got false | ||
PASS Property color-scheme value 'light only' | ||
FAIL Property color-scheme value 'none' assert_equals: expected "none" but got "auto" | ||
FAIL Property color-scheme value 'initial' assert_equals: expected "normal" but got "auto" | ||
FAIL Property color-scheme value 'inherit' assert_equals: expected "normal" but got "auto" | ||
FAIL Property color-scheme value 'unset' assert_equals: expected "normal" but got "auto" | ||
FAIL Property color-scheme value 'revert' assert_equals: expected "normal" but got "auto" | ||
FAIL Property color-scheme value 'none' assert_equals: expected "none" but got "normal" | ||
PASS Property color-scheme value 'initial' | ||
PASS Property color-scheme value 'inherit' | ||
PASS Property color-scheme value 'unset' | ||
PASS Property color-scheme value 'revert' | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,10 @@ | ||
|
||
FAIL Meta color-scheme initially 'dark'. assert_equals: Root element's color-scheme should be 'normal' expected "normal" but got "auto" | ||
PASS Meta color-scheme initially 'dark'. | ||
FAIL Removed name attribute from meta color-scheme. assert_equals: expected "light" but got "dark" | ||
FAIL Set meta name to color-scheme. assert_equals: Root element's color-scheme should be 'normal' expected "normal" but got "auto" | ||
FAIL Set content attribute of meta color-scheme to empty string. assert_equals: Root element's color-scheme should be 'normal' expected "normal" but got "auto" | ||
FAIL Set content attribute of meta color-scheme to an invalid value. assert_equals: Root element's color-scheme should be 'normal' expected "normal" but got "auto" | ||
FAIL Set content attribute of meta color-scheme to 'light'. assert_equals: Root element's color-scheme should be 'normal' expected "normal" but got "auto" | ||
FAIL Set content attribute of meta color-scheme to 'dark'. assert_equals: Root element's color-scheme should be 'normal' expected "normal" but got "auto" | ||
PASS Set meta name to color-scheme. | ||
PASS Set content attribute of meta color-scheme to empty string. | ||
PASS Set content attribute of meta color-scheme to an invalid value. | ||
PASS Set content attribute of meta color-scheme to 'light'. | ||
PASS Set content attribute of meta color-scheme to 'dark'. | ||
FAIL Removed the content attribute of meta color-scheme. assert_equals: expected "light" but got "dark" | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
|
||
FAIL Meta color-scheme with empty content attribute has no effect. assert_equals: Root element's color-scheme should be 'normal' expected "normal" but got "auto" | ||
PASS Meta color-scheme with empty content attribute has no effect. | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
|
||
FAIL Initial color-scheme assert_equals: Root element's color-scheme should be 'normal' expected "normal" but got "auto" | ||
FAIL Inserted meta color-scheme applies assert_equals: Root element's color-scheme should be 'normal' expected "normal" but got "auto" | ||
FAIL Inserted meta color-scheme before existing in head applies assert_equals: Root element's color-scheme should be 'normal' expected "normal" but got "auto" | ||
PASS Initial color-scheme | ||
PASS Inserted meta color-scheme applies | ||
PASS Inserted meta color-scheme before existing in head applies | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
|
||
FAIL Meta color-scheme without content attribute has no effect. assert_equals: Root element's color-scheme should be 'normal' expected "normal" but got "auto" | ||
PASS Meta color-scheme without content attribute has no effect. | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
|
||
FAIL First meta applies. assert_equals: expected "dark" but got "light" | ||
FAIL Second meta applies after first one is removed. assert_equals: Root element's color-scheme should be 'normal' expected "normal" but got "auto" | ||
FAIL Initial color-scheme with both meta elements removed. assert_equals: Root element's color-scheme should be 'normal' expected "normal" but got "auto" | ||
PASS Second meta applies after first one is removed. | ||
PASS Initial color-scheme with both meta elements removed. | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
|
||
FAIL Meta color-scheme applies. assert_equals: Root element's color-scheme should be 'normal' expected "normal" but got "auto" | ||
PASS Meta color-scheme applies. | ||
FAIL Initial value after removing head including meta color-scheme. assert_equals: expected "light" but got "dark" | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
|
||
FAIL Meta color-scheme in body should apply. assert_equals: Root element's color-scheme should be 'normal' expected "normal" but got "auto" | ||
PASS Meta color-scheme in body should apply. | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
|
||
FAIL Meta color-scheme in head applies. assert_equals: Root element's color-scheme should be 'normal' expected "normal" but got "auto" | ||
PASS Meta color-scheme in head applies. | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
|
||
FAIL Meta color-scheme in shadow tree does not apply. assert_equals: Root element's color-scheme should be 'normal' expected "normal" but got "auto" | ||
PASS Meta color-scheme in shadow tree does not apply. | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -6631,7 +6631,7 @@ | ||
"color-scheme": { | ||
"inherited": true, | ||
"values": [ | ||
"auto", | ||
"normal", | ||
"light", | ||
"dark", | ||
"only" | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1514,6 +1514,7 @@ dark | ||
|
||
#if defined(ENABLE_DARK_MODE_CSS) && ENABLE_DARK_MODE_CSS | ||
// color-scheme | ||
// normal | ||
only | ||
// light | ||
// dark | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters