Skip to content
Permalink
Browse files
REGRESSION (r232544): Pages are blank after homing out and then resum…
…ing on iPad

https://bugs.webkit.org/show_bug.cgi?id=186408
<rdar://problem/40907111>

Reviewed by Wenson Hsieh.

* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _resizeWhileHidingContentWithUpdates:]):
Clients who use _resizeWhileHidingContentWithUpdates don't call
_endAnimatedResize; the former API is a one-shot. We can't wait for
_endAnimatedResize to complete the animation (and don't need to, since
the content is hidden), but instead should just finish it when the
commit with the resized tiles arrives.


Canonical link: https://commits.webkit.org/201772@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@232601 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
hortont424 committed Jun 7, 2018
1 parent 4e07b45 commit 1ee6c7404a05d664ccc0075a980a5f8ba475a627
Showing with 20 additions and 0 deletions.
  1. +16 −0 Source/WebKit/ChangeLog
  2. +4 −0 Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
@@ -1,3 +1,19 @@
2018-06-07 Tim Horton <timothy_horton@apple.com>

REGRESSION (r232544): Pages are blank after homing out and then resuming on iPad
https://bugs.webkit.org/show_bug.cgi?id=186408
<rdar://problem/40907111>

Reviewed by Wenson Hsieh.

* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _resizeWhileHidingContentWithUpdates:]):
Clients who use _resizeWhileHidingContentWithUpdates don't call
_endAnimatedResize; the former API is a one-shot. We can't wait for
_endAnimatedResize to complete the animation (and don't need to, since
the content is hidden), but instead should just finish it when the
commit with the resized tiles arrives.

2018-06-07 Jiewen Tan <jiewen_tan@apple.com>

Use the same overloaded addInputString in WKContentViewInteraction
@@ -5375,6 +5375,10 @@ - (void)_resizeWhileHidingContentWithUpdates:(void (^)(void))updateBlock
if (_dynamicViewportUpdateMode == WebKit::DynamicViewportUpdateMode::ResizingWithAnimation) {
[_contentView setHidden:YES];
_dynamicViewportUpdateMode = WebKit::DynamicViewportUpdateMode::ResizingWithDocumentHidden;

// _resizeWhileHidingContentWithUpdates is used by itself; the client will
// not call endAnimatedResize, so we can't wait for it.
_waitingForEndAnimatedResize = NO;
}
}

0 comments on commit 1ee6c74

Please sign in to comment.