From 1f0330ec877a3a8f5104d5b14c5c1ead9d3f8a32 Mon Sep 17 00:00:00 2001 From: Commit Queue Date: Mon, 18 Apr 2022 18:46:45 +0000 Subject: [PATCH] [PGO] Fix build on intel machines https://bugs.webkit.org/show_bug.cgi?id=239396 Reviewed by Jonathan Bedard. We should use the correct comparison operator for Perl strings when checking if we are building with PGO profile generation enabled. Canonical link: https://commits.webkit.org/249727@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@292962 268f45cc-cd09-0410-ab3c-d52691b4dbfc --- ChangeLog | 10 ++++++++++ Tools/ChangeLog | 12 ++++++++++++ Tools/Scripts/check-for-weak-vtables-and-externals | 2 +- 3 files changed, 23 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index e349ef488e86..960f00f520b2 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,13 @@ +2022-04-15 Justin Michaud + + [PGO] Fix build on intel machines + https://bugs.webkit.org/show_bug.cgi?id=239396 + + Reviewed by Jonathan Bedard. + + We should use the correct comparison operator for Perl strings when checking + if we are building with PGO profile generation enabled. + 2022-04-12 Jonathan Bedard [git-webkit] Allow projects to declare alternate remotes diff --git a/Tools/ChangeLog b/Tools/ChangeLog index 619eed475783..9d2cb5704bb5 100644 --- a/Tools/ChangeLog +++ b/Tools/ChangeLog @@ -1,3 +1,15 @@ +2022-04-15 Justin Michaud + + [PGO] Fix build on intel machines + https://bugs.webkit.org/show_bug.cgi?id=239396 + + Reviewed by Jonathan Bedard. + + We should use the correct comparison operator for Perl strings when checking + if we are building with PGO profile generation enabled. + + * Scripts/check-for-weak-vtables-and-externals: + 2022-04-18 Elliott Williams [XCBuild] Use XCBuild for all command-line and project builds diff --git a/Tools/Scripts/check-for-weak-vtables-and-externals b/Tools/Scripts/check-for-weak-vtables-and-externals index 259b97c34604..25c59941a593 100755 --- a/Tools/Scripts/check-for-weak-vtables-and-externals +++ b/Tools/Scripts/check-for-weak-vtables-and-externals @@ -60,7 +60,7 @@ if (!defined $executablePathAge || !defined $buildTimestampAge || $executablePat } my @weakVTableClasses = (); my @weakExternalSymbols = (); - my $skipProfileSymbols = coverageIsEnabled() || $ENV{'ENABLE_LLVM_PROFILE_GENERATION'} == "ON" || $ENV{'ENABLE_LLVM_PROFILE_GENERATION'} == "ENABLE_LLVM_PROFILE_GENERATION"; + my $skipProfileSymbols = coverageIsEnabled() || $ENV{'ENABLE_LLVM_PROFILE_GENERATION'} eq "ON" || $ENV{'ENABLE_LLVM_PROFILE_GENERATION'} eq "ENABLE_LLVM_PROFILE_GENERATION"; while () { if (/^STDOUT:/) { # Ignore undefined, RTTI and typeinfo symbols.