Skip to content
Permalink
Browse files
Remove WTF::String::operator+=
https://bugs.webkit.org/show_bug.cgi?id=95797

Patch by Adam Barth <abarth@chromium.org> on 2012-09-06
Reviewed by Sam Weinig.

This patch encloses WTF::String::operator+= in an ifdef so that we can
gradually remove it from the various port-specific files. The ifdef
lets us whitelist use of operator+= in individual files during the
transition.

* wtf/Platform.h
* wtf/text/WTFString.h:


Canonical link: https://commits.webkit.org/113804@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127702 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
Adam Barth committed Sep 6, 2012
1 parent 08c219b commit 1f3c8fd27d7faef25cc1dde4009046eeeb6bda06
Showing 3 changed files with 21 additions and 0 deletions.
@@ -1,3 +1,18 @@
2012-09-06 Adam Barth <abarth@chromium.org>

Remove WTF::String::operator+=
https://bugs.webkit.org/show_bug.cgi?id=95797

Reviewed by Sam Weinig.

This patch encloses WTF::String::operator+= in an ifdef so that we can
gradually remove it from the various port-specific files. The ifdef
lets us whitelist use of operator+= in individual files during the
transition.

* wtf/Platform.h
* wtf/text/WTFString.h:

2012-09-05 Gabor Rapcsanyi <rgabor@webkit.org>

DFG JIT doesn't work properly on ARM hardfp
@@ -1185,6 +1185,10 @@
#define WTF_USE_ZLIB 1
#endif

#if PLATFORM(QT) || PLATFORM(GTK) || PLATFORM(WIN)
#define WTF_DEPRECATED_STRING_OPERATORS
#endif

#if PLATFORM(QT)
#include <qglobal.h>
#if defined(QT_OPENGL_ES_2) && !defined(WTF_USE_OPENGL_ES_2)
@@ -466,7 +466,9 @@ QDataStream& operator<<(QDataStream& stream, const String& str);
QDataStream& operator>>(QDataStream& stream, String& str);
#endif

#ifdef WTF_DEPRECATED_STRING_OPERATORS
inline String& operator+=(String& a, const String& b) { a.append(b); return a; }
#endif

inline bool operator==(const String& a, const String& b) { return equal(a.impl(), b.impl()); }
inline bool operator==(const String& a, const LChar* b) { return equal(a.impl(), b); }

0 comments on commit 1f3c8fd

Please sign in to comment.