Permalink
Show file tree
Hide file tree
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Source/WebCore:
Changed playbackRate and defaultPlaybackRate from unrestricted double to double. https://bugs.webkit.org/show_bug.cgi?id=235174 rdar://problem/87815745 Patch by Takeshi Sone <takeshi.sone@gmail.com> on 2022-01-31 Reviewed by Eric Carlson. Test: media/video-playbackrate-undefined.html * html/HTMLMediaElement.idl: LayoutTests: Added a test to verify that setting undefined to video.playbackRate raises an exception. https://bugs.webkit.org/show_bug.cgi?id=235174 rdar://problem/87815745 Patch by Takeshi Sone <takeshi.sone@gmail.com> on 2022-01-31 Reviewed by Eric Carlson. * media/video-playbackrate-undefined-expected.txt: Added. * media/video-playbackrate-undefined.html: Added. Canonical link: https://commits.webkit.org/246597@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@288827 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- Loading branch information
1 parent
c5f7467
commit 1f9b42f7b4bfe9b7166ff2da0f5b1ef75f5a1f7c
Showing
5 changed files
with
53 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
|
||
TEST(video.playbackRate = undefined) THROWS('TypeError: The provided value is non-finite') OK | ||
TEST(video.defaultPlaybackRate = undefined) THROWS('TypeError: The provided value is non-finite') OK | ||
END OF TEST | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
<!DOCTYPE html> | ||
<html> | ||
<head> | ||
<title>Setting undefined to playbackRate and defaultPlaybackRate</title> | ||
</head> | ||
<body> | ||
<video></video> | ||
<script src="video-test.js"></script> | ||
<script> | ||
testException( | ||
"video.playbackRate = undefined", | ||
"'TypeError: The provided value is non-finite'" | ||
); | ||
testException( | ||
"video.defaultPlaybackRate = undefined", | ||
"'TypeError: The provided value is non-finite'" | ||
); | ||
endTest(); | ||
</script> | ||
</body> | ||
</html> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters