Test gardening for GTK.

https://bugs.webkit.org/show_bug.cgi?id=181477

Unreviewed test gardening.


Tools:

* TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp: Correct the file name.
* TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp: Adjust the expected console message.

LayoutTests:

* http/tests/performance/performance-resource-timing-cached-entries-expected.txt:
* http/tests/performance/performance-resource-timing-cached-entries.html:
  The code to debug this test's flakiness made it more flaky, as the
  resources are not logged in a consistent order. This ensures they are
  logged only in case of failure.
* platform/gtk/TestExpectations:
  - svg/custom/non-scaling-stroke.svg was fixed in r226443.
  - imported/w3c/web-platform-tests/css/css-shapes-1/shape-outside/values/shape-margin-001.html
    was fixed in r226404.


Canonical link: https://commits.webkit.org/197397@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@226782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog

@@ -1,3 +1,20 @@
+2018-01-11  Ms2ger  <Ms2ger@igalia.com>
+
+        Test gardening for GTK.
+        https://bugs.webkit.org/show_bug.cgi?id=181477
+
+        Unreviewed test gardening.
+
+        * http/tests/performance/performance-resource-timing-cached-entries-expected.txt:
+        * http/tests/performance/performance-resource-timing-cached-entries.html:
+          The code to debug this test's flakiness made it more flaky, as the
+          resources are not logged in a consistent order. This ensures they are
+          logged only in case of failure.
+        * platform/gtk/TestExpectations:
+          - svg/custom/non-scaling-stroke.svg was fixed in r226443.
+          - imported/w3c/web-platform-tests/css/css-shapes-1/shape-outside/values/shape-margin-001.html
+            was fixed in r226404.
+
 2018-01-11  Miguel Gomez  <magomez@igalia.com>
 
         Unreviewed GTK+ and WPE gardening after r226773.

LayoutTests/http/tests/performance/performance-resource-timing-cached-entries-expected.txt

@@ -1,6 +1,3 @@
 CONSOLE MESSAGE: line 9: current entries: 0
-CONSOLE MESSAGE: line 18: entry: http://127.0.0.1:8000/resources/js-test-pre.js
-CONSOLE MESSAGE: line 18: entry: http://127.0.0.1:8000/resources/square100.png
-CONSOLE MESSAGE: line 18: entry: http://127.0.0.1:8000/resources/square100.png
-PASS foundResource is 2
+PASS foundResources.length is 2
 

LayoutTests/http/tests/performance/performance-resource-timing-cached-entries.html

@@ -11,15 +11,17 @@
 <script src="../../resources/js-test-pre.js"></script>
 <img src="../../resources/square100.png">
 <script>
-    var foundResource = 0;
+    var foundResources = [];
     var runTest = function() {
         var resources = performance.getEntriesByType('resource');
         for (var i = 0; i < resources.length; ++i) {
-            console.log("entry: " + resources[i].name);
             if (resources[i].name.indexOf("square") != -1)
-                ++foundResource;
+                foundResources.push(resources[i].name);
         };
-        shouldBe("foundResource", "2");
+        shouldBe("foundResources.length", "2");
+        if (foundResources.length !== 2) {
+            console.log(foundResources);
+        }
         if (window.testRunner)
             testRunner.notifyDone();
     };

LayoutTests/platform/gtk/TestExpectations

@@ -2587,8 +2587,6 @@ webkit.org/b/74282 editing/pasteboard/emacs-ctrl-k-with-move.html [ Failure ]
 
 webkit.org/b/81320 editing/pasteboard/copy-two-pasteboard-types-both-work.html [ Failure ]
 
-webkit.org/b/86971 svg/custom/non-scaling-stroke.svg [ Failure ]
-
 webkit.org/b/84679 css3/zoom-coords.xhtml [ Failure ]
 
 webkit.org/b/84694 fast/events/selectstart-by-double-triple-clicks.html [ Failure ]
@@ -2688,7 +2686,6 @@ webkit.org/b/180581 css3/shapes/shape-outside/values/shape-outside-ellipse-005.h
 webkit.org/b/180581 css3/shapes/shape-outside/values/shape-outside-inset-003.html [ Failure ]
 webkit.org/b/180581 css3/shapes/shape-outside/values/shape-outside-polygon-004.html [ Failure ]
 webkit.org/b/180581 css3/shapes/shape-outside/values/shape-outside-shape-arguments-000.html [ Failure ]
-webkit.org/b/180581 imported/w3c/web-platform-tests/css/css-shapes-1/shape-outside/values/shape-margin-001.html [ Failure ]
 webkit.org/b/180581 imported/w3c/web-platform-tests/css/css-shapes-1/shape-outside/values/shape-outside-circle-004.html [ Failure ]
 webkit.org/b/180581 imported/w3c/web-platform-tests/css/css-shapes-1/shape-outside/values/shape-outside-circle-005.html [ Failure ]
 webkit.org/b/180581 imported/w3c/web-platform-tests/css/css-shapes-1/shape-outside/values/shape-outside-ellipse-004.html [ Failure ]

Tools/ChangeLog

@@ -1,3 +1,13 @@
+2018-01-11  Ms2ger  <Ms2ger@igalia.com>
+
+        Test gardening for GTK.
+        https://bugs.webkit.org/show_bug.cgi?id=181477
+
+        Unreviewed test gardening.
+
+        * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp: Correct the file name.
+        * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp: Adjust the expected console message.
+
 2018-01-11  Carlos Alberto Lopez Perez  <clopez@igalia.com>
 
         Add the new JSCOnly bot to the scheduler.

Tools/TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp

@@ -410,16 +410,16 @@ void beforeAll()
     kServer = new WebKitTestServer();
     kServer->run(serverCallback);
 
-    AuthenticationTest::add("WebKitWebView", "authentication-request", testWebViewAuthenticationRequest);
-    AuthenticationTest::add("WebKitWebView", "authentication-cancel", testWebViewAuthenticationCancel);
-    AuthenticationTest::add("WebKitWebView", "authentication-load-cancelled", testWebViewAuthenticationLoadCancelled);
-    AuthenticationTest::add("WebKitWebView", "authentication-success", testWebViewAuthenticationSuccess);
-    AuthenticationTest::add("WebKitWebView", "authentication-failure", testWebViewAuthenticationFailure);
-    AuthenticationTest::add("WebKitWebView", "authentication-no-credential", testWebViewAuthenticationNoCredential);
-    AuthenticationTest::add("WebKitWebView", "authentication-storage", testWebViewAuthenticationStorage);
-    AuthenticationTest::add("WebKitWebView", "authentication-empty-realm", testWebViewAuthenticationEmptyRealm);
-    ProxyAuthenticationTest::add("WebKitWebView", "authentication-proxy", testWebViewAuthenticationProxy);
-    ProxyAuthenticationTest::add("WebKitWebView", "authentication-proxy-https", testWebViewAuthenticationProxyHTTPS);
+    AuthenticationTest::add("Authentication", "authentication-request", testWebViewAuthenticationRequest);
+    AuthenticationTest::add("Authentication", "authentication-cancel", testWebViewAuthenticationCancel);
+    AuthenticationTest::add("Authentication", "authentication-load-cancelled", testWebViewAuthenticationLoadCancelled);
+    AuthenticationTest::add("Authentication", "authentication-success", testWebViewAuthenticationSuccess);
+    AuthenticationTest::add("Authentication", "authentication-failure", testWebViewAuthenticationFailure);
+    AuthenticationTest::add("Authentication", "authentication-no-credential", testWebViewAuthenticationNoCredential);
+    AuthenticationTest::add("Authentication", "authentication-storage", testWebViewAuthenticationStorage);
+    AuthenticationTest::add("Authentication", "authentication-empty-realm", testWebViewAuthenticationEmptyRealm);
+    ProxyAuthenticationTest::add("Authentication", "authentication-proxy", testWebViewAuthenticationProxy);
+    ProxyAuthenticationTest::add("Authentication", "authentication-proxy-https", testWebViewAuthenticationProxyHTTPS);
 }
 
 void afterAll()

Tools/TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp

@@ -125,7 +125,7 @@ static void testWebKitConsoleMessageJavaScriptException(ConsoleMessageTest* test
 static void testWebKitConsoleMessageNetworkError(ConsoleMessageTest* test, gconstpointer)
 {
     ConsoleMessageTest::ConsoleMessage referenceMessage = { ConsoleMessageTest::MessageSource::Network, ConsoleMessageTest::MessageLevel::Error,
-        "Failed to load resource: The resource at “/org/webkit/glib/tests/not-found.css” does not exist", 0, "resource:///org/webkit/glib/tests/not-found.css" };
+        "Failed to load resource: The resource at '/org/webkit/glib/tests/not-found.css' does not exist", 0, "resource:///org/webkit/glib/tests/not-found.css" };
     test->loadHtml("<html><head><link rel='stylesheet' href='not-found.css' type='text/css'></head><body></body></html>", "resource:///org/webkit/glib/tests/");
     test->waitUntilConsoleMessageReceived();
     g_assert(test->m_consoleMessage == referenceMessage);