Skip to content
Permalink
Browse files
AX: "video element controller" is an overly verbose default descripti…
…on for the playback controls; how about just "playback"

https://bugs.webkit.org/show_bug.cgi?id=113549

Patch by James Craig <james@cookiecrook.com> on 2013-04-01
Reviewed by Chris Fleizach.

Source/WebCore:

Existing test coverage.

Updating the video/audio element's default accessibility labels to be less verbose.
Also cleaned up some erroneous comments related to the sub-level controls on these elements.

* English.lproj/Localizable.strings:
* platform/LocalizedStrings.cpp:
(WebCore::localizedMediaControlElementString):
(WebCore::localizedMediaControlElementHelpText):
* platform/gtk/LocalizedStringsGtk.cpp:
(WebCore::localizedMediaControlElementString):

Source/WebCore/platform/gtk/po:

Existing test coverage.

Updating the video/audio element's default accessibility labels to be less verbose.

* en_CA.po:
* en_GB.po:

LayoutTests:

Updating the video/audio element's default accessibility labels to be less verbose.

* platform/gtk/accessibility/media-controls-panel-title-expected.txt:
* platform/gtk/accessibility/media-controls-panel-title.html:
* platform/gtk/accessibility/media-element-expected.txt:
* platform/mac/accessibility/media-element-expected.txt:

Canonical link: https://commits.webkit.org/132030@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147343 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
cookiecrook authored and webkit-commit-queue committed Apr 1, 2013
1 parent 8b11bef commit 21819d85932b861ba452d616928caa7e5ebdc3b1
Showing 12 changed files with 83 additions and 36 deletions.
@@ -1,3 +1,17 @@
2013-04-01 James Craig <james@cookiecrook.com>

AX: "video element controller" is an overly verbose default description for the playback controls; how about just "playback"
https://bugs.webkit.org/show_bug.cgi?id=113549

Reviewed by Chris Fleizach.

Updating the video/audio element's default accessibility labels to be less verbose.

* platform/gtk/accessibility/media-controls-panel-title-expected.txt:
* platform/gtk/accessibility/media-controls-panel-title.html:
* platform/gtk/accessibility/media-element-expected.txt:
* platform/mac/accessibility/media-element-expected.txt:

2013-04-01 Victor Carbune <vcarbune@chromium.org>

Parsing WebVTT Region Header Metadata
@@ -6,7 +6,7 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE
PASS element.role is 'AXRole: AXGroup'
PASS element.title is 'AXTitle: '
PASS element.role is 'AXRole: AXToolbar'
PASS element.title is 'AXTitle: video element controller'
PASS element.title is 'AXTitle: video playback'
PASS successfullyParsed is true

TEST COMPLETE
@@ -17,7 +17,7 @@
shouldBe("element.title", "'AXTitle: '");
element = element.childAtIndex(0);
shouldBe("element.role", "'AXRole: AXToolbar'");
shouldBe("element.title", "'AXTitle: video element controller'");
shouldBe("element.title", "'AXTitle: video playback'");
}

</script>
@@ -4,11 +4,11 @@ Dump <video> element controller accessibility object tree at 'canplaythrough' ev

State at 'canplaythrough' event:

description: AXDescription: video element controller
description: AXDescription: video playback
role: AXRole: AXToolbar


description: AXDescription: video element controller
description: AXDescription: video playback
role: AXRole: AXToolbar


@@ -4,7 +4,7 @@ Dump <video> element controller accessibility object tree at 'canplaythrough' ev

State at 'canplaythrough' event:

description: AXDescription: video element controller
description: AXDescription: video playback
role: AXRole: AXToolbar


@@ -1,3 +1,22 @@
2013-04-01 James Craig <james@cookiecrook.com>

AX: "video element controller" is an overly verbose default description for the playback controls; how about just "playback"
https://bugs.webkit.org/show_bug.cgi?id=113549

Reviewed by Chris Fleizach.

Existing test coverage.

Updating the video/audio element's default accessibility labels to be less verbose.
Also cleaned up some erroneous comments related to the sub-level controls on these elements.

* English.lproj/Localizable.strings:
* platform/LocalizedStrings.cpp:
(WebCore::localizedMediaControlElementString):
(WebCore::localizedMediaControlElementHelpText):
* platform/gtk/LocalizedStringsGtk.cpp:
(WebCore::localizedMediaControlElementString):

2013-04-01 Nate Chapin <japhet@chromium.org>

Make a bunch of DocumentLoader functions private
Binary file not shown.
@@ -815,43 +815,43 @@ String mediaElementLiveBroadcastStateText()
String localizedMediaControlElementString(const String& name)
{
if (name == "AudioElement")
return WEB_UI_STRING("audio element controller", "accessibility role description for audio element controller");
return WEB_UI_STRING("audio playback", "accessibility label for audio element controller");
if (name == "VideoElement")
return WEB_UI_STRING("video element controller", "accessibility role description for video element controller");
return WEB_UI_STRING("video playback", "accessibility label for video element controller");
if (name == "MuteButton")
return WEB_UI_STRING("mute", "accessibility role description for mute button");
return WEB_UI_STRING("mute", "accessibility label for mute button");
if (name == "UnMuteButton")
return WEB_UI_STRING("unmute", "accessibility role description for turn mute off button");
return WEB_UI_STRING("unmute", "accessibility label for turn mute off button");
if (name == "PlayButton")
return WEB_UI_STRING("play", "accessibility role description for play button");
return WEB_UI_STRING("play", "accessibility label for play button");
if (name == "PauseButton")
return WEB_UI_STRING("pause", "accessibility role description for pause button");
return WEB_UI_STRING("pause", "accessibility label for pause button");
if (name == "Slider")
return WEB_UI_STRING("movie time", "accessibility role description for timeline slider");
return WEB_UI_STRING("movie time", "accessibility label for timeline slider");
if (name == "SliderThumb")
return WEB_UI_STRING("timeline slider thumb", "accessibility role description for timeline thumb");
return WEB_UI_STRING("timeline slider thumb", "accessibility label for timeline thumb");
if (name == "RewindButton")
return WEB_UI_STRING("back 30 seconds", "accessibility role description for seek back 30 seconds button");
return WEB_UI_STRING("back 30 seconds", "accessibility label for seek back 30 seconds button");
if (name == "ReturnToRealtimeButton")
return WEB_UI_STRING("return to realtime", "accessibility role description for return to real time button");
return WEB_UI_STRING("return to realtime", "accessibility label for return to real time button");
if (name == "CurrentTimeDisplay")
return WEB_UI_STRING("elapsed time", "accessibility role description for elapsed time display");
return WEB_UI_STRING("elapsed time", "accessibility label for elapsed time display");
if (name == "TimeRemainingDisplay")
return WEB_UI_STRING("remaining time", "accessibility role description for time remaining display");
return WEB_UI_STRING("remaining time", "accessibility label for time remaining display");
if (name == "StatusDisplay")
return WEB_UI_STRING("status", "accessibility role description for movie status");
return WEB_UI_STRING("status", "accessibility label for movie status");
if (name == "EnterFullscreenButton")
return WEB_UI_STRING("enter fullscreen", "accessibility role description for enter fullscreen button");
return WEB_UI_STRING("enter fullscreen", "accessibility label for enter fullscreen button");
if (name == "ExitFullscreenButton")
return WEB_UI_STRING("exit fullscreen", "accessibility role description for exit fullscreen button");
return WEB_UI_STRING("exit fullscreen", "accessibility label for exit fullscreen button");
if (name == "SeekForwardButton")
return WEB_UI_STRING("fast forward", "accessibility role description for fast forward button");
return WEB_UI_STRING("fast forward", "accessibility label for fast forward button");
if (name == "SeekBackButton")
return WEB_UI_STRING("fast reverse", "accessibility role description for fast reverse button");
return WEB_UI_STRING("fast reverse", "accessibility label for fast reverse button");
if (name == "ShowClosedCaptionsButton")
return WEB_UI_STRING("show closed captions", "accessibility role description for show closed captions button");
return WEB_UI_STRING("show closed captions", "accessibility label for show closed captions button");
if (name == "HideClosedCaptionsButton")
return WEB_UI_STRING("hide closed captions", "accessibility role description for hide closed captions button");
return WEB_UI_STRING("hide closed captions", "accessibility label for hide closed captions button");

// FIXME: the ControlsPanel container should never be visible in the accessibility hierarchy.
if (name == "ControlsPanel")
@@ -864,9 +864,9 @@ String localizedMediaControlElementString(const String& name)
String localizedMediaControlElementHelpText(const String& name)
{
if (name == "AudioElement")
return WEB_UI_STRING("audio element playback controls and status display", "accessibility role description for audio element controller");
return WEB_UI_STRING("audio element playback controls and status display", "accessibility help text for audio element controller");
if (name == "VideoElement")
return WEB_UI_STRING("video element playback controls and status display", "accessibility role description for video element controller");
return WEB_UI_STRING("video element playback controls and status display", "accessibility help text for video element controller");
if (name == "MuteButton")
return WEB_UI_STRING("mute audio tracks", "accessibility help text for mute button");
if (name == "UnMuteButton")
@@ -532,9 +532,9 @@ String mediaElementLiveBroadcastStateText()
String localizedMediaControlElementString(const String& name)
{
if (name == "AudioElement")
return String::fromUTF8(_("audio element controller"));
return String::fromUTF8(_("audio playback"));
if (name == "VideoElement")
return String::fromUTF8(_("video element controller"));
return String::fromUTF8(_("video playback"));
if (name == "MuteButton")
return String::fromUTF8(_("mute"));
if (name == "UnMuteButton")
@@ -1,3 +1,17 @@
2013-04-01 James Craig <james@cookiecrook.com>

AX: "video element controller" is an overly verbose default description for the playback controls; how about just "playback"
https://bugs.webkit.org/show_bug.cgi?id=113549

Reviewed by Chris Fleizach.

Existing test coverage.

Updating the video/audio element's default accessibility labels to be less verbose.

* en_CA.po:
* en_GB.po:

2013-03-27 Shantha kumar <shkumar@redhat.com>

Tamil translation for Gnome 3.6
@@ -375,12 +375,12 @@ msgid "Live Broadcast"
msgstr "Live Broadcast"

#: LocalizedStringsGtk.cpp:535
msgid "audio element controller"
msgstr "audio element controller"
msgid "audio playback"
msgstr "audio playback"

#: LocalizedStringsGtk.cpp:537
msgid "video element controller"
msgstr "video element controller"
msgid "video playback"
msgstr "video playback"

#: LocalizedStringsGtk.cpp:539
msgid "mute"
@@ -377,12 +377,12 @@ msgid "Live Broadcast"
msgstr "Live Broadcast"

#: LocalizedStringsGtk.cpp:535
msgid "audio element controller"
msgstr "audio element controller"
msgid "audio playback"
msgstr "audio playback"

#: LocalizedStringsGtk.cpp:537
msgid "video element controller"
msgstr "video element controller"
msgid "video playback"
msgstr "video playback"

#: LocalizedStringsGtk.cpp:539
msgid "mute"

0 comments on commit 21819d8

Please sign in to comment.