Skip to content

Commit

Permalink
QueueStatusServer should have an explicit timeout for _fetch_url
Browse files Browse the repository at this point in the history
https://bugs.webkit.org/show_bug.cgi?id=167467

Reviewed by Alexey Proskuryakov.

* Scripts/webkitpy/common/net/statusserver.py:
(StatusServer._fetch_url): Add an explicit timeout of 300s.


Canonical link: https://commits.webkit.org/184630@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@211389 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
aj062 committed Jan 30, 2017
1 parent 60143df commit 21e93da
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 1 deletion.
10 changes: 10 additions & 0 deletions Tools/ChangeLog
@@ -1,3 +1,13 @@
2017-01-30 Aakash Jain <aakash_jain@apple.com>

QueueStatusServer should have an explicit timeout for _fetch_url
https://bugs.webkit.org/show_bug.cgi?id=167467

Reviewed by Alexey Proskuryakov.

* Scripts/webkitpy/common/net/statusserver.py:
(StatusServer._fetch_url): Add an explicit timeout of 300s.

2017-01-30 Kocsen Chung <kocsen_chung@apple.com>

Add support for Trac instances that host multiple projects.
Expand Down
2 changes: 1 addition & 1 deletion Tools/Scripts/webkitpy/common/net/statusserver.py
Expand Up @@ -166,7 +166,7 @@ def update_svn_revision(self, svn_revision_number, broken_bot):
def _fetch_url(self, url):
# FIXME: This should use NetworkTransaction's 404 handling instead.
try:
return urllib2.urlopen(url).read()
return urllib2.urlopen(url, timeout=300).read()
except urllib2.HTTPError, e:
if e.code == 404:
return None
Expand Down

0 comments on commit 21e93da

Please sign in to comment.