Skip to content
Permalink
Browse files
[CSS Parser] Unskip grid tests
https://bugs.webkit.org/show_bug.cgi?id=165623

Reviewed by Zalan Bujtas.

* TestExpectations:
* fast/css-grid-layout/grid-auto-flow-get-set-expected.txt:
* fast/css-grid-layout/grid-auto-flow-get-set.html:
* fast/css-grid-layout/grid-columns-rows-get-set-expected.txt:
* fast/css-grid-layout/grid-template-shorthand-get-set-expected.txt:
* fast/css-grid-layout/grid-template-shorthand-get-set.html:
* fast/css-grid-layout/non-grid-columns-rows-get-set-expected.txt:
* fast/css-grid-layout/resources/grid-columns-rows-get-set.js:
* fast/css-grid-layout/resources/non-grid-columns-rows-get-set.js:



Canonical link: https://commits.webkit.org/183221@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@209562 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
David Hyatt committed Dec 8, 2016
1 parent a1ec705 commit 25d496ee49c01a9f435b2a8a364ddcd150ec21d8
Showing 10 changed files with 20 additions and 30 deletions.
@@ -1,3 +1,20 @@
2016-12-08 Dave Hyatt <hyatt@apple.com>

[CSS Parser] Unskip grid tests
https://bugs.webkit.org/show_bug.cgi?id=165623

Reviewed by Zalan Bujtas.

* TestExpectations:
* fast/css-grid-layout/grid-auto-flow-get-set-expected.txt:
* fast/css-grid-layout/grid-auto-flow-get-set.html:
* fast/css-grid-layout/grid-columns-rows-get-set-expected.txt:
* fast/css-grid-layout/grid-template-shorthand-get-set-expected.txt:
* fast/css-grid-layout/grid-template-shorthand-get-set.html:
* fast/css-grid-layout/non-grid-columns-rows-get-set-expected.txt:
* fast/css-grid-layout/resources/grid-columns-rows-get-set.js:
* fast/css-grid-layout/resources/non-grid-columns-rows-get-set.js:

2016-12-08 Zalan Bujtas <zalan@apple.com>

Overlapping text at AppleSeed forum's footer.
@@ -968,18 +968,11 @@ webkit.org/b/162828 [ Debug ] tables/table-section-overflow-clip-crash.html [ S
webkit.org/b/164797 js/dom/domjit-function-get-element-by-id-licm.html [ Pass Timeout ]
webkit.org/b/164797 js/dom/domjit-function-get-element-by-id-changed.html [ Pass Timeout ]

# The following layout tests need to be changed when the new CSS Parser is turned on, since they
# incorrectly indicate failures on valid syntax.
webkit.org/b/165195 fast/css-grid-layout/grid-auto-flow-get-set.html [ Pass Failure ]
webkit.org/b/165195 fast/css-grid-layout/grid-columns-rows-get-set.html [ Pass Failure ]
webkit.org/b/165195 fast/css-grid-layout/non-grid-columns-rows-get-set.html [ Pass Failure ]

# The following tests match Blink/Chrome, but we're not sure yet what to do with them when the
# new CSS parser is turned on. The tests may be right, and these may be bugs in Blink/Chrome, or
# the tests may be wrong.
webkit.org/b/165195 fast/css/parsing-css-allowed-string-characters.html [ Pass Failure ]
webkit.org/b/165195 fast/selectors/invalid-functional-pseudo-class.html [ Pass Failure ]
webkit.org/b/165195 fast/css-grid-layout/grid-template-shorthand-get-set.html [ Pass Failure ]

# Visual viewports
webkit.org/b/165460 compositing/repaint/scroll-fixed-layer-no-content.html [ Failure ]
@@ -31,7 +31,7 @@ PASS element.style.gridAutoFlow is 'column'
PASS window.getComputedStyle(element, '').getPropertyValue('grid-auto-flow') is 'column'
PASS element.style.gridAutoFlow is 'column dense'
PASS window.getComputedStyle(element, '').getPropertyValue('grid-auto-flow') is 'column dense'
PASS element.style.gridAutoFlow is 'row dense'
PASS element.style.gridAutoFlow is 'dense'
PASS window.getComputedStyle(element, '').getPropertyValue('grid-auto-flow') is 'row dense'
PASS element.style.gridAutoFlow is 'row dense'
PASS window.getComputedStyle(element, '').getPropertyValue('grid-auto-flow') is 'row dense'
@@ -96,7 +96,7 @@
debug("Test getting and setting grid-auto-flow through JS");
checkGridAutoFlowSetJSValue("column", "column", "column");
checkGridAutoFlowSetJSValue("column dense", "column dense", "column dense");
checkGridAutoFlowSetJSValue("dense", "row dense", "row dense");
checkGridAutoFlowSetJSValue("dense", "dense", "row dense");
checkGridAutoFlowSetJSValue("row dense", "row dense", "row dense");
checkGridAutoFlowSetJSValue("dense column", "column dense", "column dense");
checkGridAutoFlowSetJSValue("dense row", "row dense", "row dense");
@@ -184,10 +184,6 @@ PASS window.getComputedStyle(element, '').getPropertyValue('grid-template-column
PASS window.getComputedStyle(element, '').getPropertyValue('grid-template-rows') is "none"
PASS window.getComputedStyle(element, '').getPropertyValue('grid-template-columns') is "none"
PASS window.getComputedStyle(element, '').getPropertyValue('grid-template-rows') is "none"
PASS window.getComputedStyle(element, '').getPropertyValue('grid-template-columns') is "none"
PASS window.getComputedStyle(element, '').getPropertyValue('grid-template-rows') is "none"
PASS window.getComputedStyle(element, '').getPropertyValue('grid-template-columns') is "none"
PASS window.getComputedStyle(element, '').getPropertyValue('grid-template-rows') is "none"

Test setting grid-template-columns and grid-template-rows back to 'none' through JS
PASS getComputedStyle(element, '').getPropertyValue('grid-template-columns') is "18px"
@@ -174,12 +174,6 @@ PASS getComputedStyle(element, '').getPropertyValue('grid-template-rows') is "[h
PASS element.style.gridTemplateRows is "[head] 15px [tail]"
PASS getComputedStyle(element, '').getPropertyValue('grid-template-areas') is "\"a\""
PASS element.style.gridTemplateAreas is "\"a\""
PASS getComputedStyle(element, '').getPropertyValue('grid-template-columns') is "100px"
PASS element.style.gridTemplateColumns is "100px"
PASS getComputedStyle(element, '').getPropertyValue('grid-template-rows') is "[foo1 bar1] 50px [foo2 bar2 foo3 bar3] 50px [foo4 bar4]"
PASS element.style.gridTemplateRows is "[foo1 bar1] 50px [foo2 bar2 foo3 bar3] 50px [foo4 bar4]"
PASS getComputedStyle(element, '').getPropertyValue('grid-template-areas') is "\"a\" \"b\""
PASS element.style.gridTemplateAreas is "\"a\" \"b\""
PASS getComputedStyle(element, '').getPropertyValue('grid-template-columns') is "0px"
PASS element.style.gridTemplateColumns is "none"
PASS getComputedStyle(element, '').getPropertyValue('grid-template-rows') is "0px"
@@ -267,7 +267,6 @@
debug("Test getting and setting grid-template shorthand through JS");
testGridDefinitionsSetJSValues("66px / 18px", "18px", "66px", "none");
testGridDefinitionsSetJSValues("[head] 'a' 15px [tail] / 10px", "10px", "[head] 15px [tail]", "\"a\"");
testGridDefinitionsSetJSValues("[foo1 bar1] 'a' 50px [foo2 bar2] [foo3 bar3] 'b' 50px [foo4 bar4] / 100px", "100px", "[foo1 bar1] 50px [foo2 bar2 foo3 bar3] 50px [foo4 bar4]", "\"a\" \"b\"");
testGridDefinitionsSetJSValues("'a'", "0px", "0px", "\"a\"", "none", "auto");

debug("");
@@ -132,10 +132,6 @@ PASS window.getComputedStyle(element, '').getPropertyValue('grid-template-column
PASS window.getComputedStyle(element, '').getPropertyValue('grid-template-rows') is "none"
PASS window.getComputedStyle(element, '').getPropertyValue('grid-template-columns') is "none"
PASS window.getComputedStyle(element, '').getPropertyValue('grid-template-rows') is "none"
PASS window.getComputedStyle(element, '').getPropertyValue('grid-template-columns') is "none"
PASS window.getComputedStyle(element, '').getPropertyValue('grid-template-rows') is "none"
PASS window.getComputedStyle(element, '').getPropertyValue('grid-template-columns') is "none"
PASS window.getComputedStyle(element, '').getPropertyValue('grid-template-rows') is "none"

Test setting grid-template-columns and grid-template-rows back to 'none' through JS
PASS getComputedStyle(element, '').getPropertyValue('grid-template-columns') is "18px"
@@ -93,9 +93,7 @@ testGridTemplatesSetBadJSValues("fit-content([a] 100px)", "fit-content(30px [b c

testGridTemplatesSetBadJSValues("-2fr", "3ffr");
testGridTemplatesSetBadJSValues("-2.05fr", "+-3fr");
testGridTemplatesSetBadJSValues("0fr", "1r");
// A dimension doesn't allow spaces between the number and the unit.
testGridTemplatesSetBadJSValues(".0000fr", "13 fr");

testGridTemplatesSetBadJSValues("7.-fr", "-8,0fr");

// Negative values are not allowed.
@@ -71,9 +71,6 @@ testGridTemplatesSetBadJSValues("minmax(1fr, 100px)", "minmax(2.5fr, 200px)");

testGridTemplatesSetBadJSValues("-2fr", "3ffr");
testGridTemplatesSetBadJSValues("-2.05fr", "+-3fr");
testGridTemplatesSetBadJSValues("0fr", "1r");
// A dimension doesn't allow spaces between the number and the unit.
testGridTemplatesSetBadJSValues(".0000fr", "13 fr");
testGridTemplatesSetBadJSValues("7.-fr", "-8,0fr");
// Negative values are not allowed.
testGridTemplatesSetBadJSValues("-1px", "-6em");

0 comments on commit 25d496e

Please sign in to comment.