Add instrumentation for when we fail to receive a message

https://bugs.webkit.org/show_bug.cgi?id=167179 Reviewed by Alexey Proskuryakov. This will help us diagnose what the error from mach_msg is. * Platform/IPC/mac/ConnectionMac.mm: (IPC::readFromMachPort): Canonical link: https://commits.webkit.org/184226@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@210892 268f45cc-cd09-0410-ab3c-d52691b4dbfc
WebKit · Jan 18, 2017 · 26ed82a · 26ed82a
1 parent 40904e8
commit 26ed82a
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/Source/WebKit2/ChangeLog b/Source/WebKit2/ChangeLog
@@ -1,3 +1,15 @@
+2017-01-18  Anders Carlsson  <andersca@apple.com>
+
+        Add instrumentation for when we fail to receive a message
+        https://bugs.webkit.org/show_bug.cgi?id=167179
+
+        Reviewed by Alexey Proskuryakov.
+
+        This will help us diagnose what the error from mach_msg is.
+
+        * Platform/IPC/mac/ConnectionMac.mm:
+        (IPC::readFromMachPort):
+
 2017-01-18  Alex Christensen  <achristensen@webkit.org>
 
         Fix CFURLConnection build on Mac

diff --git a/Source/WebKit2/Platform/IPC/mac/ConnectionMac.mm b/Source/WebKit2/Platform/IPC/mac/ConnectionMac.mm
@@ -497,6 +497,9 @@ static dispatch_source_t createReceiveSource(mach_port_t receivePort, WorkQueue&
     }
 
     if (kr != MACH_MSG_SUCCESS) {
+#if !ASSERT_DISABLED
+        WKSetCrashReportApplicationSpecificInformation((CFStringRef)[NSString stringWithFormat:@"Unhandled error code %x from mach_msg", kr]);
+#endif
         ASSERT_NOT_REACHED();
         return 0;
     }