Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
[ews-build] Check patch relevance before applying the patch
https://bugs.webkit.org/show_bug.cgi?id=193102

Reviewed by Lucas Forschler.

* BuildSlaveSupport/ews-build/factories.py:
(Factory.__init__): Moved CheckPatchRelevance step to base class.


Canonical link: https://commits.webkit.org/207644@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239616 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
aj062 committed Jan 4, 2019
1 parent 21f02ef commit 27d97f8
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 7 deletions.
13 changes: 6 additions & 7 deletions Tools/BuildSlaveSupport/ews-build/factories.py
Expand Up @@ -30,9 +30,11 @@


class Factory(factory.BuildFactory):
def __init__(self, platform, configuration=None, architectures=None, buildOnly=True, additionalArguments=None, **kwargs):
def __init__(self, platform, configuration=None, architectures=None, buildOnly=True, additionalArguments=None, checkRelevance=False, **kwargs):
factory.BuildFactory.__init__(self)
self.addStep(ConfigureBuild(platform, configuration, architectures, buildOnly, additionalArguments))
if checkRelevance:
self.addStep(CheckPatchRelevance())
self.addStep(CheckOutSource())


Expand All @@ -44,8 +46,7 @@ def __init__(self, platform, configuration=None, architectures=None, additionalA

class BindingsFactory(Factory):
def __init__(self, platform, configuration=None, architectures=None, additionalArguments=None, **kwargs):
Factory.__init__(self, platform, configuration, architectures, False, additionalArguments)
self.addStep(CheckPatchRelevance())
Factory.__init__(self, platform, configuration, architectures, False, additionalArguments, checkRelevance=True)
self.addStep(RunBindingsTests())


Expand All @@ -57,8 +58,7 @@ def __init__(self, platform, configuration=None, architectures=None, additionalA

class WebKitPyFactory(Factory):
def __init__(self, platform, configuration=None, architectures=None, additionalArguments=None, **kwargs):
Factory.__init__(self, platform, configuration, architectures, False, additionalArguments)
self.addStep(CheckPatchRelevance())
Factory.__init__(self, platform, configuration, architectures, False, additionalArguments, checkRelevance=True)
self.addStep(RunWebKitPyTests())


Expand Down Expand Up @@ -104,8 +104,7 @@ def __init__(self, platform, configuration=None, architectures=None, additionalA

class JSCTestsFactory(Factory):
def __init__(self, platform, configuration='release', architectures=None, additionalArguments=None, **kwargs):
Factory.__init__(self, platform, configuration, architectures, False, additionalArguments)
self.addStep(CheckPatchRelevance())
Factory.__init__(self, platform, configuration, architectures, False, additionalArguments, checkRelevance=True)
self.addStep(CompileJSCOnly())
self.addStep(UnApplyPatchIfRequired())
self.addStep(CompileJSCOnlyToT())
Expand Down
10 changes: 10 additions & 0 deletions Tools/ChangeLog
@@ -1,3 +1,13 @@
2019-01-04 Aakash Jain <aakash_jain@apple.com>

[ews-build] Check patch relevance before applying the patch
https://bugs.webkit.org/show_bug.cgi?id=193102

Reviewed by Lucas Forschler.

* BuildSlaveSupport/ews-build/factories.py:
(Factory.__init__): Moved CheckPatchRelevance step to base class.

2019-01-04 Aakash Jain <aakash_jain@apple.com>

[ews-build] Check patch relevance step should print patch id
Expand Down

0 comments on commit 27d97f8

Please sign in to comment.