Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Avoid redundant checks for Compositing reasons in RenderLayerCompositor
https://bugs.webkit.org/show_bug.cgi?id=118114

Patch by Sanjoy Pal <sanjoy.pal@samsung.com> on 2013-06-26
Reviewed by Anders Carlsson.

A RenderObject can be any one of the Video, Canvas, Plugin or Iframe.
Hence removing the redundant checks.

No new tests as no functionality change.

* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::reasonsForCompositing):

Canonical link: https://commits.webkit.org/136157@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152078 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
sanjoypal authored and webkit-commit-queue committed Jun 27, 2013
1 parent ef5a77a commit 282daa6
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 6 deletions.
15 changes: 15 additions & 0 deletions Source/WebCore/ChangeLog
@@ -1,3 +1,18 @@
2013-06-26 Sanjoy Pal <sanjoy.pal@samsung.com>

Avoid redundant checks for Compositing reasons in RenderLayerCompositor
https://bugs.webkit.org/show_bug.cgi?id=118114

Reviewed by Anders Carlsson.

A RenderObject can be any one of the Video, Canvas, Plugin or Iframe.
Hence removing the redundant checks.

No new tests as no functionality change.

* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::reasonsForCompositing):

2013-06-26 Gwang Yoon Hwang <ryumiel@company100.net>

Coordinated Graphics: Separate CoordinatedLayerTreeHost into CoordinatedLayerTreeHost and CompositingCoordinator
Expand Down
9 changes: 3 additions & 6 deletions Source/WebCore/rendering/RenderLayerCompositor.cpp
Expand Up @@ -1841,14 +1841,11 @@ CompositingReasons RenderLayerCompositor::reasonsForCompositing(const RenderLaye

if (requiresCompositingForVideo(renderer))
reasons |= CompositingReasonVideo;

if (requiresCompositingForCanvas(renderer))
else if (requiresCompositingForCanvas(renderer))
reasons |= CompositingReasonCanvas;

if (requiresCompositingForPlugin(renderer))
else if (requiresCompositingForPlugin(renderer))
reasons |= CompositingReasonPlugin;

if (requiresCompositingForFrame(renderer))
else if (requiresCompositingForFrame(renderer))
reasons |= CompositingReasonIFrame;

if ((canRender3DTransforms() && renderer->style()->backfaceVisibility() == BackfaceVisibilityHidden))
Expand Down

0 comments on commit 282daa6

Please sign in to comment.