Please sign in to comment.
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix an assertion when a plugin returns -1 from NPP_Write
We were forgetting to call setDefersLoading(false) before destroying the PluginStream. In the process of destroying the stream, someone would call setDefersLoading(true), and we would assert because we were already deferring loads. Fixes <http://webkit.org/b/42563> Assertion failure in ResourceHandle::setDefersLoading when running plugins/return-negative-one-from-write.html on Windows Reviewed by Anders Carlsson. * plugins/PluginStream.cpp: (WebCore::PluginStream::deliverData): Call setDefersLoading(false) before destroying the stream, to match the setDefersLoading(true) call earlier in this function. (We already call setDefersLoading(false) in the non-error case later on.) Canonical link: https://commits.webkit.org/54507@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63667 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- Loading branch information
Showing with 23 additions and 0 deletions.