Skip to content
Permalink
Browse files
No nightlies listed on nightly.webkit.org when using shipping Safari …
…on macOS Sierra and OS X El Capitan

https://bugs.webkit.org/show_bug.cgi?id=178372

Reviewed by Tim Horton.

The Build Archive page depends on the collections (e.g. HTMLCollection) being
iterable so as to support iteration using ES6 for-of loop. Such support postdates
the version of WebKit shipped in macOS Sierra and OS X El Capitan. We should
make <https://webkit.org/build-archives/> work for these OSes since we still publish
nightlies for them.

* wp-content/themes/webkit/build-archives.php: Use Array.prototype.slice() to
convert the HTMLCollection to an array that can be iterated using a ES6 for-of loop.

Canonical link: https://commits.webkit.org/194595@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@223455 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
dydz committed Oct 17, 2017
1 parent 7d50b2b commit 2a39714004b61efe60ecd40094714a06680307aa
Showing with 18 additions and 2 deletions.
  1. +16 −0 Websites/webkit.org/ChangeLog
  2. +2 −2 Websites/webkit.org/wp-content/themes/webkit/build-archives.php
@@ -1,3 +1,19 @@
2017-10-16 Daniel Bates <dabates@apple.com>

No nightlies listed on nightly.webkit.org when using shipping Safari on macOS Sierra and OS X El Capitan
https://bugs.webkit.org/show_bug.cgi?id=178372

Reviewed by Tim Horton.

The Build Archive page depends on the collections (e.g. HTMLCollection) being
iterable so as to support iteration using ES6 for-of loop. Such support postdates
the version of WebKit shipped in macOS Sierra and OS X El Capitan. We should
make <https://webkit.org/build-archives/> work for these OSes since we still publish
nightlies for them.

* wp-content/themes/webkit/build-archives.php: Use Array.prototype.slice() to
convert the HTMLCollection to an array that can be iterated using a ES6 for-of loop.

2017-10-04 Megan Gardner <megan_gardner@apple.com>

Update Webkit Style webpage to include Obj-C blocks
@@ -62,7 +62,7 @@ public function get_latest($platform_key) {
(function(document) {
document.addEventListener("DOMContentLoaded", function () {

var creationTimeNodes = document.getElementsByClassName("date");
var creationTimeNodes = Array.prototype.slice.call(document.getElementsByClassName("date"));
for (var timestamp of creationTimeNodes) {
var date = new Date(parseInt(timestamp.textContent));
timestamp.textContent = date.toLocaleDateString("en", {
@@ -75,7 +75,7 @@ public function get_latest($platform_key) {
})
}

var tabnav = document.getElementsByClassName("tabnav-link"),
var tabnav = Array.prototype.slice.call(document.getElementsByClassName("tabnav-link")),
currentTab = function(e) {
var target = e.target ? e.target : e,
currentLink = document.getElementsByClassName("tabnav-link current")

0 comments on commit 2a39714

Please sign in to comment.