[GTK] Scrollbars painted incorrectly if theme enables steppers (stepp…

…ers misplaced on vertical scrollbars, horizontal scrollbars very broken)

https://bugs.webkit.org/show_bug.cgi?id=234871

Reviewed by Carlos Garcia Campos.

Actually use the scrollbar orientation when creating its contents,
instead of always using vertical.

* platform/gtk/RenderThemeScrollbar.cpp:
(WebCore::RenderThemeScrollbar::RenderThemeScrollbar):



Canonical link: https://commits.webkit.org/247060@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@289529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog

@@ -1,3 +1,16 @@
+2022-02-10  Alexander Mikhaylenko  <alexm@gnome.org>
+
+        [GTK] Scrollbars painted incorrectly if theme enables steppers (steppers misplaced on vertical scrollbars, horizontal scrollbars very broken) 
+        https://bugs.webkit.org/show_bug.cgi?id=234871
+
+        Reviewed by Carlos Garcia Campos.
+
+        Actually use the scrollbar orientation when creating its contents,
+        instead of always using vertical.
+
+        * platform/gtk/RenderThemeScrollbar.cpp:
+        (WebCore::RenderThemeScrollbar::RenderThemeScrollbar):
+
 2022-02-10  Carlos Garcia Campos  <cgarcia@igalia.com>
 
         [GTK][WPE] Refactor the XDGDBusProxy launcher to simplify it and fix some issues

Source/WebCore/platform/gtk/RenderThemeScrollbar.cpp

@@ -107,7 +107,7 @@ RenderThemeScrollbar::RenderThemeScrollbar(GtkOrientation orientation, Mode mode
     info.type = RenderThemeGadget::Type::Generic;
     info.name = "contents";
     info.classList.clear();
-    m_contents = makeUnique<RenderThemeBoxGadget>(info, GTK_ORIENTATION_VERTICAL, children, m_scrollbar.get());
+    m_contents = makeUnique<RenderThemeBoxGadget>(info, orientation, children, m_scrollbar.get());
     info.name = "slider";
     m_slider = RenderThemeGadget::create(info, m_contents->child(m_troughPosition));
 }