Skip to content
Permalink
Browse files
2010-10-18 Ilya Tikhonovsky <loislo@chromium.org>
        Reviewed by Yury Semikhatsky.

        Web Inspector: [REGRESSION] Inspector window visible during run-webkit-tests.
        The initial state of an inspector setting should stay untouched
        if the profile has no value for it.

        https://bugs.webkit.org/show_bug.cgi?id=47785

        * inspector/InspectorState.cpp:
        (WebCore::InspectorState::loadFromSettings):

Canonical link: https://commits.webkit.org/60522@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69956 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
loislo committed Oct 18, 2010
1 parent 31206d6 commit 2b6b74078f1f0cb1a0508205a3836b0d10c91217
Showing 2 changed files with 17 additions and 2 deletions.
@@ -1,3 +1,16 @@
2010-10-18 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [REGRESSION] Inspector window visible during run-webkit-tests.
The initial state of an inspector setting should stay untouched
if the profile has no value for it.

https://bugs.webkit.org/show_bug.cgi?id=47785

* inspector/InspectorState.cpp:
(WebCore::InspectorState::loadFromSettings):

2010-10-18 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.
@@ -92,13 +92,15 @@ void InspectorState::loadFromSettings()
m_client->populateSetting(i->second.m_preferenceName, &value);
switch (i->second.m_value->type()) {
case InspectorValue::TypeBoolean:
i->second.m_value = InspectorBasicValue::create(value == "true");
if (value.length())
i->second.m_value = InspectorBasicValue::create(value == "true");
break;
case InspectorValue::TypeString:
i->second.m_value = InspectorString::create(value);
break;
case InspectorValue::TypeNumber:
i->second.m_value = InspectorBasicValue::create((double)value.toInt());
if (value.length())
i->second.m_value = InspectorBasicValue::create((double)value.toInt());
break;
default:
ASSERT(false);

0 comments on commit 2b6b740

Please sign in to comment.