Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Unreviewed unit test skipping.
Filed https://bugs.webkit.org/show_bug.cgi?id=105253 to re-enable them.

* TestWebKitAPI/Tests/WTF/MathExtras.cpp:
(TestWebKitAPI):
(TestWebKitAPI::TEST):

Canonical link: https://commits.webkit.org/123493@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137986 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
Julien Chaffraix committed Dec 18, 2012
1 parent 34b7aca commit 2c19b77
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 2 deletions.
10 changes: 10 additions & 0 deletions Tools/ChangeLog
@@ -1,3 +1,13 @@
2012-12-17 Julien Chaffraix <jchaffraix@webkit.org>

Unreviewed unit test skipping.

Filed https://bugs.webkit.org/show_bug.cgi?id=105253 to re-enable them.

* TestWebKitAPI/Tests/WTF/MathExtras.cpp:
(TestWebKitAPI):
(TestWebKitAPI::TEST):

2012-12-17 Dean Jackson <dino@apple.com>

Unreviewed. Add Silvia Pfeiffer to contributor list.
Expand Down
6 changes: 4 additions & 2 deletions Tools/TestWebKitAPI/Tests/WTF/MathExtras.cpp
Expand Up @@ -87,7 +87,8 @@ TEST(WTF, clampToIntLongLong)
EXPECT_EQ(clampTo<int>(underflowInt), minInt);
}

TEST(WTF, clampToIntegerFloat)
// https://bugs.webkit.org/show_bug.cgi?id=105253
TEST(WTF, DISABLED_clampToIntegerFloat)
{
// This test is inaccurate as floats will round the min / max integer
// due to the narrow mantissa. However it will properly checks within
Expand Down Expand Up @@ -144,7 +145,8 @@ TEST(WTF, clampToFloat)
EXPECT_EQ(clampToFloat(-std::numeric_limits<float>::infinity()), minFloat);
}

TEST(WTF, clampToUnsigned)
// https://bugs.webkit.org/show_bug.cgi?id=105253
TEST(WTF, DISABLED_clampToUnsigned)
{
unsigned long maxUnsigned = std::numeric_limits<unsigned>::max();
unsigned long overflowUnsigned = maxUnsigned + 1;
Expand Down

0 comments on commit 2c19b77

Please sign in to comment.