Unreviewed, rolling out r196251.

https://bugs.webkit.org/show_bug.cgi?id=154078 Large regression on Dromaeo needs explanation (Requested by kling on #webkit). Reverted changeset: "Visiting a WeakBlock should report bytes visited, since we reported them allocated." https://bugs.webkit.org/show_bug.cgi?id=153978 http://trac.webkit.org/changeset/196251 Canonical link: https://commits.webkit.org/172175@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196369 268f45cc-cd09-0410-ab3c-d52691b4dbfc
WebKit · Feb 10, 2016 · 2d1f03cbd4ef2e3fbde5862de5f82ec8ada14f10 · 2d1f03c
1 parent bff4e1b
commit 2d1f03cbd4ef2e3fbde5862de5f82ec8ada14f10
Showing with 15 additions and 3 deletions.

+15 −0 Source/JavaScriptCore/ChangeLog

+0 −1 Source/JavaScriptCore/heap/SlotVisitor.h

+0 −2 Source/JavaScriptCore/heap/WeakBlock.cpp
diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog
@@ -1,3 +1,18 @@
+2016-02-10  Commit Queue  <commit-queue@webkit.org>
+
+        Unreviewed, rolling out r196251.
+        https://bugs.webkit.org/show_bug.cgi?id=154078
+
+        Large regression on Dromaeo needs explanation (Requested by
+        kling on #webkit).
+
+        Reverted changeset:
+
+        "Visiting a WeakBlock should report bytes visited, since we
+        reported them allocated."
+        https://bugs.webkit.org/show_bug.cgi?id=153978
+        http://trac.webkit.org/changeset/196251
+
 2016-02-10  Csaba Osztrogonác  <ossy@webkit.org>
 
         REGRESSION(r196331): It made ~180 JSC tests crash on ARMv7 Linux

diff --git a/Source/JavaScriptCore/heap/SlotVisitor.h b/Source/JavaScriptCore/heap/SlotVisitor.h
@@ -105,7 +105,6 @@ class SlotVisitor {
     void copyLater(JSCell*, CopyToken, void*, size_t);
 
     void reportExtraMemoryVisited(size_t);
-    void reportMemoryVisited(size_t bytes) { m_bytesVisited += bytes; }
 
     void addWeakReferenceHarvester(WeakReferenceHarvester*);
     void addUnconditionalFinalizer(UnconditionalFinalizer*);

diff --git a/Source/JavaScriptCore/heap/WeakBlock.cpp b/Source/JavaScriptCore/heap/WeakBlock.cpp
@@ -109,8 +109,6 @@ void WeakBlock::visit(HeapRootVisitor& heapRootVisitor)
 
     SlotVisitor& visitor = heapRootVisitor.visitor();
 
-    visitor.reportMemoryVisited(WeakBlock::blockSize);
-
     for (size_t i = 0; i < weakImplCount(); ++i) {
         WeakImpl* weakImpl = &weakImpls()[i];
         if (weakImpl->state() != WeakImpl::Live)