Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
2010-01-17 Srinidhi Shreedhara <srinidhi.shreedhara@nokia.com>
        Reviewed by Simon Hausmann.

        [Qt] [Symbian] SetWindow call in npapi plugin does not happen when the cooridnates are negative
        https://bugs.webkit.org/show_bug.cgi?id=33573

        * plugins/symbian/PluginViewSymbian.cpp:
        (WebCore::PluginView::setNPWindowIfNeeded): Remove tests for negative
        coordinates for early return.



Canonical link: https://commits.webkit.org/44791@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53390 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
LaszloGombos committed Jan 18, 2010
1 parent 38e8a9c commit 2dcc9ab
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 2 deletions.
11 changes: 11 additions & 0 deletions WebCore/ChangeLog
@@ -1,3 +1,14 @@
2010-01-17 Srinidhi Shreedhara <srinidhi.shreedhara@nokia.com>

Reviewed by Simon Hausmann.

[Qt] [Symbian] SetWindow call in npapi plugin does not happen when the cooridnates are negative
https://bugs.webkit.org/show_bug.cgi?id=33573

* plugins/symbian/PluginViewSymbian.cpp:
(WebCore::PluginView::setNPWindowIfNeeded): Remove tests for negative
coordinates for early return.

2010-01-17 Oliver Hunt <oliver@apple.com>

Reviewed by Dan Bernstein.
Expand Down
2 changes: 0 additions & 2 deletions WebCore/plugins/symbian/PluginViewSymbian.cpp
Expand Up @@ -281,8 +281,6 @@ void PluginView::setNPWindowIfNeeded()

m_npWindow.width = m_windowRect.width();
m_npWindow.height = m_windowRect.height();
if (m_npWindow.x < 0 || m_npWindow.y < 0 || m_npWindow.width <= 0 || m_npWindow.height <= 0)
return;

PluginView::setCurrentPluginView(this);
JSC::JSLock::DropAllLocks dropAllLocks(JSC::SilenceAssertionsOnly);
Expand Down

0 comments on commit 2dcc9ab

Please sign in to comment.