Skip to content
Permalink
Browse files
2008-12-02 Michael Moss <mmoss@chromium.org>
        Reviewed by Eric Seidel.

        - Fix http/tests/navigation/reload-subframe-*frame.html on Windows.
        https://bugs.webkit.org/show_bug.cgi?id=20926

        Change 31264 fixed this on Mac (since moved to WebCore/loader/FrameLoader.cpp), but was never ported to Windows.

        * WebCoreSupport/WebFrameLoaderClient.cpp:
        (WebFrameLoaderClient::loadURLIntoChild):

Canonical link: https://commits.webkit.org/31119@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38912 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
eseidel committed Dec 2, 2008
1 parent 43774cf commit 2f44b01b71329ed8d6e847200c504a2b017089b0
Showing 4 changed files with 21 additions and 3 deletions.
@@ -1,3 +1,12 @@
2008-12-02 Michael Moss <mmoss@chromium.org>

Reviewed by Eric Seidel.

Enable http/tests/navigation/reload-subframe-*frame.html on Windows.
https://bugs.webkit.org/show_bug.cgi?id=20926

* platform/win/Skipped:

2008-12-01 Beth Dakin <bdakin@apple.com>

Reviewed by Dan Bernstein.
@@ -317,8 +317,6 @@ svg/custom/acid3-test-77.html
fast/canvas/toDataURL-supportedTypes.html

#<rdar://problem/5829202> new subframe reload tests fail on Windows
http/tests/navigation/reload-subframe-frame.html
http/tests/navigation/reload-subframe-iframe.html
http/tests/navigation/reload-subframe-object.html

#<rdar://problem/5829260> REGRESSION: frame-default-enc tests fail on Windows intermittently
@@ -1,3 +1,15 @@
2008-12-02 Michael Moss <mmoss@chromium.org>

Reviewed by Eric Seidel.

- Fix http/tests/navigation/reload-subframe-*frame.html on Windows.
https://bugs.webkit.org/show_bug.cgi?id=20926

Change 31264 fixed this on Mac (since moved to WebCore/loader/FrameLoader.cpp), but was never ported to Windows.

* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::loadURLIntoChild):

2008-12-01 Steve Falkenburg <sfalken@apple.com>

Implement renderedImage for Windows.
@@ -544,7 +544,6 @@ void WebFrameLoaderClient::loadURLIntoChild(const KURL& originalURL, const Strin
// Reload will maintain the frame contents, LoadSame will not.
if (parentItem && parentItem->children().size() &&
(isBackForwardLoadType(loadType)
|| loadType == FrameLoadTypeReload
|| loadType == FrameLoadTypeReloadAllowingStaleData))
{
if (HistoryItem* childItem = parentItem->childItemWithName(core(childFrame)->tree()->name())) {

0 comments on commit 2f44b01

Please sign in to comment.