Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
[JSC] Speed up getStatusMap and increase robustness
https://bugs.webkit.org/show_bug.cgi?id=236559

Reviewed by Adrian Perez de Castro.

Collect test results in parallel. Also, ignore ssh errors during
collection (e.g. because the remote host is down) -- the main retry
loop will take care of that for us.

This should both avoid needless failures like
https://build.webkit.org/#/builders/31/builds/2432 and reduce the
latency when there are multiple remotes (e.g. for MIPS).

* Scripts/run-jsc-stress-tests:



Canonical link: https://commits.webkit.org/247272@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@289811 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
aoikonomopoulos committed Feb 15, 2022
1 parent dca838f commit 3025858
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 2 deletions.
17 changes: 17 additions & 0 deletions Tools/ChangeLog
@@ -1,3 +1,20 @@
2022-02-15 Angelos Oikonomopoulos <angelos@igalia.com>

[JSC] Speed up getStatusMap and increase robustness
https://bugs.webkit.org/show_bug.cgi?id=236559

Reviewed by Adrian Perez de Castro.

Collect test results in parallel. Also, ignore ssh errors during
collection (e.g. because the remote host is down) -- the main retry
loop will take care of that for us.

This should both avoid needless failures like
https://build.webkit.org/#/builders/31/builds/2432 and reduce the
latency when there are multiple remotes (e.g. for MIPS).

* Scripts/run-jsc-stress-tests:

2022-02-14 Kimmo Kinnunen <kkinnunen@apple.com>

ExtensionsGL is not useful class, it should be removed
Expand Down
3 changes: 1 addition & 2 deletions Tools/Scripts/run-jsc-stress-tests
Expand Up @@ -2769,8 +2769,7 @@ def getStatusMap(map={})
# well be test results on a remoteHost that got rebooted
# (note, the test results are tagged with a run ID, so we'll
# ignore any stale results from a previous run).
$remoteHosts.each_with_index {
| host, remoteIndex |
forEachRemote($remoteHosts, :dropOnFailure => true, :timeout => REMOTE_TIMEOUT) { |_, host|
runnerDir = "#{host.remoteDirectory}/#{$outputDir.basename}/.runner"
output = sshRead("if test -d #{runnerDir}; then cd #{runnerDir}; else false; fi && " + find_cmd, host, :ignoreFailure => true)
output.split(/\n/).each {
Expand Down

0 comments on commit 3025858

Please sign in to comment.