Skip to content
Permalink
Browse files
REGRESSION (r287323): [iOS] 9 imported/w3c/web-platform-tests/css/css…
…-transforms tests consistently failing

https://bugs.webkit.org/show_bug.cgi?id=234908
<rdar://problem/87172770>

Reviewed by Simon Fraser.

Adjust WPT trasnform reference test fuzziness for iOS. In some cases the reference
matches more closely and in other cases slightly less closely.

* web-platform-tests/css/css-transforms/2d-rotate-001.html:
* web-platform-tests/css/css-transforms/css-skew-002.html:
* web-platform-tests/css/css-transforms/rotate_45deg.html:
* web-platform-tests/css/css-transforms/rotate_x_45deg.html:
* web-platform-tests/css/css-transforms/rotate_y_45deg.html:
* web-platform-tests/css/css-transforms/skew-test1.html:
* web-platform-tests/css/css-transforms/transform-percent-008.html:
* web-platform-tests/css/css-transforms/ttwf-transform-skewx-001.html:
* web-platform-tests/css/css-transforms/ttwf-transform-skewy-001.html:



Canonical link: https://commits.webkit.org/245784@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@287688 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
mrobinson committed Jan 6, 2022
1 parent c122296 commit 30987aa0d91831db56f94c60f8f4c922f5c9eadb
Showing 10 changed files with 30 additions and 9 deletions.
@@ -1,3 +1,24 @@
2022-01-06 Martin Robinson <mrobinson@webkit.org>

REGRESSION (r287323): [iOS] 9 imported/w3c/web-platform-tests/css/css-transforms tests consistently failing
https://bugs.webkit.org/show_bug.cgi?id=234908
<rdar://problem/87172770>

Reviewed by Simon Fraser.

Adjust WPT trasnform reference test fuzziness for iOS. In some cases the reference
matches more closely and in other cases slightly less closely.

* web-platform-tests/css/css-transforms/2d-rotate-001.html:
* web-platform-tests/css/css-transforms/css-skew-002.html:
* web-platform-tests/css/css-transforms/rotate_45deg.html:
* web-platform-tests/css/css-transforms/rotate_x_45deg.html:
* web-platform-tests/css/css-transforms/rotate_y_45deg.html:
* web-platform-tests/css/css-transforms/skew-test1.html:
* web-platform-tests/css/css-transforms/transform-percent-008.html:
* web-platform-tests/css/css-transforms/ttwf-transform-skewx-001.html:
* web-platform-tests/css/css-transforms/ttwf-transform-skewy-001.html:

2022-01-05 Antoine Quint <graouts@webkit.org>

computed style for transition longhand properties is wrong
@@ -5,7 +5,7 @@
<link rel="author" title="Rick Hurst" href="http://mrkn.co/axegs">
<link rel="help" href="http://www.w3.org/TR/css-transforms-1/#transform-property">
<link rel="match" href="2d-rotate-ref.html">
<meta name="fuzzy" content="maxDifference=87-128;totalPixels=981-1193">
<meta name="fuzzy" content="maxDifference=87-159;totalPixels=643-1193">
<meta name="flags" content="svg">
<meta name="assert" content="asserting that you can rotate an element with CSS">
<style type="text/css">
@@ -6,7 +6,7 @@
<link rel="help" href="http://www.w3.org/TR/css-transforms-1/#two-d-transform-functions">
<link rel="author" title="Adrien Pachkoff" href="mailto:adrien@pachkoff.com">
<link rel="match" href="css-skew-002-ref.html">
<meta name="fuzzy" content="maxDifference=5-32;totalPixels=24-159">
<meta name="fuzzy" content="maxDifference=5-32;totalPixels=12-159">
<style type="text/css">
div {
top:0px;
@@ -5,7 +5,7 @@
<link rel="author" title="Ebay Inc." href="mailto:xiatian@ebay.com"/>
<link rel="help" href="https://www.w3.org/TR/css-transforms-1/#funcdef-transform-rotate"/>
<link rel="match" href="rotate_45deg-ref.html"/>
<meta name="fuzzy" content="maxDifference=159-255;totalPixels=100-200">
<meta name="fuzzy" content="maxDifference=159-255;totalPixels=50-200">
<meta name="flags" content="" />
<meta name="assert" content="Rotate 45 degree in y axis"/>
<style type="text/css">
@@ -5,7 +5,7 @@
<link rel="author" title="Ebay Inc." href="mailto:xiatian@ebay.com"/>
<link rel="help" href="http://www.w3.org/TR/css-transforms-2/#3d-transform-rendering"/>
<link rel="match" href="rotate_x_45deg-ref.html"/>
<meta name="fuzzy" content="maxDifference=159-255;totalPixels=100-200">
<meta name="fuzzy" content="maxDifference=159-255;totalPixels=50-200">
<meta name="flags" content="" />
<meta name="assert" content="Rotate 45 degree in y axis"/>
<style type="text/css">
@@ -5,7 +5,7 @@
<link rel="author" title="Ebay Inc." href="mailto:xiatian@ebay.com"/>
<link rel="help" href="http://www.w3.org/TR/css-transforms-2/#3d-transform-rendering"/>
<link rel="match" href="rotate_y_45deg-ref.html"/>
<meta name="fuzzy" content="maxDifference=159-255;totalPixels=100-200">
<meta name="fuzzy" content="maxDifference=159-255;totalPixels=50-200">
<meta name="flags" content="" />
<meta name="assert" content="Rotate 45 degree in y axis"/>
<style type="text/css">
@@ -8,7 +8,7 @@
<link rel="help" href="http://www.w3.org/TR/css-transforms-1/#svg-transform">
<link rel="help" href="http://www.w3.org/TR/css-transforms-1/#two-d-transform-functions">
<link rel="match" href="reference/skew-test1-ref.html">
<meta name="fuzzy" content="maxDifference=17-97;totalPixels=96-771">
<meta name="fuzzy" content="maxDifference=17-233;totalPixels=96-771">
<meta name="flags" content="svg">
<meta name="assert" content="The lime square in this test has a skew method applied : 30deg on x and 20deg on y. The red polygon should be totally hidden by the lime skewed square. Both start at 0,0">
<style>
@@ -9,7 +9,7 @@
transformed element's border box. This test adds a thicker border plus
margin and padding to make any discrepancies more evident.">
<link rel="match" href="transform-percent-ref.html">
<meta name="fuzzy" content="maxDifference=0-99;totalPixels=0-416">
<meta name="fuzzy" content="maxDifference=0-102;totalPixels=0-416">
<link rel="mismatch" href="transform-percent-notref.html">
<style>
div {
@@ -5,7 +5,7 @@
<link rel="author" title="Mihai Corlan" href="mailto:mcorlan@adobe.com">
<link rel="help" href="http://www.w3.org/TR/css-transforms-1/#transform-property">
<link rel="match" href="reference/ttwf-reftest-transform-skewx-001.html">
<meta name="fuzzy" content="maxDifference=63-64;totalPixels=200-200">
<meta name="fuzzy" content="maxDifference=63-64;totalPixels=100-200">
<meta name="assert" content="Test that the green shape is skew on X axis by 45 degrees">
<style type="text/css">
.greenSquare {
@@ -5,7 +5,7 @@
<link rel="author" title="Mihai Corlan" href="mailto:mcorlan@adobe.com">
<link rel="help" href="http://www.w3.org/TR/css-transforms-1/#transform-property">
<link rel="match" href="reference/ttwf-reftest-transform-skewy-001.html">
<meta name="fuzzy" content="maxDifference=63-66;totalPixels=200-200">
<meta name="fuzzy" content="maxDifference=63-68;totalPixels=100-200">
<meta name="assert" content="Test that the green shape is skew on Y axis by 45 degrees">
<style type="text/css">
.greenSquare {

0 comments on commit 30987aa

Please sign in to comment.