[build.webkit.org] Ensure that invalid step names are not allowed

https://bugs.webkit.org/show_bug.cgi?id=217431

Reviewed by Darin Adler.

* BuildSlaveSupport/build.webkit.org-config/loadConfig.py:
(loadBuilderConfig):


Canonical link: https://commits.webkit.org/230197@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268128 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/BuildSlaveSupport/build.webkit.org-config/loadConfig.py

@@ -37,6 +37,9 @@
 import wkbuild
 
 trunk_filter = ChangeFilter(branch=["trunk", None])
+buildbot_identifiers_re = re.compile('^[a-zA-Z_-][a-zA-Z0-9_-]*$')
+
+STEP_NAME_LENGTH_LIMIT = 50
 
 
 def pickLatestBuild(builder, requests):
@@ -108,6 +111,13 @@ def loadBuilderConfig(c, test_mode_is_enabled=False):
 
         builder["factory"] = factory(**factorykwargs)
 
+        for step in builder["factory"].steps:
+            step_name = step[0].name
+            if len(step_name) > STEP_NAME_LENGTH_LIMIT:
+                raise Exception('step name "{}" is longer than maximum allowed by Buildbot ({} characters).'.format(step_name, STEP_NAME_LENGTH_LIMIT))
+            if not buildbot_identifiers_re.match(step_name):
+                raise Exception('step name "{}" is not a valid buildbot identifier.'.format(step_name))
+
         if platform.startswith('mac'):
             builder["category"] = 'AppleMac'
         elif platform.startswith('ios'):

Tools/ChangeLog

@@ -1,3 +1,13 @@
+2020-10-07  Aakash Jain  <aakash_jain@apple.com>
+
+        [build.webkit.org] Ensure that invalid step names are not allowed
+        https://bugs.webkit.org/show_bug.cgi?id=217431
+
+        Reviewed by Darin Adler.
+
+        * BuildSlaveSupport/build.webkit.org-config/loadConfig.py:
+        (loadBuilderConfig):
+
 2020-10-07  Aditya Keerthi  <akeerthi@apple.com>
 
         REGRESSION: Date/time pickers are not displayed in UIWebViews