Skip to content
Permalink
Browse files
Fixes dead code in compareIcons()
https://bugs.webkit.org/show_bug.cgi?id=234234

Patch by Karl Dubost <karl+github@la-grange.net> on 2021-12-20
Reviewed by Youenn Fablet.

* html/LinkIconCollector.cpp:
(WebCore::compareIcons):


Canonical link: https://commits.webkit.org/245418@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@287262 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
karlcow authored and webkit-commit-queue committed Dec 20, 2021
1 parent 76c912c commit 32dbaaa38a56e49a7e352f12d6e38cc95c1cd2e8
Showing 2 changed files with 11 additions and 1 deletion.
@@ -1,3 +1,13 @@
2021-12-20 Karl Dubost <karl+github@la-grange.net>

Fixes dead code in compareIcons()
https://bugs.webkit.org/show_bug.cgi?id=234234

Reviewed by Youenn Fablet.

* html/LinkIconCollector.cpp:
(WebCore::compareIcons):

2021-12-20 Alan Bujtas <zalan@apple.com>

[LFC][IFC] Adjust the atomic/generic inline level boxes with marginLeft in RTL
@@ -53,7 +53,7 @@ static int compareIcons(const LinkIcon& a, const LinkIcon& b)
// Apple Touch icons always come first.
if (a.type == LinkIconType::Favicon && b.type != LinkIconType::Favicon)
return 1;
if (a.type == LinkIconType::Favicon && b.type != LinkIconType::Favicon)
if (b.type == LinkIconType::Favicon && a.type != LinkIconType::Favicon)
return -1;

unsigned aSize = iconSize(a);

0 comments on commit 32dbaaa

Please sign in to comment.