<html> element should not have 'manifest' IDL attribute

https://bugs.webkit.org/show_bug.cgi?id=58129 Reviewed by Chris Dumez. Removed manifest IDL attribute from the html element. Blink removed this attribute in 2014: chromium/chromium@46d5f25 * LayoutTests/fast/dom/HTMLHtmlElement/html-element-manifest-expected.txt: Added. * LayoutTests/fast/dom/HTMLHtmlElement/html-element-manifest.html: Added. * LayoutTests/fast/dom/URL-attribute-reflection-expected.txt: * LayoutTests/fast/dom/URL-attribute-reflection.html: * Source/WebCore/html/HTMLHtmlElement.idl: Canonical link: https://commits.webkit.org/253053@main
WebKit · Aug 2, 2022 · 332debf · 332debf
1 parent 4b895d0
commit 332debf
Show file tree

Hide file tree

Showing 5 changed files with 20 additions and 3 deletions.
diff --git a/LayoutTests/fast/dom/HTMLHtmlElement/html-element-manifest-expected.txt b/LayoutTests/fast/dom/HTMLHtmlElement/html-element-manifest-expected.txt
@@ -0,0 +1,10 @@
+This tests that manifest IDL attribute does not exist on html element
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS "manifest" in document.documentElement is false
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
diff --git a/LayoutTests/fast/dom/HTMLHtmlElement/html-element-manifest.html b/LayoutTests/fast/dom/HTMLHtmlElement/html-element-manifest.html
@@ -0,0 +1,10 @@
+<!DOCTYPE html>
+<html>
+<body>
+<script src="../../../resources/js-test.js"></script>
+<script>
+description('This tests that manifest IDL attribute does not exist on html element');
+shouldBeFalse('"manifest" in document.documentElement');
+</script>
+</body>
+</html>
diff --git a/LayoutTests/fast/dom/URL-attribute-reflection-expected.txt b/LayoutTests/fast/dom/URL-attribute-reflection-expected.txt
@@ -18,7 +18,6 @@ PASS testURLReflection('href', 'area') is 'URL'
 PASS testURLReflection('href', 'link') is 'URL'
 PASS testURLReflection('href', 'base') is 'URL'
 FAIL testURLReflection('icon', 'command') should be URL. Was none.
-PASS testURLReflection('manifest', 'html') is 'URL'
 PASS testURLReflection('poster', 'video') is 'URL'
 PASS testURLReflection('src', 'audio') is 'URL'
 PASS testURLReflection('src', 'embed') is 'URL'

diff --git a/LayoutTests/fast/dom/URL-attribute-reflection.html b/LayoutTests/fast/dom/URL-attribute-reflection.html
@@ -58,7 +58,6 @@
 shouldBe("testURLReflection('href', 'link')", "'URL'");
 shouldBe("testURLReflection('href', 'base')", "'URL'");
 shouldBe("testURLReflection('icon', 'command')", "'URL'");
-shouldBe("testURLReflection('manifest', 'html')", "'URL'");
 shouldBe("testURLReflection('poster', 'video')", "'URL'");
 shouldBe("testURLReflection('src', 'audio')", "'URL'");
 shouldBe("testURLReflection('src', 'embed')", "'URL'");

diff --git a/Source/WebCore/html/HTMLHtmlElement.idl b/Source/WebCore/html/HTMLHtmlElement.idl
@@ -21,6 +21,5 @@
     Exposed=Window
 ] interface HTMLHtmlElement : HTMLElement {
     [CEReactions=NotNeeded, Reflect] attribute DOMString version;
-    [Reflect, URL] attribute DOMString manifest;
 };