Skip to content


Browse files Browse the repository at this point in the history
<html> element should not have 'manifest' IDL attribute

Reviewed by Chris Dumez.

Removed manifest IDL attribute from the html element.

Blink removed this attribute in 2014:

* LayoutTests/fast/dom/HTMLHtmlElement/html-element-manifest-expected.txt: Added.
* LayoutTests/fast/dom/HTMLHtmlElement/html-element-manifest.html: Added.
* LayoutTests/fast/dom/URL-attribute-reflection-expected.txt:
* LayoutTests/fast/dom/URL-attribute-reflection.html:
* Source/WebCore/html/HTMLHtmlElement.idl:

Canonical link:
  • Loading branch information
rniwa committed Aug 2, 2022
1 parent 4b895d0 commit 332debf
Show file tree
Hide file tree
Showing 5 changed files with 20 additions and 3 deletions.
@@ -0,0 +1,10 @@
This tests that manifest IDL attribute does not exist on html element

On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".

PASS "manifest" in document.documentElement is false
PASS successfullyParsed is true


10 changes: 10 additions & 0 deletions LayoutTests/fast/dom/HTMLHtmlElement/html-element-manifest.html
@@ -0,0 +1,10 @@
<!DOCTYPE html>
<script src="../../../resources/js-test.js"></script>
description('This tests that manifest IDL attribute does not exist on html element');
shouldBeFalse('"manifest" in document.documentElement');
1 change: 0 additions & 1 deletion LayoutTests/fast/dom/URL-attribute-reflection-expected.txt
Expand Up @@ -18,7 +18,6 @@ PASS testURLReflection('href', 'area') is 'URL'
PASS testURLReflection('href', 'link') is 'URL'
PASS testURLReflection('href', 'base') is 'URL'
FAIL testURLReflection('icon', 'command') should be URL. Was none.
PASS testURLReflection('manifest', 'html') is 'URL'
PASS testURLReflection('poster', 'video') is 'URL'
PASS testURLReflection('src', 'audio') is 'URL'
PASS testURLReflection('src', 'embed') is 'URL'
Expand Down
1 change: 0 additions & 1 deletion LayoutTests/fast/dom/URL-attribute-reflection.html
Expand Up @@ -58,7 +58,6 @@
shouldBe("testURLReflection('href', 'link')", "'URL'");
shouldBe("testURLReflection('href', 'base')", "'URL'");
shouldBe("testURLReflection('icon', 'command')", "'URL'");
shouldBe("testURLReflection('manifest', 'html')", "'URL'");
shouldBe("testURLReflection('poster', 'video')", "'URL'");
shouldBe("testURLReflection('src', 'audio')", "'URL'");
shouldBe("testURLReflection('src', 'embed')", "'URL'");
Expand Down
1 change: 0 additions & 1 deletion Source/WebCore/html/HTMLHtmlElement.idl
Expand Up @@ -21,6 +21,5 @@
] interface HTMLHtmlElement : HTMLElement {
[CEReactions=NotNeeded, Reflect] attribute DOMString version;
[Reflect, URL] attribute DOMString manifest;

0 comments on commit 332debf

Please sign in to comment.