Skip to content
Permalink
Browse files
Move common bindings files to unified sources
https://bugs.webkit.org/show_bug.cgi?id=178561

Rubber-stamped by Ryosuke Niwa.

This patch moves most of the common bindings files to unified sources.

Additionally, it adds a change to make_names to unique a struct
name that caused name conflicts that I missed when I made the
source changes before.

Lastly, add missing reference to WebCoreJSBuiltins.cpp in CMake build.

No new behavior no tests.

* CMakeLists.txt:
* Sources.txt:
* WebCore.xcodeproj/project.pbxproj:
* dom/make_names.pl:
(printFactoryCppFile):


Canonical link: https://commits.webkit.org/194759@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@223747 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
kmiller68 committed Oct 20, 2017
1 parent 46c20b7 commit 33b5377b63e5a1098d57ff93a685e8fb0be64ef1
Showing with 1,371 additions and 1,550 deletions.
  1. +7 −4 Source/WebCore/CMakeLists.txt
  2. +23 −0 Source/WebCore/ChangeLog
  3. +873 −0 Source/WebCore/Sources.txt
  4. +457 −1,535 Source/WebCore/WebCore.xcodeproj/project.pbxproj
  5. +11 −11 Source/WebCore/dom/make_names.pl
@@ -3986,16 +3986,19 @@ foreach (_builtinSource ${WebCore_BUILTINS_SOURCES})
endforeach ()

add_custom_command(
OUTPUT ${DERIVED_SOURCES_WEBCORE_DIR}/WebCoreJSBuiltinInternals.cpp
OUTPUT ${DERIVED_SOURCES_WEBCORE_DIR}/WebCoreJSBuiltins.cpp
${DERIVED_SOURCES_WEBCORE_DIR}/WebCoreJSBuiltinInternals.cpp
${DERIVED_SOURCES_WEBCORE_DIR}/WebCoreJSBuiltins.h
${DERIVED_SOURCES_WEBCORE_DIR}/WebCoreJSBuiltinInternals.h
MAIN_DEPENDENCY ${WebCore_BUILTINS_SOURCES}
DEPENDS ${BUILTINS_GENERATOR_SCRIPTS} ${WebCore_DERIVED_BUILTIN_HEADERS}
COMMAND ${PYTHON_EXECUTABLE} ${JavaScriptCore_SCRIPTS_DIR}/generate-js-builtins.py --wrappers-only --framework WebCore --output-directory ${DERIVED_SOURCES_WEBCORE_DIR} ${WebCore_BUILTINS_SOURCES}
VERBATIM)
list(APPEND WebCore_DERIVED_SOURCES ${DERIVED_SOURCES_WEBCORE_DIR}/WebCoreJSBuiltinInternals.cpp)
list(APPEND WebCore_DERIVED_SOURCES ${DERIVED_SOURCES_WEBCORE_DIR}/WebCoreJSBuiltins.h)
list(APPEND WebCore_DERIVED_SOURCES ${DERIVED_SOURCES_WEBCORE_DIR}/WebCoreJSBuiltinInternals.h)
list(APPEND WebCore_DERIVED_SOURCES
${DERIVED_SOURCES_WEBCORE_DIR}/WebCoreJSBuiltins.cpp
${DERIVED_SOURCES_WEBCORE_DIR}/WebCoreJSBuiltinInternals.cpp
${DERIVED_SOURCES_WEBCORE_DIR}/WebCoreJSBuiltins.h
${DERIVED_SOURCES_WEBCORE_DIR}/WebCoreJSBuiltinInternals.h)

ADD_SOURCE_WEBCORE_DERIVED_DEPENDENCIES(${WEBCORE_DIR}/html/HTMLTreeBuilder.cpp MathMLNames.cpp)

@@ -1,3 +1,26 @@
2017-10-20 Keith Miller <keith_miller@apple.com>

Move common bindings files to unified sources
https://bugs.webkit.org/show_bug.cgi?id=178561

Rubber-stamped by Ryosuke Niwa.

This patch moves most of the common bindings files to unified sources.

Additionally, it adds a change to make_names to unique a struct
name that caused name conflicts that I missed when I made the
source changes before.

Lastly, add missing reference to WebCoreJSBuiltins.cpp in CMake build.

No new behavior no tests.

* CMakeLists.txt:
* Sources.txt:
* WebCore.xcodeproj/project.pbxproj:
* dom/make_names.pl:
(printFactoryCppFile):

2017-10-20 Saam Barati <sbarati@apple.com>

Optimize accesses to how we get the direct prototype

0 comments on commit 33b5377

Please sign in to comment.