Skip to content
Permalink
Browse files
prepare-ChangeLog: Fix some warning messages when using svn
<http://webkit.org/b/151914>

Reviewed by Daniel Bates.

* Scripts/prepare-ChangeLog:
(generateFunctionLists): Simplify logic so that we never call
normalizePath() with an undefined value.
(attributeCommand): Quote $subPath for the shell so that we
don't try to run "svn propget" on invalid paths.


Canonical link: https://commits.webkit.org/170046@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@193514 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
ddkilzer committed Dec 5, 2015
1 parent d9b4ed6 commit 3445611ae95a680147e013f828c50034bb54d3a6
Showing with 15 additions and 3 deletions.
  1. +13 −0 Tools/ChangeLog
  2. +2 −3 Tools/Scripts/prepare-ChangeLog
@@ -1,3 +1,16 @@
2015-12-05 David Kilzer <ddkilzer@apple.com>

prepare-ChangeLog: Fix some warning messages when using svn
<http://webkit.org/b/151914>

Reviewed by Daniel Bates.

* Scripts/prepare-ChangeLog:
(generateFunctionLists): Simplify logic so that we never call
normalizePath() with an undefined value.
(attributeCommand): Quote $subPath for the shell so that we
don't try to run "svn propget" on invalid paths.

2015-12-04 David Kilzer <ddkilzer@apple.com>

TestNetscapePlugIn: Fix remaining static analyzer warnings
@@ -285,8 +285,7 @@ sub generateFunctionLists($$$$$)
my $file;
open DIFF, "-|", diffCommand($changedFiles, $gitCommit, $gitIndex, $mergeBase) or die "The diff failed: $!.\n";
while (<DIFF>) {
$file = makeFilePathRelative($1) if $_ =~ diffHeaderFormat();
$file = normalizePath($file);
$file = normalizePath(makeFilePathRelative($1)) if $_ =~ diffHeaderFormat();
if (defined $file) {
my ($before_start, $before_end) = extractLineRangeBeforeChange($_);
if ($before_start >= 1 && $before_end >= 1) {
@@ -1961,7 +1960,7 @@ sub attributeCommand($$)
$foundAttribute = 1;
next;
}
my $command = SVN . " propget $attr $subPath";
my $command = SVN . " propget $attr '$subPath'";
my $attrib = $attributeCache{$attr}{$subPath} || `$command`;
chomp $attrib;
if ($attrib eq "1") {

0 comments on commit 3445611

Please sign in to comment.