Skip to content
Permalink
Browse files
Web Inspector: Right-clicking in Snapshot's DataGrid throws an exception
https://bugs.webkit.org/show_bug.cgi?id=157934
<rdar://problem/26380910>

Reviewed by Brian Burg.

Check that click event target is actually a cell, as it can be a row
when focusing the table after dismissing a popup menu.

* UserInterface/Views/DataGrid.js:
(WebInspector.DataGridNode.prototype.isEventWithinDisclosureTriangle):


Canonical link: https://commits.webkit.org/176299@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@201499 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
LuckyKobold committed May 30, 2016
1 parent f81e963 commit 34f0831bff17c8341097365ab2c4e0141c6bb4e0
Showing with 15 additions and 1 deletion.
  1. +14 −0 Source/WebInspectorUI/ChangeLog
  2. +1 −1 Source/WebInspectorUI/UserInterface/Views/DataGrid.js
@@ -1,3 +1,17 @@
2016-05-30 Matt Baker <mattbaker@apple.com>

Web Inspector: Right-clicking in Snapshot's DataGrid throws an exception
https://bugs.webkit.org/show_bug.cgi?id=157934
<rdar://problem/26380910>

Reviewed by Brian Burg.

Check that click event target is actually a cell, as it can be a row
when focusing the table after dismissing a popup menu.

* UserInterface/Views/DataGrid.js:
(WebInspector.DataGridNode.prototype.isEventWithinDisclosureTriangle):

2016-05-27 Joseph Pecoraro <pecoraro@apple.com>

Web Inspector: Not all transitively dominated nodes display their retained size
@@ -2466,7 +2466,7 @@ WebInspector.DataGridNode = class DataGridNode extends WebInspector.Object
if (!this.hasChildren)
return false;
let cell = event.target.enclosingNodeOrSelfWithNodeName("td");
if (!cell.classList.contains("disclosure"))
if (!cell || !cell.classList.contains("disclosure"))
return false;

let computedLeftPadding = window.getComputedStyle(cell).getPropertyCSSValue("padding-left").getFloatValue(CSSPrimitiveValue.CSS_PX);

0 comments on commit 34f0831

Please sign in to comment.