Skip to content
Permalink
Browse files
Web Inspector: Fonts details sidebar in Elements tab has empty space …
…for filter bar

https://bugs.webkit.org/show_bug.cgi?id=241817
rdar://problem/95634156

Reviewed by Devin Rousso.

As pointed out by Devin, passing undefined to `toggle` here acts as if we didn't pass a value, not as a falsy value.

* Source/WebInspectorUI/UserInterface/Views/GeneralStyleDetailsSidebarPanel.js:
(WI.GeneralStyleDetailsSidebarPanel.prototype._showPanel):

Canonical link: https://commits.webkit.org/251704@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@295699 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
patrickangle committed Jun 21, 2022
1 parent b91d6ad commit 35d7fb239e570e8ecb3b63fb0fe8dd6925bc6988
Showing 1 changed file with 1 addition and 1 deletion.
@@ -213,7 +213,7 @@ WI.GeneralStyleDetailsSidebarPanel = class GeneralStyleDetailsSidebarPanel exten
_showPanel()
{
this.contentView.addSubview(this._panel);
this.contentView.element.classList.toggle("has-filter-bar", this._filterBar);
this.contentView.element.classList.toggle("has-filter-bar", !!this._filterBar);
if (this._filterBar)
this.contentView.element.classList.toggle(WI.GeneralStyleDetailsSidebarPanel.FilterInProgressClassName, this._filterBar.hasActiveFilters());
}

0 comments on commit 35d7fb2

Please sign in to comment.