Skip to content
Permalink
Browse files
[iOS] Conditionally rename DatabaseProcess to StorageProcess when bui…
…lding for iOS devices

https://bugs.webkit.org/show_bug.cgi?id=178181
<rdar://problem/33660282>

Reviewed by Dan Bernstein.

Source/WebKit:

* Configurations/BaseTarget.xcconfig:
* UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::serviceName):
* WebKit.xcodeproj/project.pbxproj:

Tools:

* WebKitTestRunner/TestController.cpp:
(WTR::TestController::databaseProcessName):

Canonical link: https://commits.webkit.org/194734@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@223719 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
aestes committed Oct 19, 2017
1 parent 32ff942 commit 36e110f56cc419433eff127a5bd12ad15331ecf6
Showing 5 changed files with 41 additions and 7 deletions.
@@ -1,3 +1,16 @@
2017-10-19 Andy Estes <aestes@apple.com>

[iOS] Conditionally rename DatabaseProcess to StorageProcess when building for iOS devices
https://bugs.webkit.org/show_bug.cgi?id=178181
<rdar://problem/33660282>

Reviewed by Dan Bernstein.

* Configurations/BaseTarget.xcconfig:
* UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::serviceName):
* WebKit.xcodeproj/project.pbxproj:

2017-10-19 Youenn Fablet <youenn@apple.com>

Add preliminary support for ServiceWorker Handle Fetch
@@ -106,6 +106,12 @@ WK_HAVE_CORE_PREDICTION[sdk=macosx*][arch=i386] = NO;
WK_CORE_PREDICTION_DEFINES = $(WK_CORE_PREDICTION_DEFINES_$(WK_HAVE_CORE_PREDICTION));
WK_CORE_PREDICTION_DEFINES_YES = HAVE_CORE_PREDICTION;

WK_STORAGE_SERVICE_PRODUCT_NAME = com.apple.WebKit.Databases;
WK_STORAGE_SERVICE_PRODUCT_NAME[sdk=macosx*] = com.apple.WebKit.Storage;
WK_STORAGE_SERVICE_PRODUCT_NAME[sdk=*simulator*] = com.apple.WebKit.Storage;
WK_STORAGE_SERVICE_PRODUCT_NAME = $(WK_STORAGE_SERVICE_PRODUCT_NAME_$(WK_USE_LEGACY_STORAGE_SERVICE_NAME));
WK_STORAGE_SERVICE_PRODUCT_NAME_ = $(WK_STORAGE_SERVICE_PRODUCT_NAME_NO);
WK_STORAGE_SERVICE_PRODUCT_NAME_NO = com.apple.WebKit.Storage;
WK_STORAGE_SERVICE_PRODUCT_NAME_YES = com.apple.WebKit.Databases;

WK_USE_LEGACY_STORAGE_SERVICE_NAME[sdk=iphoneos11*] = $(WK_USE_LEGACY_STORAGE_SERVICE_NAME_11$(IPHONEOS_DEPLOYMENT_TARGET:suffix:identifier));
WK_USE_LEGACY_STORAGE_SERVICE_NAME_11_0 = YES;
WK_USE_LEGACY_STORAGE_SERVICE_NAME_11_1 = YES;
WK_USE_LEGACY_STORAGE_SERVICE_NAME_11_2 = YES;
@@ -56,10 +56,10 @@
case ProcessLauncher::ProcessType::Network:
return "com.apple.WebKit.Networking";
case ProcessLauncher::ProcessType::Storage:
#if PLATFORM(MAC) || PLATFORM(IOS_SIMULATOR)
return "com.apple.WebKit.Storage";
#else
#if PLATFORM(IOS) && !PLATFORM(WATCHOS) && !PLATFORM(APPLETV) && !PLATFORM(IOS_SIMULATOR) && __IPHONE_OS_VERSION_MIN_REQUIRED < 110300
return "com.apple.WebKit.Databases";
#else
return "com.apple.WebKit.Storage";
#endif
#if ENABLE(NETSCAPE_PLUGIN_API)
case ProcessLauncher::ProcessType::Plugin32:
@@ -69,7 +69,7 @@
#endif
}
}

static bool shouldLeakBoost(const ProcessLauncher::LaunchOptions& launchOptions)
{
#if PLATFORM(IOS)
@@ -1,3 +1,14 @@
2017-10-19 Andy Estes <aestes@apple.com>

[iOS] Conditionally rename DatabaseProcess to StorageProcess when building for iOS devices
https://bugs.webkit.org/show_bug.cgi?id=178181
<rdar://problem/33660282>

Reviewed by Dan Bernstein.

* WebKitTestRunner/TestController.cpp:
(WTR::TestController::databaseProcessName):

2017-10-19 Saam Barati <sbarati@apple.com>

Turn poly proto back on by default and remove the option
@@ -908,7 +908,11 @@ const char* TestController::databaseProcessName()
{
// FIXME: Find a way to not hardcode the process name.
#if PLATFORM(IOS) && !PLATFORM(IOS_SIMULATOR)
#if !PLATFORM(WATCHOS) && !PLATFORM(APPLETV) && __IPHONE_OS_VERSION_MIN_REQUIRED < 110300
return "com.apple.WebKit.Databases";
#else
return "com.apple.WebKit.Storage";
#endif
#elif PLATFORM(COCOA)
return "com.apple.WebKit.Storage.Development";
#else

0 comments on commit 36e110f

Please sign in to comment.