Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
[Chromium-Android] Upstream layout test expectations (Part 2) 
https://bugs.webkit.org/show_bug.cgi?id=95212

Reviewed by Adam Barth.

Tools:

- Now run both gpu path and non-gpu path of 2d canvas layout tests
because both are used in chromium-android.

- Exclude all webgl tests because webgl is not enabled yet.

- Removed 'win' from the baseline fallback list. This was a mistake.

- Moved some small directories to TestExpectations from skipped_layout_tests().

* Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidPort):
(ChromiumAndroidPort.skipped_layout_tests):

LayoutTests:

Update test expectations for Android:
- 2d canvas tests (both gpu and non-gpu path)
- compositing tests
- more WONTFIXes for control behavior tests
- skip features not enabled on Android

* platform/chromium/TestExpectations:


Canonical link: https://commits.webkit.org/113117@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126942 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
@wangxianzhu
wangxianzhu committed Aug 29, 2012
1 parent 4d109b1 commit 3786887
Show file tree
Hide file tree
Showing 4 changed files with 112 additions and 39 deletions.
15 changes: 15 additions & 0 deletions LayoutTests/ChangeLog
View file
@@ -1,3 +1,18 @@
2012-08-28 Xianzhu Wang <wangxianzhu@chromium.org>

[Chromium-Android] Upstream layout test expectations (Part 2)
https://bugs.webkit.org/show_bug.cgi?id=95212

Reviewed by Adam Barth.

Update test expectations for Android:
- 2d canvas tests (both gpu and non-gpu path)
- compositing tests
- more WONTFIXes for control behavior tests
- skip features not enabled on Android

* platform/chromium/TestExpectations:

2012-08-28 Joanmarie Diggs <jdiggs@igalia.com>

Implement AccessibilityUIElement::titleUIElement() and AccessibilityUIElement::stringValue()
Expand Down
92 changes: 67 additions & 25 deletions LayoutTests/platform/chromium/TestExpectations
View file
Expand Up @@ -872,15 +872,43 @@ WONTFIX SKIP : fast/js/document-all-between-frames.html = TEXT
// Chromium doesn't use fullscreen-specific media controls
WONTFIX SKIP : media/video-controls-fullscreen-volume.html = TEXT

// ENABLE(INPUT_TYPE_TIME_MULTIPLE_FIELDS) isn't enabled for Android (WK94186).
WONTFIX SKIP ANDROID : fast/forms/time-multiple-fields = PASS

// Test fails because it's trying to load a plugin we don't have. We probably don't need to fix this.
WONTFIX : platform/gtk/plugins/invalidate-rect-with-null-npp-argument.html = TEXT

// This test is only for GTK which is not applicable to Android.
WONTFIX ANDROID SKIP : platform/chromium-linux/fast/text/chromium-linux-fontconfig-renderstyle.html = TEXT

// The following features are not enabled on Android.
// Some bigger whole directories (plugins, webgl, inspector, etc.) are skipped in chromium_android.py.
BUGCR145338 WONTFIX ANDROID SKIP : fast/forms/time-multiple-fields = PASS
BUGCR145338 WONTFIX ANDROID SKIP : fast/forms/color = PASS
BUGCR145338 WONTFIX ANDROID SKIP : fast/forms/datalist = PASS
BUGCR145338 WONTFIX ANDROID SKIP : fast/forms/date = PASS
BUGCR145338 WONTFIX ANDROID SKIP : fast/mediastream = PASS
BUGCR145338 WONTFIX ANDROID SKIP : fast/notifications = PASS
BUGCR145338 WONTFIX ANDROID SKIP : fast/speech = PASS
BUGCR145338 WONTFIX ANDROID SKIP : webaudio = PASS

// Skip tests depending on plugins that is not available on Android.
// The whole directories of plugins, http/tests/plugins, etc. are skipped in chromium_android.py.
BUGCR145338 WONTFIX ANDROID SKIP : fast/dom/Window/Plug-ins.html = PASS
BUGCR145338 WONTFIX ANDROID SKIP : fast/frames/sandboxed-iframe-about-blank.html = PASS
BUGCR145338 WONTFIX ANDROID SKIP : fast/frames/sandboxed-iframe-navigation-allowed.html = PASS
BUGCR145338 WONTFIX ANDROID SKIP : fast/frames/sandboxed-iframe-plugins.html = PASS
BUGCR145338 WONTFIX ANDROID SKIP : fast/replaced/invalid-object-with-fallback.html = PASS
BUGCR145338 WONTFIX ANDROID SKIP : fast/replaced/object-with-embed-url-param.html = PASS
BUGCR145338 WONTFIX ANDROID SKIP : http/tests/security/contentSecurityPolicy/1.1/plugintypes-invalid.html = PASS
BUGCR145338 WONTFIX ANDROID SKIP : http/tests/security/contentSecurityPolicy/1.1/plugintypes-mismatched-data.html = PASS
BUGCR145338 WONTFIX ANDROID SKIP : http/tests/security/contentSecurityPolicy/1.1/plugintypes-mismatched-url.html = PASS
BUGCR145338 WONTFIX ANDROID SKIP : http/tests/security/contentSecurityPolicy/1.1/plugintypes-notype-url.html = PASS
BUGCR145338 WONTFIX ANDROID SKIP : http/tests/security/contentSecurityPolicy/1.1/plugintypes-url-01.html = PASS
BUGCR145338 WONTFIX ANDROID SKIP : http/tests/security/contentSecurityPolicy/object-src-none-allowed.html = PASS
BUGCR145338 WONTFIX ANDROID SKIP : http/tests/security/contentSecurityPolicy/object-src-url-allowed.html = PASS
BUGCR145338 WONTFIX ANDROID SKIP : http/tests/security/contentSecurityPolicy/object-src-url-blocked.html = PASS
BUGCR145338 WONTFIX ANDROID SKIP : http/tests/security/frameNavigation/xss-DENIED-plugin-navigation.html = PASS
BUGCR145338 WONTFIX ANDROID SKIP : platform/chromium/permissionclient/plugin-permission.html = PASS
BUGCR145338 WONTFIX ANDROID SKIP : userscripts/user-script-plugin-document.html = PASS

// -----------------------------------------------------------------
// TESTS TO FIX
// -----------------------------------------------------------------
Expand Down Expand Up @@ -1384,7 +1412,7 @@ BUGWK73912 : accessibility/aria-checkbox-sends-notification.html = TEXT PASS
WONTFIX : platform/chromium/virtual/gpu/canvas/philip/tests/2d.shadow.blur.low.html = PASS TIMEOUT

// This test is overly-finicky about pixel values.
BUGWK64876 LINUX ANDROID WIN : platform/chromium/virtual/gpu/fast/canvas/canvas-scale-strokePath-shadow.html = TEXT
BUGWK64876 LINUX WIN : platform/chromium/virtual/gpu/fast/canvas/canvas-scale-strokePath-shadow.html = TEXT

BUGWK75276 : fast/repaint/shadow-multiple-horizontal.html = IMAGE
BUGWK75276 : fast/repaint/shadow-multiple-strict-horizontal.html = IMAGE
Expand Down Expand Up @@ -1838,8 +1866,8 @@ BUGWK94246 : platform/chromium/virtual/gpu/fast/canvas/canvas-ImageData-behaviou

BUGWK45991 : canvas/philip/tests/2d.pattern.image.broken.html = TEXT
BUGWK45991 : platform/chromium/virtual/gpu/canvas/philip/tests/2d.pattern.image.broken.html = TEXT
BUGWK45991 LINUX WIN : canvas/philip/tests/2d.text.draw.baseline.ideographic.html = TEXT
BUGWK45991 LINUX ANDROID WIN : platform/chromium/virtual/gpu/canvas/philip/tests/2d.text.draw.baseline.ideographic.html = TEXT
BUGWK45991 LINUX ANDROID WIN : canvas/philip/tests/2d.text.draw.baseline.ideographic.html = TEXT
BUGWK45991 LINUX WIN : platform/chromium/virtual/gpu/canvas/philip/tests/2d.text.draw.baseline.ideographic.html = TEXT

// Update canvas/philip in WK r71481
BUGCR62301 : canvas/philip/tests/2d.drawImage.image.incomplete.omitted.html = TEXT
Expand Down Expand Up @@ -1882,21 +1910,21 @@ BUGWK45991 : canvas/philip/tests/2d.text.measure.width.space.html = TEXT
BUGWK45991 : platform/chromium/virtual/gpu/canvas/philip/tests/2d.text.measure.width.space.html = TEXT

// These tests fail everywhere we use skia and are most likely skia bugs
BUGWK45991 LINUX WIN : canvas/philip/tests/2d.gradient.radial.outside3.html = TEXT
BUGWK45991 LINUX WIN : canvas/philip/tests/2d.path.arc.angle.3.html = TEXT
BUGWK45991 LINUX WIN : canvas/philip/tests/2d.path.arc.angle.5.html = TEXT
BUGWK45991 LINUX WIN : canvas/philip/tests/2d.path.arcTo.shape.curve1.html = TEXT
BUGWK45991 LINUX WIN : canvas/philip/tests/2d.path.arcTo.shape.curve2.html = TEXT
BUGWK45991 LINUX WIN : canvas/philip/tests/2d.pattern.paint.norepeat.coord3.html = TEXT
BUGWK45991 LINUX WIN : canvas/philip/tests/2d.pattern.paint.repeatx.coord1.html = TEXT
BUGWK45991 LINUX WIN : canvas/philip/tests/2d.pattern.paint.repeaty.coord1.html = TEXT
BUGWK45991 LINUX WIN : canvas/philip/tests/2d.shadow.enable.blur.html = TEXT
BUGWK45991 LINUX ANDROID WIN : platform/chromium/virtual/gpu/canvas/philip/tests/2d.gradient.radial.outside3.html = TEXT
BUGWK45991 LINUX ANDROID WIN : platform/chromium/virtual/gpu/canvas/philip/tests/2d.path.arc.angle.3.html = TEXT
BUGWK45991 LINUX ANDROID WIN : platform/chromium/virtual/gpu/canvas/philip/tests/2d.path.arc.angle.5.html = TEXT
BUGWK45991 LINUX ANDROID WIN : platform/chromium/virtual/gpu/canvas/philip/tests/2d.pattern.paint.norepeat.coord3.html = TEXT
BUGWK45991 LINUX ANDROID WIN : platform/chromium/virtual/gpu/canvas/philip/tests/2d.pattern.paint.repeatx.coord1.html = TEXT
BUGWK45991 LINUX ANDROID WIN : platform/chromium/virtual/gpu/canvas/philip/tests/2d.pattern.paint.repeaty.coord1.html = TEXT
BUGWK45991 LINUX ANDROID WIN : canvas/philip/tests/2d.gradient.radial.outside3.html = TEXT
BUGWK45991 LINUX ANDROID WIN : canvas/philip/tests/2d.path.arc.angle.3.html = TEXT
BUGWK45991 LINUX ANDROID WIN : canvas/philip/tests/2d.path.arc.angle.5.html = TEXT
BUGWK45991 LINUX ANDROID WIN : canvas/philip/tests/2d.path.arcTo.shape.curve1.html = TEXT
BUGWK45991 LINUX ANDROID WIN : canvas/philip/tests/2d.path.arcTo.shape.curve2.html = TEXT
BUGWK45991 LINUX ANDROID WIN : canvas/philip/tests/2d.pattern.paint.norepeat.coord3.html = TEXT
BUGWK45991 LINUX ANDROID WIN : canvas/philip/tests/2d.pattern.paint.repeatx.coord1.html = TEXT
BUGWK45991 LINUX ANDROID WIN : canvas/philip/tests/2d.pattern.paint.repeaty.coord1.html = TEXT
BUGWK45991 LINUX ANDROID WIN : canvas/philip/tests/2d.shadow.enable.blur.html = TEXT
BUGWK45991 LINUX WIN : platform/chromium/virtual/gpu/canvas/philip/tests/2d.gradient.radial.outside3.html = TEXT
BUGWK45991 LINUX WIN : platform/chromium/virtual/gpu/canvas/philip/tests/2d.path.arc.angle.3.html = TEXT
BUGWK45991 LINUX WIN : platform/chromium/virtual/gpu/canvas/philip/tests/2d.path.arc.angle.5.html = TEXT
BUGWK45991 LINUX WIN : platform/chromium/virtual/gpu/canvas/philip/tests/2d.pattern.paint.norepeat.coord3.html = TEXT
BUGWK45991 LINUX WIN : platform/chromium/virtual/gpu/canvas/philip/tests/2d.pattern.paint.repeatx.coord1.html = TEXT
BUGWK45991 LINUX WIN : platform/chromium/virtual/gpu/canvas/philip/tests/2d.pattern.paint.repeaty.coord1.html = TEXT

// Chromium does not support cancel for notifications permissions.
BUGWK42798 SKIP : fast/notifications/notifications-cancel-request-permission.html = PASS
Expand Down Expand Up @@ -2000,7 +2028,7 @@ BUGWK91431 : platform/chromium/virtual/gpu/fast/canvas/webgl/framebuffer-object-
BUGWK91431 : platform/chromium/virtual/gpu/fast/canvas/webgl/gl-uniform-arrays.html = TEXT
BUGWK91431 : platform/chromium/virtual/gpu/fast/canvas/webgl/point-size.html = TEXT
BUGWK91431 LINUX MAC : fast/canvas/webgl/gl-object-get-calls.html = TEXT
BUGWK91431 LINUX ANDROID MAC : platform/chromium/virtual/gpu/fast/canvas/webgl/gl-object-get-calls.html = TEXT
BUGWK91431 LINUX MAC : platform/chromium/virtual/gpu/fast/canvas/webgl/gl-object-get-calls.html = TEXT

// These were not fixed by the Mesa 7.9 upgrade. Need to investigate.
BUGCR60651 WIN : fast/canvas/webgl/gl-object-get-calls.html = PASS TIMEOUT TEXT
Expand Down Expand Up @@ -2168,7 +2196,7 @@ BUGCR67540 LINUX ANDROID WIN SNOWLEOPARD : fast/repaint/text-emphasis-h.html = I
BUGCR67540 LINUX ANDROID : fast/repaint/text-emphasis-v.html = IMAGE

BUGCR67442 LINUX WIN : fast/canvas/fillText-shadow.html = TEXT
BUGCR67442 LINUX ANDROID WIN : platform/chromium/virtual/gpu/fast/canvas/fillText-shadow.html = TEXT
BUGCR67442 LINUX WIN : platform/chromium/virtual/gpu/fast/canvas/fillText-shadow.html = TEXT

BUGCR68436 LINUX ANDROID DEBUG : fast/dom/DOMImplementation/createDocument-with-used-doctype.html = PASS TIMEOUT
BUGCR68436 MAC WIN DEBUG : fast/dom/DOMImplementation/createDocument-with-used-doctype.html = TIMEOUT TEXT
Expand Down Expand Up @@ -3102,7 +3130,7 @@ BUGWK85951 WIN DEBUG : fast/css/hover-update.html = TEXT PASS
BUGWK85958 : fast/forms/file/file-input-capture.html = TEXT

// Started flaking at around http://trac.webkit.org/changeset/116278.
BUGWK85950 LINUX ANDROID DEBUG : compositing/geometry/limit-layer-bounds-transformed-overflow.html = PASS TEXT
BUGWK85950 LINUX DEBUG : compositing/geometry/limit-layer-bounds-transformed-overflow.html = PASS TEXT

BUGWK81416 : fast/dom/wrapper-scope.html = TEXT

Expand Down Expand Up @@ -3189,7 +3217,7 @@ BUGWK91489 : fast/dom/shadow/shadowdom-for-fieldset-only-shadow.html = IMAGE
BUGWK87652 SKIP : http/tests/appcache/load-from-appcache-defer-resume-crash.html = PASS

// A few pixels off from the baseline, added by r118567.
BUGWK87653 WIN LINUX ANDROID : compositing/geometry/composited-in-columns.html = IMAGE+TEXT
BUGWK87653 WIN LINUX : compositing/geometry/composited-in-columns.html = IMAGE+TEXT

// Fails with a mismatch in $("menulist").selectedIndex
BUGWK87748 MAC : fast/forms/select/optgroup-clicking.html = TEXT
Expand Down Expand Up @@ -3464,13 +3492,17 @@ BUGWK95167 : fast/overflow/paged-x-div-with-column-gap.html = IMAGE IMAGE+TEXT T

BUGWK94793 : fast/notifications/notifications-event-listener-crash.html = TEXT PASS

BUGCR144536 WONTFIX ANDROID : editing/selection/context-menu-on-text.html = TEXT
BUGCR144536 WONTFIX ANDROID : editing/selection/context-menu-text-selection.html = TEXT
BUGCR144536 WONTFIX ANDROID : fast/dom/HTMLSelectElement/select-selectedOptions.html = TEXT
BUGCR144536 WONTFIX ANDROID : fast/events/select-element.html = TEXT
BUGCR144536 WONTFIX ANDROID : fast/forms/listbox-clip.html = TEXT
BUGCR144536 WONTFIX ANDROID : fast/forms/listbox-deselect-scroll.html = TEXT
BUGCR144536 WONTFIX ANDROID : fast/forms/listbox-onchange.html = TEXT
BUGCR144536 WONTFIX ANDROID : fast/forms/listbox-select-all.html = TEXT
BUGCR144536 WONTFIX ANDROID : fast/forms/listbox-selection.html = TEXT
BUGCR144536 WONTFIX ANDROID : fast/forms/listbox-selection-2.html = TEXT
BUGCR144536 WONTFIX ANDROID : fast/forms/listbox-typeahead-scroll.html = TEXT
BUGCR144536 WONTFIX ANDROID : fast/forms/option-mouseevents.html = TEXT
BUGCR144536 WONTFIX ANDROID : fast/forms/select-cache-desynchronization.html = TEXT
BUGCR144536 WONTFIX ANDROID : fast/forms/select-clientheight-large-size.html = TEXT
Expand All @@ -3482,11 +3514,21 @@ BUGCR144536 WONTFIX ANDROID : fast/forms/select-multiple-elements-with-mouse-dra
BUGCR144536 WONTFIX ANDROID : fast/forms/select-multiple-elements-with-mouse-drag.html = TEXT
BUGCR144536 WONTFIX ANDROID : fast/forms/select/listbox-drag-in-non-multiple.html = TEXT
BUGCR144536 WONTFIX ANDROID : fast/forms/select/listbox-in-multi-column.html = TEXT
BUGCR144536 WONTFIX ANDROID : fast/forms/select/option-selecting.html = TEXT
BUGCR144536 WONTFIX ANDROID : fast/forms/select/optgroup-clicking.html = TEXT
BUGCR144536 WONTFIX ANDROID : fast/forms/select/optgroup-rendering.html = TEXT
BUGCR144536 WONTFIX ANDROID : fast/repaint/select-option-background-color.html = TEXT
BUGCR144536 WONTFIX ANDROID : scrollbars/custom-scrollbar-with-incomplete-style.html = TEXT
BUGCR144536 WONTFIX ANDROID : scrollbars/listbox-scrollbar-combinations.html = TEXT

BUGCR145084 ANDROID : platform/chromium/virtual/gpu/canvas/philip = PASS TEXT
BUGCR145084 ANDROID : platform/chromium/virtual/gpu/fast/canvas = PASS TEXT TIMEOUT

BUGCR145087 ANDROID : compositing/geometry/composited-in-columns.html = TEXT
BUGCR145087 ANDROID : compositing/geometry/fixed-position-composited-switch.html = TEXT
BUGCR145087 ANDROID : compositing/overflow/nested-scrolling.html = TEXT
BUGCR145087 ANDROID : compositing/reflections/nested-reflection-animated.html = TEXT PASS

// Require rebaseline after https://bugs.webkit.org/show_bug.cgi?id=84286
BUGWK84286 : editing/deleting/type-delete-after-quote.html = TEXT
BUGWK84286 : editing/execCommand/4580583-1.html = TEXT
Expand Down
20 changes: 20 additions & 0 deletions Tools/ChangeLog
View file
@@ -1,3 +1,23 @@
2012-08-28 Xianzhu Wang <wangxianzhu@chromium.org>

[Chromium-Android] Upstream layout test expectations (Part 2)
https://bugs.webkit.org/show_bug.cgi?id=95212

Reviewed by Adam Barth.

- Now run both gpu path and non-gpu path of 2d canvas layout tests
because both are used in chromium-android.

- Exclude all webgl tests because webgl is not enabled yet.

- Removed 'win' from the baseline fallback list. This was a mistake.

- Moved some small directories to TestExpectations from skipped_layout_tests().

* Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidPort):
(ChromiumAndroidPort.skipped_layout_tests):

2012-08-28 Joanmarie Diggs <jdiggs@igalia.com>

Implement AccessibilityUIElement::titleUIElement() and AccessibilityUIElement::stringValue()
Expand Down
24 changes: 10 additions & 14 deletions Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py
View file
Expand Up @@ -146,7 +146,6 @@ class ChromiumAndroidPort(chromium.ChromiumPort):
'chromium-linux',
'chromium-win',
'chromium',
'win',
'mac',
]

Expand Down Expand Up @@ -234,20 +233,16 @@ def clean_up_test_run(self):
def skipped_layout_tests(self, test_list):
# This method is more convenient to skip whole directories than SKIP in TestExpectations
# because its higher priority.
# Still use TestExpectations to skip individual tests.
return self._real_tests([
# Only run these tests as virtual gpu tests.
'canvas/philip',
'fast/canvas',

# Still use TestExpectations to skip individual tests and small directories.
skipped_tests = self._real_tests([
# Skip tests of other platforms to save time.
'platform/gtk',
'platform/mac',
'platform/mac-wk2',
'platform/qt',
'platform/win',

# Features not supported.
# Features not supported: http://crbug.com/145338.
'compositing/plugins',
'plugins',
'http/tests/plugins',
Expand All @@ -261,14 +256,15 @@ def skipped_layout_tests(self, test_list):

'accessibility',
'platform/chromium/accessibility',

'fast/dom/MediaStream',
'fast/mediastream',
'fast/notifications',
'fast/speech',
'webaudio',
])

# Skip webgl tests: http://crbug.com/135877.
fast_canvas_webgl_tests = self._real_tests(['fast/canvas/webgl'])
return (skipped_tests |
fast_canvas_webgl_tests |
self._real_tests(['http/tests/canvas/webgl']) |
set(['platform/chromium/virtual/gpu/' + f for f in fast_canvas_webgl_tests]))

def create_driver(self, worker_number, no_timeout=False):
# We don't want the default DriverProxy which is not compatible with our driver.
# See comments in ChromiumAndroidDriver.start().
Expand Down

0 comments on commit 3786887

Please sign in to comment.