Dashboard Cleanup: Reload the page as soon as we know we need to.

https://bugs.webkit.org/show_bug.cgi?id=106515

No need to continue parsing all of the data once we know that
we need to do a reload.

Reviewed by Dirk Pranke.

* TestResultServer/static-dashboards/dashboard_base.js:
(parseParameters):


Canonical link: https://commits.webkit.org/124718@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/ChangeLog

@@ -1,3 +1,16 @@
+2013-01-09  Julie Parent  <jparent@chromium.org>
+
+        Dashboard Cleanup: Reload the page as soon as we know we need to.
+        https://bugs.webkit.org/show_bug.cgi?id=106515
+
+        No need to continue parsing all of the data once we know that
+        we need to do a reload.
+
+        Reviewed by Dirk Pranke.
+
+        * TestResultServer/static-dashboards/dashboard_base.js:
+        (parseParameters):
+
 2013-01-09  Eric Seidel  <eric@webkit.org>
 
         run-perf-tests --chromium-android --profile should show symbols for the kernel

Tools/TestResultServer/static-dashboards/dashboard_base.js

@@ -321,6 +321,17 @@ function parseParameters()
     var oldDashboardSpecificState = g_currentState;
 
     parseCrossDashboardParameters();
+
+    // Some parameters require loading different JSON files when the value changes. Do a reload.
+    if (Object.keys(oldCrossDashboardState).length) {
+        for (var key in g_crossDashboardState) {
+            if (oldCrossDashboardState[key] != g_crossDashboardState[key] && RELOAD_REQUIRING_PARAMETERS.indexOf(key) != -1) {
+                window.location.reload();
+                return {};
+            }
+        }
+    }
+
     parseDashboardSpecificParameters();
     parseParameter(queryHashAsMap(), 'builder');
 
@@ -337,14 +348,6 @@ function parseParameters()
     if (g_currentState.tests)
         delete g_currentState.builder;
 
-    // Some parameters require loading different JSON files when the value changes. Do a reload.
-    if (Object.keys(oldCrossDashboardState).length) {
-        for (var key in g_crossDashboardState) {
-            if (oldCrossDashboardState[key] != g_crossDashboardState[key] && RELOAD_REQUIRING_PARAMETERS.indexOf(key) != -1)
-                window.location.reload();
-        }
-    }
-
     return dashboardSpecificDiffState;
 }