Skip to content
Permalink
Browse files
Use "= default" to denote default constructor or destructor
https://bugs.webkit.org/show_bug.cgi?id=178528

Rubber-stamped by Andy Estes.

Source/WebCore:

* Modules/airplay/WebKitPlaybackTargetAvailabilityEvent.h:
* Modules/applepay/ApplePayError.cpp:
* Modules/applepay/ApplePayPaymentAuthorizedEvent.cpp:
* Modules/applepay/ApplePayPaymentMethodSelectedEvent.cpp:
* Modules/applepay/ApplePaySession.cpp:
* Modules/applepay/ApplePaySessionPaymentRequest.cpp:
* Modules/applepay/ApplePayShippingContactSelectedEvent.cpp:
* Modules/applepay/ApplePayShippingMethodSelectedEvent.cpp:
* Modules/applepay/ApplePayValidateMerchantEvent.cpp:
* Modules/applepay/Payment.h:
* Modules/applepay/PaymentCoordinatorClient.h:
* Modules/credentials/BasicCredential.cpp:
* Modules/credentials/FederatedCredential.cpp:
* Modules/credentials/NavigatorCredentials.cpp:
* Modules/credentials/PasswordCredential.cpp:
* Modules/encryptedmedia/CDMClient.h:
* Modules/encryptedmedia/legacy/LegacyCDM.cpp:
* Modules/encryptedmedia/legacy/LegacyCDM.h:
* Modules/encryptedmedia/legacy/LegacyCDMPrivate.h:
* Modules/encryptedmedia/legacy/LegacyCDMPrivateClearKey.h:
* Modules/encryptedmedia/legacy/LegacyCDMPrivateMediaPlayer.h:
* Modules/encryptedmedia/legacy/LegacyCDMSessionClearKey.cpp:
* Modules/encryptedmedia/legacy/WebKitMediaKeyMessageEvent.cpp:
* Modules/encryptedmedia/legacy/WebKitMediaKeyNeededEvent.cpp:
* Modules/entriesapi/DOMFileSystem.cpp:
* Modules/entriesapi/FileSystemDirectoryReader.cpp:
* Modules/entriesapi/FileSystemEntry.cpp:
* Modules/fetch/FetchLoaderClient.h:
* Modules/gamepad/Gamepad.cpp:
* Modules/gamepad/GamepadEvent.h:
* Modules/gamepad/deprecated/Gamepad.cpp:
[ truncated ]

Source/WebCore/PAL:

* pal/Logger.h:
(PAL::Logger::Observer::~Observer): Deleted.
* pal/crypto/gcrypt/CryptoDigestGCrypt.cpp:
* pal/system/SleepDisabler.cpp:
* pal/system/SystemSleepListener.h:

Canonical link: https://commits.webkit.org/194740@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@223728 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
dydz committed Oct 19, 2017
1 parent b85e0f0 commit 3882108127595f69375d3ad344b6b285286268b2
Showing 865 changed files with 1,075 additions and 2,179 deletions.
@@ -1,3 +1,43 @@
2017-10-19 Daniel Bates <dabates@apple.com>

Use "= default" to denote default constructor or destructor
https://bugs.webkit.org/show_bug.cgi?id=178528

Rubber-stamped by Andy Estes.

* Modules/airplay/WebKitPlaybackTargetAvailabilityEvent.h:
* Modules/applepay/ApplePayError.cpp:
* Modules/applepay/ApplePayPaymentAuthorizedEvent.cpp:
* Modules/applepay/ApplePayPaymentMethodSelectedEvent.cpp:
* Modules/applepay/ApplePaySession.cpp:
* Modules/applepay/ApplePaySessionPaymentRequest.cpp:
* Modules/applepay/ApplePayShippingContactSelectedEvent.cpp:
* Modules/applepay/ApplePayShippingMethodSelectedEvent.cpp:
* Modules/applepay/ApplePayValidateMerchantEvent.cpp:
* Modules/applepay/Payment.h:
* Modules/applepay/PaymentCoordinatorClient.h:
* Modules/credentials/BasicCredential.cpp:
* Modules/credentials/FederatedCredential.cpp:
* Modules/credentials/NavigatorCredentials.cpp:
* Modules/credentials/PasswordCredential.cpp:
* Modules/encryptedmedia/CDMClient.h:
* Modules/encryptedmedia/legacy/LegacyCDM.cpp:
* Modules/encryptedmedia/legacy/LegacyCDM.h:
* Modules/encryptedmedia/legacy/LegacyCDMPrivate.h:
* Modules/encryptedmedia/legacy/LegacyCDMPrivateClearKey.h:
* Modules/encryptedmedia/legacy/LegacyCDMPrivateMediaPlayer.h:
* Modules/encryptedmedia/legacy/LegacyCDMSessionClearKey.cpp:
* Modules/encryptedmedia/legacy/WebKitMediaKeyMessageEvent.cpp:
* Modules/encryptedmedia/legacy/WebKitMediaKeyNeededEvent.cpp:
* Modules/entriesapi/DOMFileSystem.cpp:
* Modules/entriesapi/FileSystemDirectoryReader.cpp:
* Modules/entriesapi/FileSystemEntry.cpp:
* Modules/fetch/FetchLoaderClient.h:
* Modules/gamepad/Gamepad.cpp:
* Modules/gamepad/GamepadEvent.h:
* Modules/gamepad/deprecated/Gamepad.cpp:
[ truncated ]

2017-10-19 Sam Weinig <sam@webkit.org>

[Bindings] Standardize on DOMPromise as the way to store passed in promises
@@ -33,7 +33,6 @@ namespace WebCore {

class WebKitPlaybackTargetAvailabilityEvent : public Event {
public:
~WebKitPlaybackTargetAvailabilityEvent() { }

static Ref<WebKitPlaybackTargetAvailabilityEvent> create(const AtomicString& eventType, bool available)
{
@@ -42,9 +42,7 @@ ApplePayError::ApplePayError(Code code, std::optional<ContactField> contactField
{
}

ApplePayError::~ApplePayError()
{
}
ApplePayError::~ApplePayError() = default;

}

@@ -38,9 +38,7 @@ ApplePayPaymentAuthorizedEvent::ApplePayPaymentAuthorizedEvent(const AtomicStrin
{
}

ApplePayPaymentAuthorizedEvent::~ApplePayPaymentAuthorizedEvent()
{
}
ApplePayPaymentAuthorizedEvent::~ApplePayPaymentAuthorizedEvent() = default;

EventInterface ApplePayPaymentAuthorizedEvent::eventInterface() const
{
@@ -38,9 +38,7 @@ ApplePayPaymentMethodSelectedEvent::ApplePayPaymentMethodSelectedEvent(const Ato
{
}

ApplePayPaymentMethodSelectedEvent::~ApplePayPaymentMethodSelectedEvent()
{
}
ApplePayPaymentMethodSelectedEvent::~ApplePayPaymentMethodSelectedEvent() = default;

EventInterface ApplePayPaymentMethodSelectedEvent::eventInterface() const
{
@@ -461,9 +461,7 @@ ApplePaySession::ApplePaySession(Document& document, ApplePaySessionPaymentReque
suspendIfNeeded();
}

ApplePaySession::~ApplePaySession()
{
}
ApplePaySession::~ApplePaySession() = default;

ExceptionOr<bool> ApplePaySession::supportsVersion(ScriptExecutionContext& scriptExecutionContext, unsigned version)
{
@@ -33,13 +33,9 @@

namespace WebCore {

ApplePaySessionPaymentRequest::ApplePaySessionPaymentRequest()
{
}
ApplePaySessionPaymentRequest::ApplePaySessionPaymentRequest() = default;

ApplePaySessionPaymentRequest::~ApplePaySessionPaymentRequest()
{
}
ApplePaySessionPaymentRequest::~ApplePaySessionPaymentRequest() = default;

bool ApplePaySessionPaymentRequest::isValidSupportedNetwork(unsigned version, const String& supportedNetwork)
{
@@ -38,9 +38,7 @@ ApplePayShippingContactSelectedEvent::ApplePayShippingContactSelectedEvent(const
{
}

ApplePayShippingContactSelectedEvent::~ApplePayShippingContactSelectedEvent()
{
}
ApplePayShippingContactSelectedEvent::~ApplePayShippingContactSelectedEvent() = default;

EventInterface ApplePayShippingContactSelectedEvent::eventInterface() const
{
@@ -49,9 +49,7 @@ ApplePayShippingMethodSelectedEvent::ApplePayShippingMethodSelectedEvent(const A
{
}

ApplePayShippingMethodSelectedEvent::~ApplePayShippingMethodSelectedEvent()
{
}
ApplePayShippingMethodSelectedEvent::~ApplePayShippingMethodSelectedEvent() = default;

EventInterface ApplePayShippingMethodSelectedEvent::eventInterface() const
{
@@ -36,9 +36,7 @@ ApplePayValidateMerchantEvent::ApplePayValidateMerchantEvent(const AtomicString&
{
}

ApplePayValidateMerchantEvent::~ApplePayValidateMerchantEvent()
{
}
ApplePayValidateMerchantEvent::~ApplePayValidateMerchantEvent() = default;

EventInterface ApplePayValidateMerchantEvent::eventInterface() const
{
@@ -37,19 +37,13 @@ struct ApplePayPayment;

class Payment {
public:
Payment()
{
}
Payment() = default;

explicit Payment(PKPayment *pkPayment)
: m_pkPayment(pkPayment)
{
}

~Payment()
{
}

ApplePayPayment toApplePayPayment() const;

PKPayment *pkPayment() const { return m_pkPayment.get(); }
@@ -58,7 +58,7 @@ class PaymentCoordinatorClient {
virtual void paymentCoordinatorDestroyed() = 0;

protected:
virtual ~PaymentCoordinatorClient() { }
virtual ~PaymentCoordinatorClient() = default;
};

}
@@ -34,9 +34,7 @@ BasicCredential::BasicCredential(const CredentialData& data, Type type)
{
}

BasicCredential::~BasicCredential()
{
}
BasicCredential::~BasicCredential() = default;

String BasicCredential::type() const
{
@@ -37,8 +37,6 @@ FederatedCredential::FederatedCredential(const FederatedCredentialInit& init)
{
}

FederatedCredential::~FederatedCredential()
{
}
FederatedCredential::~FederatedCredential() = default;

} // namespace WebCore
@@ -31,13 +31,9 @@

namespace WebCore {

NavigatorCredentials::NavigatorCredentials()
{
}
NavigatorCredentials::NavigatorCredentials() = default;

NavigatorCredentials::~NavigatorCredentials()
{
}
NavigatorCredentials::~NavigatorCredentials() = default;

const char* NavigatorCredentials::supplementName()
{
@@ -41,8 +41,6 @@ PasswordCredential::PasswordCredential(const HTMLFormElement&)
{
}

PasswordCredential::~PasswordCredential()
{
}
PasswordCredential::~PasswordCredential() = default;

} // namespace WebCore
@@ -36,7 +36,7 @@ class CDMInstance;

class CDMClient {
public:
virtual ~CDMClient() { }
virtual ~CDMClient() = default;

virtual void cdmClientAttemptToResumePlaybackIfNecessary() = 0;
};
@@ -117,9 +117,7 @@ LegacyCDM::LegacyCDM(const String& keySystem)
m_private = CDMFactoryForKeySystem(keySystem)->constructor(this);
}

LegacyCDM::~LegacyCDM()
{
}
LegacyCDM::~LegacyCDM() = default;

bool LegacyCDM::supportsMIMEType(const String& mimeType) const
{
@@ -45,7 +45,7 @@ typedef bool (*CDMSupportsKeySystemAndMimeType)(const String&, const String&);

class LegacyCDMClient {
public:
virtual ~LegacyCDMClient() { }
virtual ~LegacyCDMClient() = default;

virtual RefPtr<MediaPlayer> cdmMediaPlayer(const LegacyCDM*) const = 0;
};
@@ -36,8 +36,8 @@ class LegacyCDMSessionClient;

class CDMPrivateInterface {
public:
CDMPrivateInterface() { }
virtual ~CDMPrivateInterface() { }
CDMPrivateInterface() = default;
virtual ~CDMPrivateInterface() = default;

virtual bool supportsMIMEType(const String&) = 0;

@@ -40,7 +40,7 @@ class LegacyCDMPrivateClearKey : public CDMPrivateInterface {
{
}

virtual ~LegacyCDMPrivateClearKey() { }
virtual ~LegacyCDMPrivateClearKey() = default;

static bool supportsKeySystem(const String&);
static bool supportsKeySystemAndMimeType(const String& keySystem, const String& mimeType);
@@ -42,7 +42,7 @@ class CDMPrivateMediaPlayer : public CDMPrivateInterface {
static bool supportsKeySystem(const String&);
static bool supportsKeySystemAndMimeType(const String& keySystem, const String& mimeType);

virtual ~CDMPrivateMediaPlayer() { }
virtual ~CDMPrivateMediaPlayer() = default;

bool supportsMIMEType(const String& mimeType) override;
std::unique_ptr<LegacyCDMSession> createSession(LegacyCDMSessionClient*) override;
@@ -55,9 +55,7 @@ CDMSessionClearKey::CDMSessionClearKey(LegacyCDMSessionClient* client)
{
}

CDMSessionClearKey::~CDMSessionClearKey()
{
}
CDMSessionClearKey::~CDMSessionClearKey() = default;

RefPtr<Uint8Array> CDMSessionClearKey::generateKeyRequest(const String& mimeType, Uint8Array* initData, String& destinationURL, unsigned short& errorCode, uint32_t& systemCode)
{
@@ -47,9 +47,7 @@ WebKitMediaKeyMessageEvent::WebKitMediaKeyMessageEvent(const AtomicString& type,
{
}

WebKitMediaKeyMessageEvent::~WebKitMediaKeyMessageEvent()
{
}
WebKitMediaKeyMessageEvent::~WebKitMediaKeyMessageEvent() = default;

EventInterface WebKitMediaKeyMessageEvent::eventInterface() const
{
@@ -44,9 +44,7 @@ WebKitMediaKeyNeededEvent::WebKitMediaKeyNeededEvent(const AtomicString& type, c
{
}

WebKitMediaKeyNeededEvent::~WebKitMediaKeyNeededEvent()
{
}
WebKitMediaKeyNeededEvent::~WebKitMediaKeyNeededEvent() = default;

EventInterface WebKitMediaKeyNeededEvent::eventInterface() const
{
@@ -149,9 +149,7 @@ DOMFileSystem::DOMFileSystem(Ref<File>&& file)
ASSERT(!m_rootPath.endsWith('/'));
}

DOMFileSystem::~DOMFileSystem()
{
}
DOMFileSystem::~DOMFileSystem() = default;

Ref<FileSystemDirectoryEntry> DOMFileSystem::root(ScriptExecutionContext& context)
{
@@ -43,9 +43,7 @@ FileSystemDirectoryReader::FileSystemDirectoryReader(ScriptExecutionContext& con
suspendIfNeeded();
}

FileSystemDirectoryReader::~FileSystemDirectoryReader()
{
}
FileSystemDirectoryReader::~FileSystemDirectoryReader() = default;

const char* FileSystemDirectoryReader::activeDOMObjectName() const
{
@@ -45,9 +45,7 @@ FileSystemEntry::FileSystemEntry(ScriptExecutionContext& context, DOMFileSystem&
suspendIfNeeded();
}

FileSystemEntry::~FileSystemEntry()
{
}
FileSystemEntry::~FileSystemEntry() = default;

DOMFileSystem& FileSystemEntry::filesystem() const
{
@@ -37,7 +37,7 @@ class ResourceResponse;

class FetchLoaderClient {
public:
virtual ~FetchLoaderClient() { }
virtual ~FetchLoaderClient() = default;

virtual void didReceiveResponse(const ResourceResponse&) { }

@@ -46,9 +46,7 @@ Gamepad::Gamepad(const PlatformGamepad& platformGamepad)
m_buttons.append(GamepadButton::create());
}

Gamepad::~Gamepad()
{
}
Gamepad::~Gamepad() = default;

const Vector<double>& Gamepad::axes() const
{
@@ -35,7 +35,7 @@ namespace WebCore {

class GamepadEvent : public Event {
public:
~GamepadEvent() { }
~GamepadEvent() = default;

static Ref<GamepadEvent> create(const AtomicString& eventType, Gamepad& gamepad)
{
@@ -52,9 +52,7 @@ void Gamepad::buttons(unsigned count, float* data)
std::copy(data, data + count, m_buttons.begin());
}

Gamepad::~Gamepad()
{
}
Gamepad::~Gamepad() = default;

} // namespace WebCore

@@ -32,9 +32,7 @@

namespace WebCore {

GamepadList::~GamepadList()
{
}
GamepadList::~GamepadList() = default;

void GamepadList::set(unsigned index, RefPtr<Gamepad>&& gamepad)
{

0 comments on commit 3882108

Please sign in to comment.