Skip to content
Permalink
Browse files
Web Inspector: Uncaught exception page should pre-populate the bug's …
…URL with the inspected page URL

https://bugs.webkit.org/show_bug.cgi?id=158055
<rdar://problem/26516693>

Reviewed by Saam Barati.

* UserInterface/Debug/UncaughtExceptionReporter.js:
Include the encoded URL in the query string if it is not empty.


Canonical link: https://commits.webkit.org/176302@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@201502 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
burg committed May 30, 2016
1 parent 223020a commit 38ddb1377bfd45fe50879775c5f4ef61905e872a
Showing with 15 additions and 3 deletions.
  1. +11 −0 Source/WebInspectorUI/ChangeLog
  2. +4 −3 Source/WebInspectorUI/UserInterface/Debug/UncaughtExceptionReporter.js
@@ -1,3 +1,14 @@
2016-05-30 Brian Burg <bburg@apple.com>

Web Inspector: Uncaught exception page should pre-populate the bug's URL with the inspected page URL
https://bugs.webkit.org/show_bug.cgi?id=158055
<rdar://problem/26516693>

Reviewed by Saam Barati.

* UserInterface/Debug/UncaughtExceptionReporter.js:
Include the encoded URL in the query string if it is not empty.

2016-05-30 Matt Baker <mattbaker@apple.com>

Web Inspector: Right-clicking in Snapshot's DataGrid throws an exception
@@ -147,7 +147,7 @@ function createErrorSheet() {
dismissErrorSheet();
}

let inspectedPageURL = "(unknown)";
let inspectedPageURL = null;
try {
inspectedPageURL = WebInspector.frameResourceManager.mainFrame.url;
} catch (e) { }
@@ -157,7 +157,7 @@ function createErrorSheet() {
let encodedBugDescription = encodeURIComponent(`-------
Auto-generated details:
Inspected URL: ${inspectedPageURL}
Inspected URL: ${inspectedPageURL || "(unknown)"}
Loading completed: ${!!loadCompleted}
Frontend User Agent: ${window.navigator.userAgent}
Uncaught exceptions:
@@ -172,7 +172,8 @@ ${detailsForBugReport}
Document any additional information that might be useful in resolving the problem, such as screen shots or other included attachments.
`);
let encodedBugTitle = encodeURIComponent(`Uncaught Exception: ${firstException.message}`);
let prefilledBugReportLink = `https://bugs.webkit.org/enter_bug.cgi?alias=&assigned_to=webkit-unassigned%40lists.webkit.org&attach_text=&blocked=&bug_file_loc=http%3A%2F%2F&bug_severity=Normal&bug_status=NEW&comment=${encodedBugDescription}&component=Web%20Inspector&contenttypeentry=&contenttypemethod=autodetect&contenttypeselection=text%2Fplain&data=&dependson=&description=&flag_type-1=X&flag_type-3=X&form_name=enter_bug&keywords=&op_sys=All&priority=P2&product=WebKit&rep_platform=All&short_desc=${encodedBugTitle}&version=WebKit%20Nightly%20Build`;
let encodedInspectedURL = encodeURIComponent(inspectedPageURL || "http://");
let prefilledBugReportLink = `https://bugs.webkit.org/enter_bug.cgi?alias=&assigned_to=webkit-unassigned%40lists.webkit.org&attach_text=&blocked=&bug_file_loc=${encodedInspectedURL}&bug_severity=Normal&bug_status=NEW&comment=${encodedBugDescription}&component=Web%20Inspector&contenttypeentry=&contenttypemethod=autodetect&contenttypeselection=text%2Fplain&data=&dependson=&description=&flag_type-1=X&flag_type-3=X&form_name=enter_bug&keywords=&op_sys=All&priority=P2&product=WebKit&rep_platform=All&short_desc=${encodedBugTitle}&version=WebKit%20Nightly%20Build`;
let detailsForHTML = formattedErrorDetails.map((line) => `<li>${insertWordBreakCharacters(line)}</li>`).join("\n");

let dismissOptionHTML = !loadCompleted ? "" : `<dt>A frivolous exception will not stop me!</dt>

0 comments on commit 38ddb13

Please sign in to comment.