Skip to content
Permalink
Browse files
[Chromium] plugins/keyboard-events.html should pass on linux/mac
https://bugs.webkit.org/show_bug.cgi?id=65964

Patch by Noel Gordon <noel.gordon@gmail.com> on 2011-08-22
Reviewed by Tony Chang.

Update the Chromium Linux test results following r88712.  Also rebaseline test results
for Chromium Mac.  Note the WebKit Mac and Win ports both report 0 for the line number
for all console.log() events.  The Chromium port reports the actual line number, hence
the need for separate test results for Chromium.  The test now runs, and passes on all
the Chromium ports, following r87855.  The test confirms user-plugin interactivity, so
we don't regress sites like youtube.com.  Refer to bug 34936.

* platform/chromium-linux/plugins/keyboard-events-expected.txt: Added.
* platform/chromium-mac/plugins/keyboard-events-expected.txt: Added.
* platform/chromium/test_expectations.txt:

Canonical link: https://commits.webkit.org/82501@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93519 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
Noel Gordon authored and webkit-commit-queue committed Aug 22, 2011
1 parent a8aac22 commit 38e27c7a80b3ea697593f9a35bfe1d8a78b65403
Showing 4 changed files with 40 additions and 3 deletions.
@@ -1,3 +1,21 @@
2011-08-22 Noel Gordon <noel.gordon@gmail.com>

[Chromium] plugins/keyboard-events.html should pass on linux/mac
https://bugs.webkit.org/show_bug.cgi?id=65964

Reviewed by Tony Chang.

Update the Chromium Linux test results following r88712. Also rebaseline test results
for Chromium Mac. Note the WebKit Mac and Win ports both report 0 for the line number
for all console.log() events. The Chromium port reports the actual line number, hence
the need for separate test results for Chromium. The test now runs, and passes on all
the Chromium ports, following r87855. The test confirms user-plugin interactivity, so
we don't regress sites like youtube.com. Refer to bug 34936.

* platform/chromium-linux/plugins/keyboard-events-expected.txt: Added.
* platform/chromium-mac/plugins/keyboard-events-expected.txt: Added.
* platform/chromium/test_expectations.txt:

2011-08-22 Ben Wells <benwells@chromium.org>

Rebaseline for webkit bug 65295
@@ -0,0 +1,11 @@
CONSOLE MESSAGE: line 18: PLUGIN: getFocusEvent
CONSOLE MESSAGE: line 18: PLUGIN: mouseDown at (12, 12)
CONSOLE MESSAGE: line 19: PLUGIN: mouseUp at (12, 12)
CONSOLE MESSAGE: line 22: PLUGIN: keyDown ' '
CONSOLE MESSAGE: line 22: PLUGIN: keyUp ' '
CONSOLE MESSAGE: line 23: PLUGIN: keyDown ' '
CONSOLE MESSAGE: line 23: PLUGIN: keyUp ' '
CONSOLE MESSAGE: line 24: PLUGIN: keyDown ' '
CONSOLE MESSAGE: line 24: PLUGIN: keyUp ' '

This test checks if a plug-in can receive keyboard events sent from eventSender. This is a test for Bug 34936.
@@ -0,0 +1,11 @@
CONSOLE MESSAGE: line 18: PLUGIN: getFocusEvent
CONSOLE MESSAGE: line 18: PLUGIN: mouseDown at (12, 12)
CONSOLE MESSAGE: line 19: PLUGIN: mouseUp at (12, 12)
CONSOLE MESSAGE: line 22: PLUGIN: keyDown 'a'
CONSOLE MESSAGE: line 22: PLUGIN: keyUp 'a'
CONSOLE MESSAGE: line 23: PLUGIN: keyDown 'b'
CONSOLE MESSAGE: line 23: PLUGIN: keyUp 'b'
CONSOLE MESSAGE: line 24: PLUGIN: keyDown 'c'
CONSOLE MESSAGE: line 24: PLUGIN: keyUp 'c'

This test checks if a plug-in can receive keyboard events sent from eventSender. This is a test for Bug 34936.
@@ -747,9 +747,6 @@ BUGCR61799 BUGWK64319 SKIP : plugins/evaluate-js-after-removing-plugin-element.h
BUGCR37962 MAC : plugins/iframe-shims.html = PASS TIMEOUT TEXT
BUGCR10351 MAC : plugins/inner-html-display-none.html = FAIL
BUGWK48164 : plugins/invalid-mime-with-valid-extension-shows-missing-plugin.html = TEXT
// Need to implement NPP_HandleEvent in the layout_test_plugin
// WIN started failing during webkit roll 62670 -> 62844.
BUGCR38353 LINUX MAC : plugins/keyboard-events.html = TEXT
// Object.keys on an NPObject produces the wrong output.
BUGCR21901 : plugins/npruntime/enumerate.html = TEXT
BUGCR50787 : plugins/npruntime/plugin-scriptable-object-invoke-default.html = TEXT

0 comments on commit 38e27c7

Please sign in to comment.